BIP352 tracking issue

[josibake]

This issue will be updated to reflect the current state of BIP352 integration.

PRs ready for review:

• BIP 352: Silent Payments bips#1458
• Add BIP352 silentpayments module bitcoin-core/secp256k1#1519
• Silent Payments: Implement BIP352 #28122

Testing:

• For a wallet with send and receive support, compile wallet: Receive silent payment transactions #28453
• Post your signet / testnet silent payment address in the comments!

Overall plan:

• Send and receive support in the Bitcoin Core wallet:

  • Code cleanup / refactor: Break up script/standard.{h/cpp} #28244
  • Dependency: wallet: Use CTxDestination in CRecipient instead of just scriptPubKey #28246
  • Dependency: wallet: Pass through transaction locktime and preset input sequences and scripts to CreateTransaction #25273
  • Dependency: wallet, rpc: FundTransaction refactor #28560
  • Implement silent payments as a libsecp module: Add BIP352 silentpayments module bitcoin-core/secp256k1#1519
  • Base protocol: Silent Payments: Implement BIP352 #28122
  • Sending (depends on 28122, 25273, 28560): Silent Payments: sending #28201
  • Receiving (depends on 28122, 28201): wallet: Receive silent payment transactions #28453
  • Send and receive functional tests (depends on 28453) (not started)

• Light client support:

  • Index for silent payment tweaks (depends on 28122): Silent payment index (for light wallets and consistency check) #28241
  • New BIP157 filter type for tweak data (not started)
  • Serve new filter type (not started)

Older stuff

• Closed / Superseded:
  • Tracking PR (superseded by this issue): Silent Payments: send and receive #27827
  • Receiving (superseded by 28453): Silent Payments: receiving #28202
  • Original draft implementation: [Draft / POC] Silent Payments #24897
  • Original libsecp256k1 module (superseded by 1519): Add silentpayments (BIP352) module bitcoin-core/secp256k1#1471

[josibake]

Review comments from #28246 that can be done as follow-ups:

• wallet: Use CTxDestination in CRecipient instead of just scriptPubKey #28246 (comment)
• wallet: Use CTxDestination in CRecipient instead of just scriptPubKey #28246 (comment)
• wallet: Use CTxDestination in CRecipient instead of just scriptPubKey #28246 (comment)

[josibake]

Signet address: tsp1qqwzyz4wvrxnpauh9wj5x0lycvhhf0ff6gv0v0cyc6fcss7knlw3vzquefh7c4j7et3u0f059zw8zzyd97e6j4h4ldfs06t6pen9904w4fvpdukyc

[setavenger]

@josibake Sent you some, using a light client so I hope this worked.

---

Signet:
tsp1qqfnlnlnwwrcn7x09u0p0fm6l3698pw9s6mzlg6wv99dempzxmz53sqklscmpcwzkcmuvr4s503w220qgslyhfyxln3tqevfllmu6epvrlu5z457e

[josibake]

@setavenger received, 0.00021000! I tried sending it back but it appears your address is invalid PEBCAK. I'd like to keep this issue focused on the integration for Bitcoin Core, but feel free to join the silent payments IRC channel (#silentpayments) or reach out on twitter (@josibake) so we can keep testing!

[theStack]

• Move base protocol to libsecp as a module (not started)

FWIW, I've started digging a bit deeper into that and started a corresponding discussion in the libsecp256k1 repo: bitcoin-core/secp256k1#1427 (still trying to figure out a sane interface...)