rpc: getaddrmaninfo followups #28565
Conversation
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. Code CoverageFor detailed information about the code coverage, see the test coverage report. ReviewsSee the guideline for information on the review process.
If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update. ConflictsNo conflicts as of last run. |
stratospher
force-pushed
the
getaddrmaninfo_followups
branch
from
0538579
to
b62f7d6
Compare
|
Code Review ACK b62f7d6 The changes look good to me. I think it makes sense to un-hide this RPC. Reviewers might want to use |
|
added a new commit to include refactor suggestion in #27511 (comment). |
That's useful for #28523 too. Can be included there in a follow up. |
- make `getaddrmaninfo` RPC public since it's not for development purposes only and regular users might find it useful - add missing `all_networks` key to RPC help - use clang format spacing
stratospher
force-pushed
the
getaddrmaninfo_followups
branch
from
00421fe
to
e6e444c
Compare
Rebased and included the |
There was a problem hiding this comment.
tested ACK e6e444c
Verified that the rpc command `getaddrmaninfo` is now public (not hidden anymore),
./src/bitcoin-cli -signet help
...
...
RPC Help shows `all_networks`
and RPC Help doesn't display "This RPC is for testing only." anymore
before
after
|
Code Review re-ACK e6e444c |
- make `getaddrmaninfo` RPC public since it's not for development purposes only and regular users might find it useful - add missing `all_networks` key to RPC help - use clang format spacing Github-Pull: bitcoin#28565 Rebased-From: 3931e6a
getaddrmaninfoRPC public since it's not for development purposes only and regular users might find it useful. #26988 (comment)all_networkskey to RPC help. #27511 (comment)EnsureAddrmanin RPC code. #27511 (comment)