Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show sighash flags #3166

Closed
gmaxwell opened this issue Oct 27, 2013 · 3 comments · Fixed by #5264 or PIVX-Project/PIVX#1633
Closed

Show sighash flags #3166

gmaxwell opened this issue Oct 27, 2013 · 3 comments · Fixed by #5264 or PIVX-Project/PIVX#1633
Labels
Refactoring

Comments

@gmaxwell
Copy link
Contributor

We should be showing sighash flags on signatures in transaction decodes.
@jgarzik
Copy link
Contributor

jgarzik commented Oct 27, 2013

+1

@laanwj
Copy link
Member

laanwj commented Nov 11, 2013

To be clear: the sighash flags are the nHashType byte (enumeration SIGHASH_*), which is stored in the last byte of vchSig?

As this value is pushed to the stack in a prior op, this would require a non-trivial change to transaction decodes (which I suppose means those in Script::ToString https://github.com/bitcoin/bitcoin/blob/master/src/script.h#L580) that 'reasons backwards'? Or do I miss something?

@ExperimentsAndIdeas
Copy link

+1 to fix the missing SIGHASH in JSON output... I would like this feature.

@mruddy mruddy mentioned this issue Nov 12, 2014
Merged
@mruddy mruddy mentioned this issue Dec 8, 2014
Closed
str4d pushed a commit to str4d/zcash that referenced this issue Apr 17, 2018
@mruddy @str4d
Resolve issue bitcoin/bitcoin#3166.
690d38f 
These changes decode valid SIGHASH types on signatures in assembly (asm) representations of scriptSig scripts.
This squashed commit incorporates substantial helpful feedback from jtimon, laanwj, and sipa.
Bushstar pushed a commit to Bushstar/omnicore that referenced this issue Apr 8, 2020
@UdjinM6 @codablock
Actually update spent index on DisconnectBlock (bitcoin#3167)
dfd6ee4 
Fixes bitcoin#3166
Bushstar pushed a commit to Bushstar/omnicore that referenced this issue Apr 8, 2020
@UdjinM6 @codablock
Actually update spent index on DisconnectBlock (bitcoin#3167)
ce66871 
Fixes bitcoin#3166
random-zebra added a commit to random-zebra/PIVX that referenced this issue May 20, 2020
@random-zebra
Resolve issue bitcoin#3166
26b9de4 
These changes decode valid SIGHASH types on signatures in assembly (asm)
representations of scriptSig scripts.
This squashed commit incorporates substantial helpful feedback from
jtimon, laanwj, and sipa.

backports bitcoin/bitcoin@af3208b
@random-zebra random-zebra mentioned this issue May 20, 2020
Merged
1 task
random-zebra added a commit to random-zebra/PIVX that referenced this issue May 27, 2020
@random-zebra
Resolve issue bitcoin#3166
3383983 
These changes decode valid SIGHASH types on signatures in assembly (asm)
representations of scriptSig scripts.
This squashed commit incorporates substantial helpful feedback from
jtimon, laanwj, and sipa.

backports bitcoin/bitcoin@af3208b
furszy added a commit to PIVX-Project/PIVX that referenced this issue May 29, 2020
@furszy
Merge #1633: [Core] Bitcoin 0.12-0.14 serialization improvements
8cd9c59 
249cc9d Avoid -Wshadow errors (random-zebra)
8e1ec9e Use fixed preallocation instead of costly GetSerializeSize (random-zebra)
9b801d0 Add optimized CSizeComputer serializers (random-zebra)
0035a54 Make CSerAction's ForRead() constexpr (random-zebra)
9730a3f Get rid of nType and nVersion (random-zebra)
25ce2bb Make GetSerializeSize a wrapper on top of CSizeComputer (random-zebra)
1b479db Make nType and nVersion private and sometimes const (random-zebra)
35f1755 Make streams' read and write return void (random-zebra)
a395914 Remove unused ReadVersion and WriteVersion (random-zebra)
52e614c [WIP] Remove unused statement in serialization (random-zebra)
82a2021 Add COMPACTSIZE wrapper similar to VARINT for serialization (random-zebra)
13ad779 add bip32 pubkey serialization (random-zebra)
9e9b7b5 [QA] Update json files with sig hash type in ASM for bitcoin-util-test (random-zebra)
3383983 Resolve issue bitcoin#3166 (random-zebra)

Pull request description:

  -Based on top of
  - [x] #1629

  Backports the following serialization improvements from upstream and adds the required changes for the 2nd layer network and the legacy zerocoin code.

  - bitcoin#5264
    > show scriptSig signature hash types. fixes bitcoin#3166
    >
    > The fix basically appends the scriptSig signature hash types, within parentheses, onto the end of the signature(s) in the various "asm" json outputs. That's just the first formatting idea that came to my mind.
    >
    > Added some tests for this too.

  - bitcoin#6215
    > CExtPubKey should be serializable like CPubKey.
    > This would allow storing extended private and public key to support BIP32/HD wallets.

  - bitcoin#8068 (only commit 5249dac)
     This adds COMPACTSIZE wrapper similar to VARINT for serialization

  - bitcoin#8658
    > As the line
    > ```
    > nVersion = this->nVersion;
    > ```
    > seems to have no meaning in READ and also in WRITE serialization op, let's remove it and see what our tests/travis will tell us. See bitcoin#8468 for previous discussion.

  - bitcoin#9039
    > The commits in this pull request implement a sequence of changes:
    >
    > - Simplifications:
    >   - **Remove unused ReadVersion and WriteVersion** CDataStream and CAutoFile had a ReadVersion and WriteVersion method that was never used. Remove them.
    >   - **Make nType and nVersion private and sometimes const** Make the various stream implementations' nType and nVersion private and const (except in CDataStream where we really need a setter).
    >   - **Make streams' read and write return void** The stream implementations have two layers (the upper one with operator<< and operator>>, and a lower one with read and write). The lower layer's return values are never used (nor should they, as they should only be used from the higher layer), so make them void.
    >   - **Make GetSerializeSize a wrapper on top of CSizeComputer** Given that in default GetSerializeSize implementations we're already using CSizeComputer(), get rid of the specialized GetSerializeSize methods everywhere, and just use CSizeComputer. This removes a lot of code which isn't actually used anywhere. In a few places, this removes an actually more efficient size computing algorithm, which we'll bring back in the "Add optimized CSizeComputer serializers" commit later.
    >   - **Get rid of nType and nVersion** The big change: remove the nType and nVersion as parameters to all serialization methods and functions. There is only one place where it's read and has an impact (in CAddress), and even there it does not impact any of the member objects' serializations. Instead, the few places that need nType or nVersion read it directly from the stream, through GetType and GetVersion calls which are added to all streams.
    >   - **Avoid -Wshadow errors** As suggested by @paveljanik, remove the few remaining cases of variable shadowing in the serialization code.
    > - Optimizations:
    >   - **Make CSerAction's ForRead() constexpr** The CSerAction's ForRead() method does not depend on any runtime data, so guarantee that requests to it can be optimized out by making it constexpr (suggested by @theuni in bitcoin#8580).
    >   - **Add optimized CSizeComputer serializers** To get the advantages of faster GetSerializeSize implementations back, reintroduce them in the few places where they actually make a difference, in the form of a specialized Serialize implementation. This actually gets us in a better state than before, as these even get used when they're nested inside the serialization of another object.
    >   - **Use fixed preallocation instead of costly GetSerializeSize** dbwrapper uses GetSerializeSize to compute the size of the buffer to preallocate. For some cases (specifically: CCoins) this requires a costly compression call. Avoid this by just using fixed size preallocations instead.
    >
    > This will make it easier to address @TheBlueMatt's comments in bitcoin#8580, resulting is a simpler and more efficient way to simultaneously deserialize+construct objects with const members from streams.

ACKs for top commit:
  furszy:
    Long and nice PR 👌 , code review ACK 249cc9d .
  Fuzzbawls:
    ACK 249cc9d
  furszy:
    tested ACK 249cc9d and merging.

Tree-SHA512: 56b07634b1e18871e7c9a99d412282c83b85f77f1672ec56330a1131fc7c234cd1ba3a053bdd210cc29f1e636ee374477ff614fa9a930329a7f8f912c5006232
@bitcoin bitcoin locked as resolved and limited conversation to collaborators Sep 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Refactoring
Projects
None yet
Milestone
No milestone
4 participants
@laanwj @jgarzik @ExperimentsAndIdeas @gmaxwell