Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

A few problems with 0.9.0rc2 #3840

Closed
subSTRATA opened this issue Mar 10, 2014 · 8 comments
Closed

A few problems with 0.9.0rc2 #3840

subSTRATA opened this issue Mar 10, 2014 · 8 comments

Comments

@subSTRATA
Copy link

Posted on bitcointalk, let me know if you want me to split it all into multiple issues.

https://bitcointalk.org/index.php?topic=144331.msg5627812#msg5627812

subSTRATA
@laanwj
Copy link
Member

laanwj commented Mar 11, 2014

  1. New client does not recognize testnet=1 over bitcoin.conf file. Using -testnet over command line helped but then ...

Verified this, the GUI indeed doesn't support providing -testnet/-regtest/... in the config file at the moment.

  1. New client failed to recognize testnet datadir (testnet3) is a subdirectory of datadir root so it shocked me a bit to see 0 coins and no blockchain
    downloaded. To solve issue, I had to copy all data from testnet3 subdirectory to datadir root (are we getting testnet4 maybe?).

I cannot reproduce this. Everywhere I've tested, testnet is still in testnet3 inside the data directory.

Wasn't this caused by the client ignoring -testnet in the configuration file?

Are you doing anything special with regard to command line arguments? What is in your bitcoin.conf / command line?

[Leaving 3 and 4 which are coin-control specific details to @cozz]

  1. Not related to Coin Control but annoying, there is no "Copy address" upon right-clicking some receiving address nor address itself is shown

This is as intended. The QR code window that appears when you request a payment or double-click an earlier invoice has a 'copy address' button.

laanwj added a commit to laanwj/bitcoin that referenced this issue Mar 11, 2014
@laanwj
qt: Make it possible again to specify -testnet in config file
57a2d95 
Changes for the datadir chooser have made it impossible to specify
the network (testnet/regtest) in the configuration file for the GUI.

Reorganize the initialization sequence to make this possible again.

- Moves the "datadir" QSetting so that is no longer dependent on the
  network-specific application name (doing otherwise would create a
  chicken-and-egg problem).

- Re-initialize translations after choosing network. There may be a
  different language configured in network-specific settings
  (slim chance, but handle it for sanity).

Fixes point 1 of bitcoin#3840.
@laanwj laanwj mentioned this issue Mar 11, 2014
Merged
@laanwj
Copy link
Member

laanwj commented Mar 11, 2014

See #3844.

laanwj added a commit to laanwj/bitcoin that referenced this issue Mar 11, 2014
@laanwj
qt: Make it possible again to specify -testnet in config file
c52c4e5 
Changes for the datadir chooser have made it impossible to specify
the network (testnet/regtest) in the configuration file for the GUI.

Reorganize the initialization sequence to make this possible again.

- Moves the "datadir" QSetting so that is no longer dependent on the
  network-specific application name (doing otherwise would create a
  chicken-and-egg problem).

- Re-initialize translations after choosing network. There may be a
  different language configured in network-specific settings
  (slim chance, but handle it for sanity).

Fixes point 1 of bitcoin#3840.
@cozz cozz mentioned this issue Mar 11, 2014
Merged
@cozz
Copy link
Contributor

cozz commented Mar 11, 2014

about 3) see #3846

about 4)
No critical bug, it only means that manual created change addresses always appear in
their own group in tree mode.
The wallet only can consider addresses without an address book entry as change.
There is a big fat TODO in CWallet::IsChange(..) already.
Unless we change the way the wallet recognizes change in general, there is not much I can do about this for now.

@laanwj I noticed the final linux builds are qt4, but windows is qt5. Any reason?

@laanwj
Copy link
Member

laanwj commented Mar 11, 2014

Yes, Linux builds will keep using Qt4 for the forseeable feature, because it's more compatible.

laanwj added a commit that referenced this issue Mar 11, 2014
@laanwj
qt: Make it possible again to specify -testnet in config file
17d955f 
Changes for the datadir chooser have made it impossible to specify
the network (testnet/regtest) in the configuration file for the GUI.

Reorganize the initialization sequence to make this possible again.

- Moves the "datadir" QSetting so that is no longer dependent on the
  network-specific application name (doing otherwise would create a
  chicken-and-egg problem).

- Re-initialize translations after choosing network. There may be a
  different language configured in network-specific settings
  (slim chance, but handle it for sanity).

Fixes point 1 of #3840.

Rebased-From: c52c4e5
@subSTRATA
Copy link
Author

@laanwj

"I cannot reproduce this. Everywhere I've tested, testnet is still in testnet3 inside the data directory.
Wasn't this caused by the client ignoring -testnet in the configuration file?
Are you doing anything special with regard to command line arguments? What is in your bitcoin.conf / command line?"

bitcoin-qt.exe -testnet -datadir=D:\BitcoinTestnetData

server=1
rpcuser=(usernamegoeshere)
rpcpassword=(passwordgoeshere)
rpcallowip=127.0.0.1
rpcport=8332
testnet=1
banscore=10
listen=0
onlynet=IPv4
par=1
printtoconsole=1

Related to number 2. at https://bitcointalk.org/index.php?topic=144331.msg5627812#msg5627812

@laanwj
Copy link
Member

laanwj commented Mar 17, 2014

Have you tried with rc3?

@subSTRATA
Copy link
Author

RC3 works fine except issue with checkboxes, as explained earlier.

@laanwj
Copy link
Member

laanwj commented Mar 19, 2014

The checkbox problem is not critical and was thus not backported to 0.9. It will be fixed in the next release.
Thanks for testing.

@laanwj laanwj closed this as completed Mar 19, 2014
MathyV pushed a commit to reddcoin-project/reddcoin-3.10 that referenced this issue Oct 27, 2014
@laanwj @MathyV
qt: Make it possible again to specify -testnet in config file
8d8abb9 
Changes for the datadir chooser have made it impossible to specify
the network (testnet/regtest) in the configuration file for the GUI.

Reorganize the initialization sequence to make this possible again.

- Moves the "datadir" QSetting so that is no longer dependent on the
  network-specific application name (doing otherwise would create a
  chicken-and-egg problem).

- Re-initialize translations after choosing network. There may be a
  different language configured in network-specific settings
  (slim chance, but handle it for sanity).

Fixes point 1 of bitcoin#3840.

Conflicts:
	src/qt/bitcoin.cpp
@bitcoin bitcoin locked as resolved and limited conversation to collaborators Sep 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@laanwj @cozz @subSTRATA