Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add NoRBF to URI Scheme #7343

Closed
seweso opened this issue Jan 14, 2016 · 14 comments
Closed

Add NoRBF to URI Scheme #7343

seweso opened this issue Jan 14, 2016 · 14 comments

Comments

@seweso
Copy link

seweso commented Jan 14, 2016

Before Opt-In RBF is deployed it is probably wise to be able to indicated that RBF is not supposed to be used in a payment.

This might have the added benefit of showing that RBF does not actually kill zero-conf (which many people wrongfully believe).

@luke-jr
Copy link
Member

luke-jr commented Jan 14, 2016

Core's wallet never sets the RBF flag anyway, so there is literally nothing to add here.

@seweso
Copy link
Author

seweso commented Jan 14, 2016

It is not even going to be an option? Or is that something which will only be added when there is also the option to actually manage RBF transactions?

Know anything about other wallets who are preparing to enable RBF transactions/management? Would they be able to define a new NoRBF flag amongst themselves?

@jonasschnelli
Copy link
Contributor

There are two open RBF related PRs:

I'm also working on a QT RBF option.

@laanwj
Copy link
Member

laanwj commented Jan 16, 2016

Which URI scheme?

@sipa
Copy link
Member

sipa commented Jan 16, 2016

I guess this would require an extension to BIP21.

@seweso
Copy link
Author

seweso commented Jan 17, 2016

@sipa Yes. It only needs to be a "if you do this, then do it this way please" kind of thing. If Core doesn't yet opt-in to RBF then this doesn't need to be implemented yet. But would be nice if it would get implemented eventually.

@dcousens
Copy link
Contributor

@seweso maybe follow up BIP21 with an extension request? Not sure of the process around that.

seweso added a commit to seweso/bips that referenced this issue Jan 18, 2016
@seweso
Copy link
Author

seweso commented Jan 18, 2016

bitcoin/bips@master...seweso:patch-1

Although maybe it should be fullrbf=0, because parameter names with "no" in it are weird.

@laanwj
Copy link
Member

laanwj commented Jan 19, 2016

Ah, you mean BIP21. You can't just change BIP21, it would need to be a new BIP that extends it, like BIP72.

At which point you'll probably get the question 'why add the flag to the URI, not to the Payment Protocol'?

@seweso
Copy link
Author

seweso commented Jan 19, 2016

@laanwj I know what I want, not the how. That's why. Wouldn't an issue tracker for Bip's be handy? For mere mortals I mean

@laanwj
Copy link
Member

laanwj commented Jan 20, 2016

Wouldn't an issue tracker for Bip's be handy? For mere mortals I mean

A central tracker wouldn't work for that. There is no one responsible for BIPs in general. Everyone can submit a BIP and becomes the author of that.

The most that you can do is mail the author of the specific BIP with your concerns/issues. But as said, be aware that BIPs like BIP22 are set in stone by sake of being implemented by a lot of different software. So the only way to propose an extension is to create a new BIP (see https://github.com/bitcoin/bips/blob/master/bip-0001.mediawiki for information on creating BIPs), not by changing the old one.

@seweso
Copy link
Author

seweso commented Jan 21, 2016

@laanwj Well some kind of naming convention for extension BIP's would be nice (like BIP21E01). And having the entire scheme in one place is handy. Is there something like that?

Is the name "NoRBF" at least reasonable?

@laanwj
Copy link
Member

laanwj commented Jan 22, 2016

You don't need a new naming convention. BIPs have a number, not a name. There is no issue heree, you can just refer to the original BIP. I've given an example above of another BIP that extends the URI scheme.

Would be better to discuss this on the -dev mailing list instead.

@laanwj
Copy link
Member

laanwj commented Apr 28, 2016

As said above, this needs a BIP with an URI extension proposal, this cannot be considered before that. Closing as this is the wrong place.

@laanwj laanwj closed this as completed Apr 28, 2016
@bitcoin bitcoin locked as resolved and limited conversation to collaborators Sep 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

6 participants