Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Different recommendations for "maxuploadtarget" in docs vs. 13.0rc3 debug.log #8555

Closed
ghost opened this issue Aug 20, 2016 · 5 comments
Closed

Comments

@ghost
Copy link

ghost commented Aug 20, 2016

Using 13.0rc3
Here
https://github.com/bitcoin/bitcoin/blob/master/doc/reduce-traffic.md
is written, regarding -maxuploadtarget: "The recommended minimum is 144 blocks per day (max. 144MB per day)".

Using -maxuploadtarget=200 leads to the following message in debug.log:
"Max outbound target is very small (209715200 bytes) and will be overshot. Recommended minimum is 576000000 bytes."

The different recommendations should be harmonized.

I would also suggest to consistentley use "MiB". E.g. no "MB".

Instead of "Recommended minimum is 576000000 bytes." I would suggest to write "Recommended minimum is 550 MiB." (rounded up)

Instead of "Max outbound target is very small (209715200 bytes) ..." should be written "Max outbound target is very small (200 MiB) ..."

@jonasschnelli
Copy link
Contributor

Thanks for the report. I'll have a look at that.

@maflcko
Copy link
Member

maflcko commented Aug 20, 2016

This was missed in 2b1f6f9, should be easy to fix.

@sipa
Copy link
Member

sipa commented Aug 22, 2016

Fix for 0.13.0?

@jonasschnelli
Copy link
Contributor

Its just a warning, the miscalculation is a little bit ugly, but I think a fix in 0.13.1 is okay.

@laanwj
Copy link
Member

laanwj commented Sep 14, 2016

Closed by #8712

@laanwj laanwj closed this as completed Sep 14, 2016
@bitcoin bitcoin locked as resolved and limited conversation to collaborators Sep 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants