Refactor: Stop using namespace std (bitcoin-cli/-tx). #9220
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ppropriate places.
|
Yes, this has to be done at some point. |
|
Concept ACK |
|
ACK 2f2625a Good candidate for same-binary check. |
|
same-binaries ACK 2f2625a |
|
utACK 2f2625a |
maflcko
pushed a commit
that referenced
this pull request
Nov 25, 2016
2f2625a Removed using namespace std from bitcoin-cli/-tx and added std:: in appropriate places. (Karl-Johan Alm)
|
@MarcoFalke I can't find any resources on same-binaries checking. I would like to make a more encompassing commit that deals with all these, but the diff is rather big so I'd like to do the same-binaries check beforehand myself. |
|
@kallewoof Have a look at this repo https://github.com/laanwj/bitcoin-maintainer-tools |
|
Ahh, thanks a lot! |
codablock
pushed a commit
to codablock/dash
that referenced
this pull request
Jan 17, 2018
…tx). 2f2625a Removed using namespace std from bitcoin-cli/-tx and added std:: in appropriate places. (Karl-Johan Alm)
zkbot
added a commit
to zcash/zcash
that referenced
this pull request
Apr 13, 2018
CLI binary improvements Cherry-picked from the following upstream PRs: - bitcoin/bitcoin#5936 - bitcoin/bitcoin#7550 - bitcoin/bitcoin#7989 - bitcoin/bitcoin#7957 - bitcoin/bitcoin#9067 - bitcoin/bitcoin#9220 Excludes any changes that affected the QT code.
andvgal
pushed a commit
to energicryptocurrency/gen2-energi
that referenced
this pull request
Jan 6, 2019
…tx). 2f2625a Removed using namespace std from bitcoin-cli/-tx and added std:: in appropriate places. (Karl-Johan Alm)
CryptoCentric
pushed a commit
to absolute-community/absolute
that referenced
this pull request
Feb 25, 2019
……tx). 2f2625a Removed using namespace std from bitcoin-cli/-tx and added std:: in appropriate places. (Karl-Johan Alm)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to the "Source code organization" section in Developer notes,
using namespaceshould be avoided. This commit removesusing namespace stdfrom bitcoin-cli/-tx and adds thestd::prefix in appropriate places.