Use transactions-updated as flush condition #1010
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The normal checkpointing during the block chain download is reduced to every five minutes only, but forced every 200000 updated transactions.
|
With this patch I did my fastest full block chain load from a local file yet, and did so with never needing more than 120 MiB of log files. After #1007 (which does not appear slower), this still requires 220 MiB. |
|
ACK |
gavinandresen
added a commit
that referenced
this pull request
Mar 29, 2012
Use transactions-updated as flush condition
|
Not sure I see the value of the 200,000 hueristic. |
|
@jgarzik it was chosen after some benchmarks that counted the number of transactions between flushes. Flushing every 200000 transactions causes max 120 MiB log files, which seemed reasonable as long as it did not decrease block sync efficiency. |
|
Just the simple time-based heuristic would seem to suffice for both initial block download and thereafter. maintaining the 200k counter seems rather useless after I.B.D. completion. But no big matter... just a nit, not a NAK :) |
This was referenced Apr 5, 2012
coblee
pushed a commit
to litecoin-project/litecoin
that referenced
this pull request
Jul 17, 2012
Use transactions-updated as flush condition
ghostlander
referenced
this pull request
in ghostlander/Orbitcoin
Dec 10, 2014
A hard fork at block #1010 changing the PoW hashing algorithm (Scrypt to NeoScrypt) and block hashing algorithm (Scrypt to BLAKE2s). Intervals of stake modifiers reduced (3 hours to 40 minutes) with a further intention to decrease the minimal staking age (5 days to 1 day) on the 20-Dec-2014 12:00 GMT. Some minor corrections and improvements.
suprnurd
pushed a commit
to chaincoin-legacy/chaincoin
that referenced
this pull request
Dec 5, 2017
* Remove -DDEBUG_LOCKORDER from debug configuration * Updated documentation to reflect removal of -DDEBUG_LOCKORDER from debug configuration
ptschip
pushed a commit
to ptschip/bitcoin
that referenced
this pull request
Apr 4, 2018
Inlcude CLIENT_VERSION_BUILD in the definition AC package version
Bushstar
pushed a commit
to Bushstar/omnicore
that referenced
this pull request
Oct 14, 2019
d1af4e0 Fix minutes in "rescan ... remaining" message (Pavel Gulchuk) Pull request description: Fix message like ``` Progress: 75.63 % (about 2:121:57 hours remaining) ``` Tree-SHA512: 680f29bc3734eb68aeb71b48d635e5a0c207e3d5a04fdb874cc80f173ab9701dcee19a883a502b90892d49b6de2c796c542dd46b10fbd08072eeaaf698654845
lateminer
pushed a commit
to lateminer/bitcoin
that referenced
this pull request
Oct 30, 2019
c0e325c [Build] settingsconsolewidget moc workaround (Fuzzbawls) 46766be [Build] Remove unnecessary moc_ includes (Fuzzbawls) Pull request description: This aims to resolve the seemingly intermittent "missing moc" issue experienced when building on some systems. ACKs for top commit: CaveSpectre11: Looks good on Ubuntu. ACK PIVX-Project@c0e325c Warrows: ACK c0e325c furszy: ACK [c0e325c](PIVX-Project@c0e325c) Tree-SHA512: f6ed32398a5640fabdc531592a7526ccbf942438a2710e1039d060496ed8a3b0f6bf334cabd3e5082534ed567f077ca7fe180d22a7d525d862413c043f126f74
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The normal checkpointing during the block chain download is reduced
to every five minutes only, but forced every 200000 updated transactions.