Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor fix in build documentation for FreeBSD 11 #10245

Merged
merged 1 commit into from Apr 21, 2017
Merged

Minor fix in build documentation for FreeBSD 11 #10245

merged 1 commit into from Apr 21, 2017

Conversation

shigeya
Copy link
Contributor

@shigeya shigeya commented Apr 20, 2017

  • Don't need libevent2 -- and it's not availble in pkg also
  • Need to use GNU make

@sipa
Copy link
Member

sipa commented Apr 21, 2017

Are you sure nothing is needed to install libevent?

@shigeya
Copy link
Contributor Author

shigeya commented Apr 21, 2017

Yes, I could successfully build without error on FreeBSD 11.0-RELEASE-p9. I briefly tested the code with Testnet3 and looks working (although, I haven't run until getting the latest block).

I decided to shut down the server for now, due to poor CPU resource. If you want more confirmation, I can provide.

@sipa
Copy link
Member

sipa commented Apr 21, 2017

@shigeya I don't doubt that you could build successfully, but wasn't that because somehow libevent was already installed?

@shigeya
Minor fix in build documentation for FreeBSD 11
0611bc3 
- Package name is libevent, not libevent2
- Need to use GNU make
@shigeya
Copy link
Contributor Author

shigeya commented Apr 21, 2017 •
edited

@sipa I was partially wrong. It was named libevent and not libevent2 in pkg. Although I have setup the machine recently and clean, the package was installed part of other package installation already. That's why. I have pushed amended fix. thanks.

@fanquake fanquake added the Docs label Apr 21, 2017
laanwj
laanwj reviewed Apr 21, 2017
View reviewed changes
doc/build-unix.md
@@ -338,7 +340,7 @@ Then build using:

./autogen.sh
./configure --with-incompatible-bdb BDB_CFLAGS="-I/usr/local/include/db5" BDB_LIBS="-L/usr/local/lib -ldb_cxx-5"
make
gmake
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh no, how could I have made this heretic mistake.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know, I know... 😆 It's easy to guess due to the error output of make, but... Anyway, thanks for docs. It was short and easy.

laanwj
laanwj reviewed Apr 21, 2017
View reviewed changes
doc/build-unix.md
@@ -321,8 +321,10 @@ Clang is installed by default as `cc` compiler, this makes it easier to get
started than on [OpenBSD](build-openbsd.md). Installing dependencies:

pkg install autoconf automake libtool pkgconf
pkg install boost-libs openssl libevent2
pkg install boost-libs openssl libevent
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting. I upgraded from an older FreeBSD so my package was still called libevent2. But you're right that it has been renamed.

@laanwj
Copy link
Member

laanwj commented Apr 21, 2017

utACK 0611bc3

@laanwj laanwj merged commit 0611bc3 into bitcoin:master Apr 21, 2017
laanwj added a commit that referenced this pull request Apr 21, 2017
@laanwj
Merge #10245: Minor fix in build documentation for FreeBSD 11
694062e 
0611bc3 Minor fix in build documentation for FreeBSD 11 (Shigeya Suzuki)

Tree-SHA512: d0e0b66868e4a988e1fa121b9c7b2877b77e2b3c7a9d7a6220c9e16cf0d6817786e9020aeba19dfa2cbc07b2fbba12f2afefc442e762a7d00292bde7515ef880
@shigeya shigeya deleted the freebsd-11-build-doc-fix branch April 21, 2017 08:49
@laanwj laanwj mentioned this pull request May 29, 2017
Closed
laanwj pushed a commit that referenced this pull request May 29, 2017
@shigeya @laanwj
Minor fix in build documentation for FreeBSD 11
44a17f2 
- Package name is libevent, not libevent2
- Need to use GNU make

Github-Pull: #10245
Rebased-From: 0611bc3
@laanwj laanwj mentioned this pull request Jun 1, 2017
Closed
nomnombtc pushed a commit to nomnombtc/bitcoin that referenced this pull request Jul 17, 2017
@shigeya @nomnombtc
Minor fix in build documentation for FreeBSD 11
47312bd 
- Package name is libevent, not libevent2
- Need to use GNU make

Github-Pull: bitcoin#10245
Rebased-From: 0611bc3
codablock pushed a commit to codablock/dash that referenced this pull request Jan 26, 2018
@laanwj @codablock
Merge bitcoin#10245: Minor fix in build documentation for FreeBSD 11
69058b8 
0611bc3 Minor fix in build documentation for FreeBSD 11 (Shigeya Suzuki)

Tree-SHA512: d0e0b66868e4a988e1fa121b9c7b2877b77e2b3c7a9d7a6220c9e16cf0d6817786e9020aeba19dfa2cbc07b2fbba12f2afefc442e762a7d00292bde7515ef880
michelvankessel added a commit to michelvankessel/blackcoin-more that referenced this pull request Jan 5, 2019
@michelvankessel
Minor fix in build documentation for FreeBSD 11 bitcoin#10245
9d2ec54 
bitcoin#10245
andvgal pushed a commit to energicryptocurrency/gen2-energi that referenced this pull request Jan 6, 2019
@laanwj @andvgal
Merge bitcoin#10245: Minor fix in build documentation for FreeBSD 11
57916a0 
0611bc3 Minor fix in build documentation for FreeBSD 11 (Shigeya Suzuki)

Tree-SHA512: d0e0b66868e4a988e1fa121b9c7b2877b77e2b3c7a9d7a6220c9e16cf0d6817786e9020aeba19dfa2cbc07b2fbba12f2afefc442e762a7d00292bde7515ef880
CryptoCentric pushed a commit to absolute-community/absolute that referenced this pull request Feb 27, 2019
@laanwj @CryptoCentric
Merge bitcoin#10245: Minor fix in build documentation for FreeBSD 11
c9ff1fc 
0611bc3 Minor fix in build documentation for FreeBSD 11 (Shigeya Suzuki)

Tree-SHA512: d0e0b66868e4a988e1fa121b9c7b2877b77e2b3c7a9d7a6220c9e16cf0d6817786e9020aeba19dfa2cbc07b2fbba12f2afefc442e762a7d00292bde7515ef880
PastaPastaPasta pushed a commit to PastaPastaPasta/dash that referenced this pull request May 31, 2019
@laanwj @PastaPastaPasta
Merge bitcoin#10245: Minor fix in build documentation for FreeBSD 11
8e91ae0 
0611bc3 Minor fix in build documentation for FreeBSD 11 (Shigeya Suzuki)

Tree-SHA512: d0e0b66868e4a988e1fa121b9c7b2877b77e2b3c7a9d7a6220c9e16cf0d6817786e9020aeba19dfa2cbc07b2fbba12f2afefc442e762a7d00292bde7515ef880
PastaPastaPasta pushed a commit to PastaPastaPasta/dash that referenced this pull request Jun 10, 2019
@laanwj @PastaPastaPasta
Merge bitcoin#10245: Minor fix in build documentation for FreeBSD 11
ead74f4 
0611bc3 Minor fix in build documentation for FreeBSD 11 (Shigeya Suzuki)

Tree-SHA512: d0e0b66868e4a988e1fa121b9c7b2877b77e2b3c7a9d7a6220c9e16cf0d6817786e9020aeba19dfa2cbc07b2fbba12f2afefc442e762a7d00292bde7515ef880
PastaPastaPasta pushed a commit to PastaPastaPasta/dash that referenced this pull request Jun 10, 2019
@laanwj @PastaPastaPasta
Merge bitcoin#10245: Minor fix in build documentation for FreeBSD 11
055dab3 
0611bc3 Minor fix in build documentation for FreeBSD 11 (Shigeya Suzuki)

Tree-SHA512: d0e0b66868e4a988e1fa121b9c7b2877b77e2b3c7a9d7a6220c9e16cf0d6817786e9020aeba19dfa2cbc07b2fbba12f2afefc442e762a7d00292bde7515ef880
PastaPastaPasta pushed a commit to PastaPastaPasta/dash that referenced this pull request Jun 11, 2019
@laanwj @PastaPastaPasta
Merge bitcoin#10245: Minor fix in build documentation for FreeBSD 11
7a15060 
0611bc3 Minor fix in build documentation for FreeBSD 11 (Shigeya Suzuki)

Tree-SHA512: d0e0b66868e4a988e1fa121b9c7b2877b77e2b3c7a9d7a6220c9e16cf0d6817786e9020aeba19dfa2cbc07b2fbba12f2afefc442e762a7d00292bde7515ef880
PastaPastaPasta pushed a commit to PastaPastaPasta/dash that referenced this pull request Jun 11, 2019
@laanwj @PastaPastaPasta
Merge bitcoin#10245: Minor fix in build documentation for FreeBSD 11
f32e2d7 
0611bc3 Minor fix in build documentation for FreeBSD 11 (Shigeya Suzuki)

Tree-SHA512: d0e0b66868e4a988e1fa121b9c7b2877b77e2b3c7a9d7a6220c9e16cf0d6817786e9020aeba19dfa2cbc07b2fbba12f2afefc442e762a7d00292bde7515ef880
PastaPastaPasta pushed a commit to PastaPastaPasta/dash that referenced this pull request Jun 12, 2019
@laanwj @PastaPastaPasta
Merge bitcoin#10245: Minor fix in build documentation for FreeBSD 11
2a32adc 
0611bc3 Minor fix in build documentation for FreeBSD 11 (Shigeya Suzuki)

Tree-SHA512: d0e0b66868e4a988e1fa121b9c7b2877b77e2b3c7a9d7a6220c9e16cf0d6817786e9020aeba19dfa2cbc07b2fbba12f2afefc442e762a7d00292bde7515ef880
@PastaPastaPasta PastaPastaPasta mentioned this pull request Jun 14, 2019
Merged
PastaPastaPasta pushed a commit to PastaPastaPasta/dash that referenced this pull request Jun 15, 2019
@laanwj @PastaPastaPasta
Merge bitcoin#10245: Minor fix in build documentation for FreeBSD 11
716b5a4 
0611bc3 Minor fix in build documentation for FreeBSD 11 (Shigeya Suzuki)

Tree-SHA512: d0e0b66868e4a988e1fa121b9c7b2877b77e2b3c7a9d7a6220c9e16cf0d6817786e9020aeba19dfa2cbc07b2fbba12f2afefc442e762a7d00292bde7515ef880
PastaPastaPasta pushed a commit to PastaPastaPasta/dash that referenced this pull request Jun 19, 2019
@laanwj @PastaPastaPasta
Merge bitcoin#10245: Minor fix in build documentation for FreeBSD 11
15ac31b 
0611bc3 Minor fix in build documentation for FreeBSD 11 (Shigeya Suzuki)

Tree-SHA512: d0e0b66868e4a988e1fa121b9c7b2877b77e2b3c7a9d7a6220c9e16cf0d6817786e9020aeba19dfa2cbc07b2fbba12f2afefc442e762a7d00292bde7515ef880
PastaPastaPasta pushed a commit to PastaPastaPasta/dash that referenced this pull request Jun 19, 2019
@laanwj @PastaPastaPasta
Merge bitcoin#10245: Minor fix in build documentation for FreeBSD 11
bb9507f 
0611bc3 Minor fix in build documentation for FreeBSD 11 (Shigeya Suzuki)

Tree-SHA512: d0e0b66868e4a988e1fa121b9c7b2877b77e2b3c7a9d7a6220c9e16cf0d6817786e9020aeba19dfa2cbc07b2fbba12f2afefc442e762a7d00292bde7515ef880
PastaPastaPasta pushed a commit to PastaPastaPasta/dash that referenced this pull request Jun 19, 2019
@laanwj @PastaPastaPasta
Merge bitcoin#10245: Minor fix in build documentation for FreeBSD 11
d8adcab 
0611bc3 Minor fix in build documentation for FreeBSD 11 (Shigeya Suzuki)

Tree-SHA512: d0e0b66868e4a988e1fa121b9c7b2877b77e2b3c7a9d7a6220c9e16cf0d6817786e9020aeba19dfa2cbc07b2fbba12f2afefc442e762a7d00292bde7515ef880
@bitcoin bitcoin locked as resolved and limited conversation to collaborators Sep 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@laanwj laanwj laanwj left review comments

Assignees
No one assigned
Labels
Docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@shigeya @sipa @laanwj @fanquake