[bench] Include ms/blk stats in Connect* benchmarks. #10303

kallewoof · 2017-05-01T04:57:09Z

Display the average per block runtime for the various benchmarked times in the block connect functions to give an overview of long(er) term time distribution statistics.

sipa · 2017-05-01T22:43:49Z

Concept ACK

kallewoof · 2017-05-02T01:01:55Z

After some days of running, this is what it looks like:

2017-05-02 00:50:09 - Connect block: 69.00ms [61.34s (107.42ms/blk)]
2017-05-02 00:54:03   - Load block from disk: 0.00ms [0.03s]
2017-05-02 00:54:03     - Sanity checks: 0.00ms [0.00s (0.01ms/blk)]
2017-05-02 00:54:03     - Fork checks: 0.03ms [0.02s (0.03ms/blk)]
2017-05-02 00:54:03       - Connect 1942 transactions: 30.89ms (0.016ms/tx, 0.008ms/txin) [35.05s (61.28ms/blk)]
2017-05-02 00:54:03     - Verify 3960 txins: 48.62ms (0.012ms/txin) [45.90s (80.25ms/blk)]
2017-05-02 00:54:03     - Index writing: 2.74ms [1.71s (3.00ms/blk)]
2017-05-02 00:54:03     - Callbacks: 0.02ms [0.01s (0.02ms/blk)]
2017-05-02 00:54:03   - Connect total: 51.58ms [47.76s (83.49ms/blk)]
2017-05-02 00:54:03   - Flush: 5.78ms [3.19s (5.58ms/blk)]
2017-05-02 00:54:03   - Writing chainstate: 0.03ms [0.05s (0.10ms/blk)]
2017-05-02 00:54:03 UpdateTip: new best=000000000000000001f02798776e208f8de551a0a5ddab0b6ed4b44665a04140 height=464424 version=0x30000000 log2_work=86.366385 tx=218199087 date='2017-05-02 00:53:59' progress=1.000000 cache=190.9MiB(156242tx) warning='1 of last 100 blocks have unexpected version'
2017-05-02 00:54:03   - Connect postprocess: 15.89ms [10.38s (18.15ms/blk)]
2017-05-02 00:54:03 - Connect block: 73.27ms [61.41s (107.36ms/blk)]

jonasschnelli · 2017-05-02T06:50:45Z

utACK 1d0cdc07c4db1e0d0df7a55696543165506de09f

paveljanik · 2017-05-04T07:31:19Z

utACK 1d0cdc0

jtimon · 2017-05-31T16:54:59Z

src/validation.cpp

@@ -1739,7 +1742,7 @@ static bool ConnectBlock(const CBlock& block, CValidationState& state, CBlockInd
    }

    int64_t nTime1 = GetTimeMicros(); nTimeCheck += nTime1 - nTimeStart;
-    LogPrint(BCLog::BENCH, "    - Sanity checks: %.2fms [%.2fs]\n", 0.001 * (nTime1 - nTimeStart), nTimeCheck * 0.000001);
+    LogPrint(BCLog::BENCH, "    - Sanity checks: %.2fms [%.2fs (%.2fms/blk)]\n", 0.001 * (nTime1 - nTimeStart), nTimeCheck * 0.000001, nTimeCheck * 0.001 / nBlocksTotal);


Perhaps 0.001 can be a constant? maybe 0.000001 too ?

Makes sense, I think.

a473eff [bench] Replace 0.00(000)1 with MICRO/MILLI #defines in validation.cpp. (Karl-Johan Alm) 5f850b0 [bench] Include ms/blk stats in Connect* benchmarks. (Karl-Johan Alm) Pull request description: Display the average per block runtime for the various benchmarked times in the block connect functions to give an overview of long(er) term time distribution statistics. Tree-SHA512: 3d6f24f6b9e3dbb448a647e2cda8e7b90ad6a16d4821f49f426a8e1ebc3ce5a0cf0a8cde82213e293affba441615702dfe50822c8c818e282af03bfe383d83e0

…rks. a473eff [bench] Replace 0.00(000)1 with MICRO/MILLI #defines in validation.cpp. (Karl-Johan Alm) 5f850b0 [bench] Include ms/blk stats in Connect* benchmarks. (Karl-Johan Alm) Pull request description: Display the average per block runtime for the various benchmarked times in the block connect functions to give an overview of long(er) term time distribution statistics. Tree-SHA512: 3d6f24f6b9e3dbb448a647e2cda8e7b90ad6a16d4821f49f426a8e1ebc3ce5a0cf0a8cde82213e293affba441615702dfe50822c8c818e282af03bfe383d83e0

…rks. a473eff [bench] Replace 0.00(000)1 with MICRO/MILLI #defines in validation.cpp. (Karl-Johan Alm) 5f850b0 [bench] Include ms/blk stats in Connect* benchmarks. (Karl-Johan Alm) Pull request description: Display the average per block runtime for the various benchmarked times in the block connect functions to give an overview of long(er) term time distribution statistics. Tree-SHA512: 3d6f24f6b9e3dbb448a647e2cda8e7b90ad6a16d4821f49f426a8e1ebc3ce5a0cf0a8cde82213e293affba441615702dfe50822c8c818e282af03bfe383d83e0 More of 10303

fanquake added the Tests label May 1, 2017

maflcko added the Docs label May 1, 2017

jtimon reviewed May 31, 2017

View reviewed changes

kallewoof added 2 commits June 1, 2017 11:43

[bench] Include ms/blk stats in Connect* benchmarks.

5f850b0

[bench] Replace 0.00(000)1 with MICRO/MILLI #defines in validation.cpp.

a473eff

kallewoof force-pushed the bench-add-per-block-stats branch from 1d0cdc0 to a473eff Compare June 1, 2017 02:43

laanwj merged commit a473eff into bitcoin:master Aug 28, 2017

kallewoof deleted the bench-add-per-block-stats branch October 17, 2019 08:43

PastaPastaPasta mentioned this pull request Jan 10, 2020

Backports 0.16 pr2 dashpay/dash#3276

Merged

bitcoin locked as resolved and limited conversation to collaborators Dec 16, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[bench] Include ms/blk stats in Connect* benchmarks. #10303

[bench] Include ms/blk stats in Connect* benchmarks. #10303

kallewoof commented May 1, 2017

sipa commented May 1, 2017

kallewoof commented May 2, 2017

jonasschnelli commented May 2, 2017

paveljanik commented May 4, 2017

jtimon May 31, 2017

kallewoof Jun 1, 2017

[bench] Include ms/blk stats in Connect* benchmarks. #10303

[bench] Include ms/blk stats in Connect* benchmarks. #10303

Conversation

kallewoof commented May 1, 2017

sipa commented May 1, 2017

kallewoof commented May 2, 2017

jonasschnelli commented May 2, 2017

paveljanik commented May 4, 2017

jtimon May 31, 2017

Choose a reason for hiding this comment

kallewoof Jun 1, 2017

Choose a reason for hiding this comment