Overhaul Qt fee bumper

[jonasschnelli]

This fixes two minor issue:

• Right now, the context menu "Increase transaction fee" is also enabled for transactions that already have been bumped (fixed in this PR)
• After bumping a transaction, the original transaction doesn't get properly visually updated (fixed in this PR)

[ryanofsky]

Tested ACK 6d7104c. Confirmed menu option is disabled for bumped transactions, and that bumping a transaction now makes it gray and puts the amount in brackets.

[TheBlueMatt]

I thought we were gonna go with not displaying the replaced_by_txid transactions ala TransactionRecord::showTransaction?

[laanwj]

These are strictly improvements, utACK 6d7104c.
Agree that hiding the transactions might also be a good idea, but you're the one implementing it (as I remember, hiding transactions is more difficult to get right). Further ideas could always be done later.

[jtimon]

This seems to have broken qt/test/test_bitcoin-qt:

==============================================
   Bitcoin Core 0.14.99: src/test-suite.log
==============================================

# TOTAL: 2
# PASS:  1
# SKIP:  0
# XFAIL: 0
# FAIL:  1
# XPASS: 0
# ERROR: 0

.. contents:: :depth: 2

FAIL: qt/test/test_bitcoin-qt
=============================

********* Start testing of URITests *********
Config: Using QtTest library 5.5.1, Qt 5.5.1 (x86_64-little_endian-lp64 shared (dynamic) release build; by GCC 5.3.1 20160413)
PASS   : URITests::initTestCase()
PASS   : URITests::uriTests()
PASS   : URITests::cleanupTestCase()
Totals: 3 passed, 0 failed, 0 skipped, 0 blacklisted
********* Finished testing of URITests *********
********* Start testing of PaymentServerTests *********
Config: Using QtTest library 5.5.1, Qt 5.5.1 (x86_64-little_endian-lp64 shared (dynamic) release build; by GCC 5.3.1 20160413)
PASS   : PaymentServerTests::initTestCase()
QDEBUG : PaymentServerTests::paymentServerTests() PaymentServer::initNetManager: No active proxy server found.
QDEBUG : PaymentServerTests::paymentServerTests() PaymentServer::processPaymentRequest: Secure payment request from  "testmerchant.org"
QWARN  : PaymentServerTests::paymentServerTests() PaymentRequestPlus::getMerchant: Payment request: certificate expired or not yet active:  QSslCertificate("3", "03", "LxHILx+N3qwVoAcCmQ5cyw==", (), ("Expired Test Merchant"), QMap(), QDateTime(2013-02-23 21:26:43.000 UTC Qt::TimeSpec(UTC)), QDateTime(2013-02-24 21:26:43.000 UTC Qt::TimeSpec(UTC)))
QDEBUG : PaymentServerTests::paymentServerTests() PaymentServer::processPaymentRequest: Insecure payment request to  "1EcqLEpyu3zY7T5QU7RLrHEQH134KeGPXR"
QWARN  : PaymentServerTests::paymentServerTests() PaymentRequestPlus::getMerchant: Payment request: certificate expired or not yet active:  QSslCertificate("3", "03", "LxHILx+N3qwVoAcCmQ5cyw==", (), ("Expired Test Merchant"), QMap(), QDateTime(2013-02-23 21:26:43.000 UTC Qt::TimeSpec(UTC)), QDateTime(2013-02-24 21:26:43.000 UTC Qt::TimeSpec(UTC)))
QDEBUG : PaymentServerTests::paymentServerTests() PaymentServer::processPaymentRequest: Secure payment request from  "testmerchant8.org"
QWARN  : PaymentServerTests::paymentServerTests() PaymentRequestPlus::getMerchant: Payment request: certificate expired or not yet active:  QSslCertificate("3", "06", "MiZaQ+g9lSHZGuHWkXZG+g==", (), ("Payment Request Intermediate 5"), QMap(), QDateTime(2013-02-23 22:59:51.000 UTC Qt::TimeSpec(UTC)), QDateTime(2013-02-24 22:59:51.000 UTC Qt::TimeSpec(UTC)))
QDEBUG : PaymentServerTests::paymentServerTests() PaymentServer::processPaymentRequest: Insecure payment request to  "1EcqLEpyu3zY7T5QU7RLrHEQH134KeGPXR"
QWARN  : PaymentServerTests::paymentServerTests() PaymentRequestPlus::getMerchant: Payment request: certificate expired or not yet active:  QSslCertificate("3", "06", "MiZaQ+g9lSHZGuHWkXZG+g==", (), ("Payment Request Intermediate 5"), QMap(), QDateTime(2013-02-23 22:59:51.000 UTC Qt::TimeSpec(UTC)), QDateTime(2013-02-24 22:59:51.000 UTC Qt::TimeSpec(UTC)))
QWARN  : PaymentServerTests::paymentServerTests() PaymentRequestPlus::getMerchant: SSL error:  certificate signature failure
QDEBUG : PaymentServerTests::paymentServerTests() PaymentServer::processPaymentRequest: Insecure payment request to  "1EcqLEpyu3zY7T5QU7RLrHEQH134KeGPXR"
QWARN  : PaymentServerTests::paymentServerTests() PaymentRequestPlus::getMerchant: SSL error:  certificate signature failure
QWARN  : PaymentServerTests::paymentServerTests() PaymentRequestPlus::getMerchant: SSL error:  unable to get local issuer certificate
QDEBUG : PaymentServerTests::paymentServerTests() PaymentServer::processPaymentRequest: Insecure payment request to  "1EcqLEpyu3zY7T5QU7RLrHEQH134KeGPXR"
QWARN  : PaymentServerTests::paymentServerTests() PaymentRequestPlus::getMerchant: SSL error:  unable to get local issuer certificate
QWARN  : PaymentServerTests::paymentServerTests() "PaymentServer::verifyNetwork: Payment request network \"test\" doesn't match client network \"main\"."
QWARN  : PaymentServerTests::paymentServerTests() "PaymentServer::verifyExpired: Payment request expired \"1970-01-01 00:00:01\"."
QWARN  : PaymentServerTests::paymentServerTests() "PaymentServer::verifyExpired: Payment request expired \"1970-01-01 00:00:00\"."
QWARN  : PaymentServerTests::paymentServerTests() "PaymentServer::verifySize: Payment request too large (50001 bytes, allowed 50000 bytes)."
QWARN  : PaymentServerTests::paymentServerTests() "PaymentServer::verifyAmount: Payment request amount out of allowed range (2100000100000000, allowed 0 - 2100000000000000)."
PASS   : PaymentServerTests::paymentServerTests()
PASS   : PaymentServerTests::cleanupTestCase()
Totals: 3 passed, 0 failed, 0 skipped, 0 blacklisted
********* Finished testing of PaymentServerTests *********
********* Start testing of RPCNestedTests *********
Config: Using QtTest library 5.5.1, Qt 5.5.1 (x86_64-little_endian-lp64 shared (dynamic) release build; by GCC 5.3.1 20160413)
PASS   : RPCNestedTests::initTestCase()
PASS   : RPCNestedTests::rpcNestedTests()
PASS   : RPCNestedTests::cleanupTestCase()
Totals: 3 passed, 0 failed, 0 skipped, 0 blacklisted
********* Finished testing of RPCNestedTests *********
********* Start testing of CompatTests *********
Config: Using QtTest library 5.5.1, Qt 5.5.1 (x86_64-little_endian-lp64 shared (dynamic) release build; by GCC 5.3.1 20160413)
PASS   : CompatTests::initTestCase()
PASS   : CompatTests::bswapTests()
PASS   : CompatTests::cleanupTestCase()
Totals: 3 passed, 0 failed, 0 skipped, 0 blacklisted
********* Finished testing of CompatTests *********
********* Start testing of WalletTests *********
Config: Using QtTest library 5.5.1, Qt 5.5.1 (x86_64-little_endian-lp64 shared (dynamic) release build; by GCC 5.3.1 20160413)
PASS   : WalletTests::initTestCase()
QDEBUG : WalletTests::walletTests() TransactionTablePriv::refreshWallet
QWARN  : WalletTests::walletTests() This plugin does not support propagateSizeHints()
QDEBUG : WalletTests::walletTests() "NotifyTransactionChanged: 6ebadef409a5733dffa9dfd693740f752a1df5e0330962b40cb8c93a67d11f29 status= 0"
QDEBUG : WalletTests::walletTests() "NotifyTransactionChanged: 8bb447619a7bd0be53f46491584cf906564ab576082d3bc97cf321f436b8aa5e status= 1"
QDEBUG : WalletTests::walletTests() "NotifyAddressBookChanged: mfWxJ45yp2SFn7UciZyNpvDKrzbhyfKrY8  isMine=0 purpose=send status=0"
QDEBUG : WalletTests::walletTests() "TransactionTablePriv::updateWallet: 6ebadef409a5733dffa9dfd693740f752a1df5e0330962b40cb8c93a67d11f29 0"
QDEBUG : WalletTests::walletTests() "    inModel=0 Index=13-13 showTransaction=1 derivedStatus=0"
QDEBUG : WalletTests::walletTests() "TransactionTablePriv::updateWallet: 8bb447619a7bd0be53f46491584cf906564ab576082d3bc97cf321f436b8aa5e 1"
QDEBUG : WalletTests::walletTests() "    inModel=1 Index=35-36 showTransaction=1 derivedStatus=1"
QWARN  : WalletTests::walletTests() This plugin does not support propagateSizeHints()
QDEBUG : WalletTests::walletTests() "NotifyTransactionChanged: 92b5e72a4c3be337996d705b3d65ff1d91d25c4fe0afc7e79a1b2879dc54b383 status= 0"
QDEBUG : WalletTests::walletTests() "NotifyTransactionChanged: 97b70d1ea6e61f65b42b52c0859581067536929ef4e97efbd2d6039cb92a59c0 status= 1"
QDEBUG : WalletTests::walletTests() "TransactionTablePriv::updateWallet: 92b5e72a4c3be337996d705b3d65ff1d91d25c4fe0afc7e79a1b2879dc54b383 0"
QDEBUG : WalletTests::walletTests() "    inModel=0 Index=53-53 showTransaction=1 derivedStatus=0"
QDEBUG : WalletTests::walletTests() "TransactionTablePriv::updateWallet: 97b70d1ea6e61f65b42b52c0859581067536929ef4e97efbd2d6039cb92a59c0 1"
QDEBUG : WalletTests::walletTests() "    inModel=1 Index=82-83 showTransaction=1 derivedStatus=1"
QWARN  : WalletTests::walletTests() This plugin does not support raise()
QWARN  : WalletTests::walletTests() This plugin does not support grabbing the keyboard
QWARN  : WalletTests::walletTests() This plugin does not support propagateSizeHints()
QWARN  : WalletTests::walletTests() This plugin does not support raise()
QWARN  : WalletTests::walletTests() This plugin does not support grabbing the keyboard
QWARN  : WalletTests::walletTests() This plugin does not support propagateSizeHints()
QWARN  : WalletTests::walletTests() This plugin does not support raise()
QWARN  : WalletTests::walletTests() This plugin does not support grabbing the keyboard
QWARN  : WalletTests::walletTests() This plugin does not support propagateSizeHints()
QDEBUG : WalletTests::walletTests() "NotifyTransactionChanged: 1a9b91b3b7497a87a089fb1744bac71520e329b4082aafac87b2436fc44fa846 status= 0"
QDEBUG : WalletTests::walletTests() "NotifyTransactionChanged: 97b70d1ea6e61f65b42b52c0859581067536929ef4e97efbd2d6039cb92a59c0 status= 1"
QDEBUG : WalletTests::walletTests() "NotifyTransactionChanged: 92b5e72a4c3be337996d705b3d65ff1d91d25c4fe0afc7e79a1b2879dc54b383 status= 1"
QDEBUG : WalletTests::walletTests() "TransactionTablePriv::updateWallet: 92b5e72a4c3be337996d705b3d65ff1d91d25c4fe0afc7e79a1b2879dc54b383 1"
QDEBUG : WalletTests::walletTests() "    inModel=1 Index=53-54 showTransaction=1 derivedStatus=1"
QWARN  : WalletTests::walletTests() This plugin does not support raise()
QWARN  : WalletTests::walletTests() This plugin does not support grabbing the keyboard
FAIL!  : WalletTests::walletTests() Compared values are not the same
   Actual   (action->isEnabled()): 0
   Expected (!expectDisabled)    : 1
   Loc: [qt/test/wallettests.cpp(117)]
PASS   : WalletTests::cleanupTestCase()
Totals: 2 passed, 1 failed, 0 skipped, 0 blacklisted
********* Finished testing of WalletTests *********
FAIL qt/test/test_bitcoin-qt (exit status: 1)