New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve bitcoind systemd service file #10529
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,22 +1,25 @@ | ||
| # It is not recommended to modify this file in-place, because it will | ||
| # be overwritten during package upgrades. If you want to add further | ||
| # options or overwrite existing ones then use | ||
| # $ systemctl edit bitcoind.service | ||
| # See "man systemd.service" for details. | ||
|
|
||
| # Note that almost all daemon options could be specified in | ||
| # /etc/bitcoin/bitcoin.conf | ||
|
|
||
| [Unit] | ||
| Description=Bitcoin's distributed currency daemon | ||
| Description=Bitcoin daemon | ||
| After=network.target | ||
|
|
||
| [Service] | ||
| ExecStart=/usr/bin/bitcoind -daemon -conf=/etc/bitcoin/bitcoin.conf -pid=/run/bitcoind/bitcoind.pid | ||
| # Creates /run/bitcoind owned by bitcoin | ||
| RuntimeDirectory=bitcoind | ||
| User=bitcoin | ||
| Group=bitcoin | ||
|
|
||
| Type=forking | ||
| PIDFile=/var/lib/bitcoind/bitcoind.pid | ||
| ExecStart=/usr/bin/bitcoind -daemon -pid=/var/lib/bitcoind/bitcoind.pid \ | ||
| -conf=/etc/bitcoin/bitcoin.conf -datadir=/var/lib/bitcoind -disablewallet | ||
|
|
||
| Restart=always | ||
| PIDFile=/run/bitcoind/bitcoind.pid | ||
| Restart=on-failure | ||
| PrivateTmp=true | ||
| TimeoutStopSec=60s | ||
| TimeoutStartSec=2s | ||
| StartLimitInterval=120s | ||
| StartLimitBurst=5 | ||
|
|
||
| [Install] | ||
| WantedBy=multi-user.target | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably should use
/etc/bitcoindto be consistent with/run/bitcoindor/run/bitcointo be consistent with/etc/bitcoinThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've no strong feelings towards any of those options, besides that keeping
/etc/bitcoin/would make it a bit easier for the gentoo ebuilds, as that is what they currently use.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah actually I take back the suggestion. Seems fine to stick with /etc/bitcoin since the config there could potentially could be shared with different bitcoin tools. And /var/bitcoind at least keeps consistency with the binary and service names.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, at least hypothetically,
bitcoin-cliwould ideally be able to use it too.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If I'm setting up systemd do I need to create the bitcoin user and group myself?