Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace deprecated throw() with noexcept specifier (C++11) #10965

Merged
merged 1 commit into from Aug 16, 2017
Merged

Replace deprecated throw() with noexcept specifier (C++11) #10965

merged 1 commit into from Aug 16, 2017

Conversation

practicalswift
Copy link
Contributor

@practicalswift practicalswift commented Jul 31, 2017 •
edited

Use the noexcept specifier (C++11) instead of deprecated throw().

@laanwj
Copy link
Member

laanwj commented Aug 1, 2017

utACK 9862550

@jonasschnelli
Copy link
Contributor

utACK 9862550

@TheBlueMatt
Copy link
Contributor

utACK

@promag
Copy link
Member

promag commented Aug 6, 2017 •
edited

ACK 9862550.

Edit: nit reword Replace deprecated throw() with C++11 noexcept operator :)

@practicalswift practicalswift changed the title Use the noexcept specifier (C++11) instead of deprecated throw() Replace deprecated throw() with noexcept operator (C++11) Aug 6, 2017
@practicalswift practicalswift changed the title Replace deprecated throw() with noexcept operator (C++11) Replace deprecated throw() with noexcept specifier (C++11) Aug 6, 2017
@practicalswift
Copy link
Contributor Author

@promag But here I'm using the noexcept specifier and not the noexcept operator :-)

@fanquake
Copy link
Member

utACK 9862550

@maflcko maflcko merged commit 9862550 into bitcoin:master Aug 16, 2017
maflcko pushed a commit that referenced this pull request Aug 16, 2017
Merge #10965: Replace deprecated throw() with noexcept specifier (C++11)
655970d 
9862550 Use the noexcept specifier (C++11) instead of deprecated throw() (practicalswift)

Pull request description:

  Use the `noexcept` specifier (C++11) instead of deprecated `throw()`.

Tree-SHA512: cf9b6b18f61f2f59bbeceb2e43b5cd07a60f5e569c8def05c410cb72326d597c80cb731059969ef89fa5fddaae1242225886e6109fcb535c4ad62d56ebcdf1ea
PastaPastaPasta pushed a commit to PastaPastaPasta/dash that referenced this pull request Sep 19, 2019
@PastaPastaPasta
Merge bitcoin#10965: Replace deprecated throw() with noexcept specifi…
e59b744 
…er (C++11)

9862550 Use the noexcept specifier (C++11) instead of deprecated throw() (practicalswift)

Pull request description:

  Use the `noexcept` specifier (C++11) instead of deprecated `throw()`.

Tree-SHA512: cf9b6b18f61f2f59bbeceb2e43b5cd07a60f5e569c8def05c410cb72326d597c80cb731059969ef89fa5fddaae1242225886e6109fcb535c4ad62d56ebcdf1ea
PastaPastaPasta pushed a commit to PastaPastaPasta/dash that referenced this pull request Sep 23, 2019
@PastaPastaPasta
Merge bitcoin#10965: Replace deprecated throw() with noexcept specifi…
aed1507 
…er (C++11)

9862550 Use the noexcept specifier (C++11) instead of deprecated throw() (practicalswift)

Pull request description:

  Use the `noexcept` specifier (C++11) instead of deprecated `throw()`.

Tree-SHA512: cf9b6b18f61f2f59bbeceb2e43b5cd07a60f5e569c8def05c410cb72326d597c80cb731059969ef89fa5fddaae1242225886e6109fcb535c4ad62d56ebcdf1ea
PastaPastaPasta pushed a commit to PastaPastaPasta/dash that referenced this pull request Sep 24, 2019
@PastaPastaPasta
Merge bitcoin#10965: Replace deprecated throw() with noexcept specifi…
3716562 
…er (C++11)

9862550 Use the noexcept specifier (C++11) instead of deprecated throw() (practicalswift)

Pull request description:

  Use the `noexcept` specifier (C++11) instead of deprecated `throw()`.

Tree-SHA512: cf9b6b18f61f2f59bbeceb2e43b5cd07a60f5e569c8def05c410cb72326d597c80cb731059969ef89fa5fddaae1242225886e6109fcb535c4ad62d56ebcdf1ea
PastaPastaPasta pushed a commit to PastaPastaPasta/dash that referenced this pull request Nov 19, 2019
@PastaPastaPasta
Merge bitcoin#10965: Replace deprecated throw() with noexcept specifi…
90e9c75 
…er (C++11)

9862550 Use the noexcept specifier (C++11) instead of deprecated throw() (practicalswift)

Pull request description:

  Use the `noexcept` specifier (C++11) instead of deprecated `throw()`.

Tree-SHA512: cf9b6b18f61f2f59bbeceb2e43b5cd07a60f5e569c8def05c410cb72326d597c80cb731059969ef89fa5fddaae1242225886e6109fcb535c4ad62d56ebcdf1ea
PastaPastaPasta pushed a commit to PastaPastaPasta/dash that referenced this pull request Nov 21, 2019
@PastaPastaPasta
Merge bitcoin#10965: Replace deprecated throw() with noexcept specifi…
7575d4d 
…er (C++11)

9862550 Use the noexcept specifier (C++11) instead of deprecated throw() (practicalswift)

Pull request description:

  Use the `noexcept` specifier (C++11) instead of deprecated `throw()`.

Tree-SHA512: cf9b6b18f61f2f59bbeceb2e43b5cd07a60f5e569c8def05c410cb72326d597c80cb731059969ef89fa5fddaae1242225886e6109fcb535c4ad62d56ebcdf1ea
PastaPastaPasta pushed a commit to PastaPastaPasta/dash that referenced this pull request Dec 9, 2019
@PastaPastaPasta
Merge bitcoin#10965: Replace deprecated throw() with noexcept specifi…
abd23bd 
…er (C++11)

9862550 Use the noexcept specifier (C++11) instead of deprecated throw() (practicalswift)

Pull request description:

  Use the `noexcept` specifier (C++11) instead of deprecated `throw()`.

Tree-SHA512: cf9b6b18f61f2f59bbeceb2e43b5cd07a60f5e569c8def05c410cb72326d597c80cb731059969ef89fa5fddaae1242225886e6109fcb535c4ad62d56ebcdf1ea
PastaPastaPasta pushed a commit to PastaPastaPasta/dash that referenced this pull request Jan 1, 2020
@PastaPastaPasta
Merge bitcoin#10965: Replace deprecated throw() with noexcept specifi…
7a3b419 
…er (C++11)

9862550 Use the noexcept specifier (C++11) instead of deprecated throw() (practicalswift)

Pull request description:

  Use the `noexcept` specifier (C++11) instead of deprecated `throw()`.

Tree-SHA512: cf9b6b18f61f2f59bbeceb2e43b5cd07a60f5e569c8def05c410cb72326d597c80cb731059969ef89fa5fddaae1242225886e6109fcb535c4ad62d56ebcdf1ea
PastaPastaPasta pushed a commit to PastaPastaPasta/dash that referenced this pull request Jan 2, 2020
@PastaPastaPasta
Merge bitcoin#10965: Replace deprecated throw() with noexcept specifi…
9751749 
…er (C++11)

9862550 Use the noexcept specifier (C++11) instead of deprecated throw() (practicalswift)

Pull request description:

  Use the `noexcept` specifier (C++11) instead of deprecated `throw()`.

Tree-SHA512: cf9b6b18f61f2f59bbeceb2e43b5cd07a60f5e569c8def05c410cb72326d597c80cb731059969ef89fa5fddaae1242225886e6109fcb535c4ad62d56ebcdf1ea
PastaPastaPasta pushed a commit to PastaPastaPasta/dash that referenced this pull request Jan 2, 2020
@PastaPastaPasta
Merge bitcoin#10965: Replace deprecated throw() with noexcept specifi…
f1683e8 
…er (C++11)

9862550 Use the noexcept specifier (C++11) instead of deprecated throw() (practicalswift)

Pull request description:

  Use the `noexcept` specifier (C++11) instead of deprecated `throw()`.

Tree-SHA512: cf9b6b18f61f2f59bbeceb2e43b5cd07a60f5e569c8def05c410cb72326d597c80cb731059969ef89fa5fddaae1242225886e6109fcb535c4ad62d56ebcdf1ea
PastaPastaPasta pushed a commit to PastaPastaPasta/dash that referenced this pull request Jan 2, 2020
@PastaPastaPasta
Merge bitcoin#10965: Replace deprecated throw() with noexcept specifi…
fcc1b3b 
…er (C++11)

9862550 Use the noexcept specifier (C++11) instead of deprecated throw() (practicalswift)

Pull request description:

  Use the `noexcept` specifier (C++11) instead of deprecated `throw()`.

Tree-SHA512: cf9b6b18f61f2f59bbeceb2e43b5cd07a60f5e569c8def05c410cb72326d597c80cb731059969ef89fa5fddaae1242225886e6109fcb535c4ad62d56ebcdf1ea
PastaPastaPasta pushed a commit to PastaPastaPasta/dash that referenced this pull request Jan 2, 2020
@PastaPastaPasta
Merge bitcoin#10965: Replace deprecated throw() with noexcept specifi…
401d6b6 
…er (C++11)

9862550 Use the noexcept specifier (C++11) instead of deprecated throw() (practicalswift)

Pull request description:

  Use the `noexcept` specifier (C++11) instead of deprecated `throw()`.

Tree-SHA512: cf9b6b18f61f2f59bbeceb2e43b5cd07a60f5e569c8def05c410cb72326d597c80cb731059969ef89fa5fddaae1242225886e6109fcb535c4ad62d56ebcdf1ea
PastaPastaPasta pushed a commit to PastaPastaPasta/dash that referenced this pull request Jan 3, 2020
@PastaPastaPasta
Merge bitcoin#10965: Replace deprecated throw() with noexcept specifi…
013de95 
…er (C++11)

9862550 Use the noexcept specifier (C++11) instead of deprecated throw() (practicalswift)

Pull request description:

  Use the `noexcept` specifier (C++11) instead of deprecated `throw()`.

Tree-SHA512: cf9b6b18f61f2f59bbeceb2e43b5cd07a60f5e569c8def05c410cb72326d597c80cb731059969ef89fa5fddaae1242225886e6109fcb535c4ad62d56ebcdf1ea

throw() -> noexcept

Signed-off-by: Pasta <pasta@dashboost.org>
@practicalswift practicalswift deleted the noexcept branch April 10, 2021 19:32
@random-zebra random-zebra mentioned this pull request May 9, 2021
Merged
random-zebra added a commit to PIVX-Project/PIVX that referenced this pull request May 11, 2021
@random-zebra
Merge #2376: Replace deprecated throw() with noexcept specifier (C++11)
44ddf8a 
24ce9a7 Use the noexcept specifier (C++11) instead of deprecated throw() (practicalswift)

Pull request description:

  Straightforward cherry-pick from bitcoin#10965

ACKs for top commit:
  furszy:
    utACK 24ce9a7
  Fuzzbawls:
    utACK 24ce9a7

Tree-SHA512: c14aea9d9c39d99250ef825e4066851ef50700e8b91f4320b278661b97e1da616cf8464d4660bf0043e2fd163be81d3b9302057b4ea4b1096eb75402bd17b49c
@lyricidal lyricidal mentioned this pull request Jun 15, 2021
Merged
gades pushed a commit to cosanta/cosanta-core that referenced this pull request Mar 17, 2022
@gades
Merge bitcoin#10965: Replace deprecated throw() with noexcept specifi…
1eea72b 
…er (C++11)

9862550 Use the noexcept specifier (C++11) instead of deprecated throw() (practicalswift)

Pull request description:

  Use the `noexcept` specifier (C++11) instead of deprecated `throw()`.

Tree-SHA512: cf9b6b18f61f2f59bbeceb2e43b5cd07a60f5e569c8def05c410cb72326d597c80cb731059969ef89fa5fddaae1242225886e6109fcb535c4ad62d56ebcdf1ea

throw() -> noexcept

Signed-off-by: Pasta <pasta@dashboost.org>
@bitcoin bitcoin locked as resolved and limited conversation to collaborators Aug 16, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
Refactoring
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@practicalswift @laanwj @jonasschnelli @TheBlueMatt @promag @fanquake @maflcko