Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: Add python3 to list of dependencies on some platforms #11136

Merged
merged 1 commit into from Sep 2, 2017

Conversation

danra
Copy link
Contributor

@danra danra commented Aug 25, 2017

python3 is required for running the unit tests on macOS.

Without python3 on macOS, 'make check' fails because /test/util/bitcoin-util-test.py fails to find python3.

@maflcko
Copy link
Member

maflcko commented Aug 25, 2017

The dependencies for the functional tests are mentioned in https://github.com/danra/bitcoin/tree/master/test#dependencies

@danra
Copy link
Contributor Author

danra commented Aug 25, 2017

@MarcoFalke OK, but I don't think it makes sense for build_osx.md to recommend running make check on one hand, while on the other hand not mentioning the dependencies for running it when listing the dependencies earlier.

@maflcko
Copy link
Member

maflcko commented Aug 25, 2017

The readme in src/test mentions that the unit tests can be run with make check, but doesn't mention the python3 dependency. We might combine the src/test readme into the /test/ readme and then link to the combined readme from the /doc/ subdir.

@fanquake fanquake added the Docs label Aug 25, 2017
@laanwj
Copy link
Member

laanwj commented Aug 28, 2017

Concept ACK, as python 3 is required for the unit tests (not just the functional tests in test/functional) we should just mention it as dependency.
(it used to be the case that make check could be done without python 3)

@maflcko
Copy link
Member

maflcko commented Aug 28, 2017

Fine with me, but please also update the dependencies for ubuntu/fedora

@danra
Copy link
Contributor Author

danra commented Aug 28, 2017

@MarcoFalke I've only checked the dependencies on my macOS. Should I just add python3 to the build documentation for the platforms you mentioned as well?

@maflcko
Copy link
Member

maflcko commented Aug 28, 2017

Yes, python3 will be required on the other platforms as well.

@danra danra changed the title Docs: Add python3 to list of dependencies on macOS Docs: Add python3 to list of dependencies on some platforms Aug 30, 2017
python3 is required for running the unit tests on macOS, Ubuntu and Fedora.

Without python3 installed, 'make check' fails because /test/util/bitcoin-util-test.py fails to find python3.
@danra
Copy link
Contributor Author

danra commented Aug 30, 2017

@MarcoFalke Done

@maflcko
Copy link
Member

maflcko commented Sep 1, 2017

utACK 7bb5d30

@jnewbery
Copy link
Contributor

jnewbery commented Sep 1, 2017

utACK 7bb5d30

@fanquake
Copy link
Member

fanquake commented Sep 2, 2017

utACK 7bb5d30

@maflcko maflcko merged commit 7bb5d30 into bitcoin:master Sep 2, 2017
maflcko pushed a commit that referenced this pull request Sep 2, 2017
…orms

7bb5d30 Add python3 to list of dependencies on some platforms (danra)

Pull request description:

  python3 is required for running the unit tests on macOS.

  Without python3 on macOS, 'make check' fails because /test/util/bitcoin-util-test.py fails to find python3.

Tree-SHA512: 71dd43bc9099e8431c0b4296301147068282a9f6fed424d7640271b149a51dedeb8fd1386350f08333eb1383ac09b1183c2600347d43367bbb2804abd4fb6e52
@bitcoin bitcoin locked as resolved and limited conversation to collaborators Sep 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants