Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove redundant explicitly defined copy ctors #11161

Merged
merged 1 commit into from Aug 28, 2017
Merged

Remove redundant explicitly defined copy ctors #11161

merged 1 commit into from Aug 28, 2017

Commits on Aug 27, 2017

  1. Remove redundant explicitly defined copy ctors 

    CFeeRate and CTxMemPoolEntry have explicitly defined copy ctors which has the same functionality as the implicit default copy ctors which would have been generated otherwise.

Besides being redundant, it violates the rule of three (see https://en.wikipedia.org/wiki/Rule_of_three_(C%2B%2B_programming) ).
(Of course, the rule of three doesn't -really- cause a resource management issue here, but the reason for that is exactly that there is no need for an explicit copy ctor in the first place since no resources are being managed).
CFeeRate has an explicitly defined copy ctor which has the same functionality as the implicit default copy ctor which would h
ave been generated otherwise.
    @danra
    danra committed Aug 27, 2017
    Configuration menu
    Copy the full SHA
    b426e24 View commit details
    Browse the repository at this point in the history