[Docs] Update CONTRIBUTING.md to reduce unnecessary review workload #11276
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Concept ACK |
laanwj
reviewed
Sep 7, 2017
CONTRIBUTING.md
Outdated
| certain level of experience to know where the code belongs to and to understand | ||
| the full ramification (including rebase effort of open pull requests). | ||
|
|
||
| Refactoring and trivial pull requests with no clear benefits may be directly |
laanwj
reviewed
Sep 7, 2017
CONTRIBUTING.md
Outdated
| @@ -157,6 +157,13 @@ behaviour of code within the pull request (bugs must be preserved as is). | |||
| Project maintainers aim for a quick turnaround on refactoring pull requests, so | |||
| where possible keep them short, uncomplex and easy to verify. | |||
|
|
|||
| Refactoring pull requests should not be made by new contributors. It requires a | |||
There was a problem hiding this comment.
"Refactoring changes" maybe, or "Pull requests that refactor the code"
maflcko
reviewed
Sep 7, 2017
CONTRIBUTING.md
Outdated
| the full ramification (including rebase effort of open pull requests). | ||
|
|
||
| Refactoring and trivial pull requests with no clear benefits may be directly | ||
| closed by the maintainers to reduce unnecessary workload on reviewing. |
There was a problem hiding this comment.
Maybe add
Any refactoring pull request may be closed when it doesn't attract anyone willing to review.
|
utACK e27effaf8dfde49acfd6bea96eb0e4754ccaead1. Couldn't find a way to test this without merging. |
jonasschnelli
force-pushed
the
2017/09/cont
branch
from
e27effa
to
91c39e3
Compare
|
Updated. |
|
Seems reasonable. There have also been a few cases recently where multiple PRs have been opened when the changes should have all been in a single PR. utACK 91c39e3 |
|
Typo in PR title and commit message Maybe add something along "Instead new contributors should discuss refactors with other developers in the usual channels." Concept ACK. |
fanquake
changed the title
maflcko
pushed a commit
that referenced
this pull request
Sep 10, 2017
…iew workload 91c39e3 Update CONTRIBUTRING.md to reduce unnecesarry review workload (Jonas Schnelli) Pull request description: The current workload for reviewing pull requests is relatively high and trivial, non-beneficial pull requests tend to slow down the overall development process. We may want to directly close trivial, non-beneficially pull requests during time of high pull request load. This PR would prepare for possible direct PR closing. Tree-SHA512: 6a0fb0133e42a400133cc77e4830620c26af4fe5b69f6238e0e77e686d785bd984d85c681a942701e7719de836147e646091a6c492f1d1e2abb906129566082f
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current workload for reviewing pull requests is relatively high and trivial, non-beneficial pull requests tend to slow down the overall development process.
We may want to directly close trivial, non-beneficially pull requests during time of high pull request load.
This PR would prepare for possible direct PR closing.