[0.15] Final to-do's for 0.15.0 release notes #11280
Conversation
|
Concept ACK |
doc/release-notes.md
Outdated
| Rescanning with encrypted wallets | ||
| --------------------------------- | ||
|
|
||
| When using an encrypted HD wallet, the keypool cannot be topped up without unlocking the wallet. This means that |
There was a problem hiding this comment.
might want to note this is not a regression, right?
doc/release-notes.md
Outdated
|
|
||
| Version 0.15.0 supports adding a segregated witness address via the `addwitnessaddress` RPC, but | ||
| please note that this is a testing/expert RPC, which does not guarantee recovery from backup. Only use | ||
| this RPC if you know what you are doing. More complete support for segregated witness, including |
There was a problem hiding this comment.
"including wallet support" sounds like there are other things missing. It's the only thing...
doc/release-notes.md
Outdated
|
|
||
| When using an encrypted HD wallet, the keypool cannot be topped up without unlocking the wallet. This means that | ||
| currently, in order to recover from a backup of an encrypted HD wallet, the user must unlock the wallet with a | ||
| really long time out and manually trigger a rescan with `-rescan`, otherwise they risk missing some keys when |
There was a problem hiding this comment.
Rescan rpc (or command in the gui debug console). ... if you restart with -rescan you'll be relocked!
There was a problem hiding this comment.
Oops, fixed, thanks
|
I don't think we have that RPC call, outside of importing a private key or
something like that?
…On Thu, Sep 7, 2017 at 4:41 PM, Gregory Maxwell ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In doc/release-notes.md
<#11280 (comment)>:
> +================
+
+Current SegWit Support
+----------------------
+
+Version 0.15.0 supports adding a segregated witness address via the `addwitnessaddress` RPC, but
+please note that this is a testing/expert RPC, which does not guarantee recovery from backup. Only use
+this RPC if you know what you are doing. More complete support for segregated witness, including
+wallet support, is coming in a next version.
+
+Rescanning with encrypted wallets
+---------------------------------
+
+When using an encrypted HD wallet, the keypool cannot be topped up without unlocking the wallet. This means that
+currently, in order to recover from a backup of an encrypted HD wallet, the user must unlock the wallet with a
+really long time out and manually trigger a rescan with `-rescan`, otherwise they risk missing some keys when
Rescan rpc (or command in the gui debug console). ... if you restart with
-rescan you'll be relocked!
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#11280 (review)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AFgC0w3zgsdKF6NT7LjHMF3oL8MT8xD5ks5sgH9FgaJpZM4PQfrG>
.
|
doc/release-notes.md
Outdated
| Notes for 0.15.0 | ||
| ================ | ||
|
|
||
| Current SegWit Support |
There was a problem hiding this comment.
Fixed, although title capitalisation is a bit inconsistent already in the file
| Version 0.15.0 supports adding a segregated witness address via the `addwitnessaddress` RPC, but | ||
| please note that this is a testing/expert RPC, which does not guarantee recovery from backup. Only use | ||
| this RPC if you know what you are doing. More complete wallet support for segregated witness is coming | ||
| in a next version. |
There was a problem hiding this comment.
Is this going to be in a point release, or 0.16.0 ? I think we should mention which here, because one could be a month away, while the other is 6 months or more. If not, instead of "is coming in a next version.", maybe just "will be available shortly." ?
There was a problem hiding this comment.
Segwit wallet support is aimed for 0.15.1 I believe? Also to me, "will be available shortly." sounds like it will somehow be added to 0.15.0, I like the emphasis on the new version
doc/release-notes.md
Outdated
|
|
||
| As in previous versions, when using an encrypted HD wallet, the keypool cannot be topped up without unlocking | ||
| the wallet. This means that currently, in order to recover from a backup of an encrypted HD wallet, the user | ||
| must unlock the wallet with a really long time out and manually trigger a rescan, otherwise they risk missing |
|
ACK; needs rebase to fix travis |
|
This has missed the 0.15.0 final tag, forgot about this one, sorry! |
|
Keeping this open for now, I'll see if I can still include this in the release notes uploaded to bitcoin.org etc. |
This seems wrong. Doc string says: |
|
Closing, this is now part of the 0.15.0 release notes on master.
Did not see this remark soon enough, so could not take this into account. |
Closes #11174
I may have missed things that should be included, happy to amend :)