Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure ~/.bitcoin doesn't exist before build #11297

Merged
merged 1 commit into from Sep 11, 2017
Merged

Make sure ~/.bitcoin doesn't exist before build #11297

merged 1 commit into from Sep 11, 2017

Conversation

meshcollider
Copy link
Contributor

@meshcollider meshcollider commented Sep 10, 2017

We've been getting some random travis failures since #11260 was merged, because the ~/.bitcoin directory exists after tests are run. Not sure exactly what's causing it, but this PR ensures the directory doesn't exist before running the build and tests, to see if this fixes the issue.

Edit: travis has been run on this merge twice, and all tests passed both times, so either this fixes the issue or it just got lucky

@sipa
Copy link
Member

sipa commented Sep 10, 2017

utACK b73628d. It survived 2 full Travis runs, and fixed the same issue occurring in #11167.

@laanwj
Copy link
Member

laanwj commented Sep 10, 2017

If this is what I think it is, that PRs that were built by travis and cached before #11210 was merged have a ~/.bitcoin in their cache, it can also be solved by wiping the Travis caches.

Edit: had to wipe the entire travis cache to test this - the Travis interface made it impossible to select individual PRs beyond 11111 or so. So I wiped all the cache and started a new build for the branches. Builds will be slow until master finishes rebuilding.

@meshcollider
Copy link
Contributor Author

@laanwj does Travis cache data only from builds which pass all tests?

@laanwj
Copy link
Member

laanwj commented Sep 10, 2017

@meshcollider Yes

@meshcollider
Copy link
Contributor Author

@laanwj In that case this should never be an issue again right, because there should be no way for the directory to ever be cached, so we can close this

@laanwj
Copy link
Member

laanwj commented Sep 11, 2017

I hope so! I'm not sure this is actually the issue, but it seemed likely. I do not understand where a .bitcoin directory would come from otherwise. We still might merge this though for symmetry, I don't know.

@meshcollider meshcollider reopened this Sep 11, 2017
@laanwj
Copy link
Member

laanwj commented Sep 11, 2017

I don't think this was solved, I started #11289 a few times and it's still failing. Reopening.

@maflcko
Copy link
Member

maflcko commented Sep 11, 2017

Going to merge this, so we gain some air to breathe. But I can't see how this dir was created at that point.

@maflcko maflcko merged commit b73628d into bitcoin:master Sep 11, 2017
maflcko pushed a commit that referenced this pull request Sep 11, 2017
b73628d Make sure ~/.bitcoin doesn't exist before build (MeshCollider)

Pull request description:

  We've been getting some random travis failures since #11260 was merged, because the `~/.bitcoin` directory exists after tests are run. Not sure exactly what's causing it, but this PR ensures the directory doesn't exist before running the build and tests, to see if this fixes the issue.

  Edit: travis has been run on this merge twice, and all tests passed both times, so either this fixes the issue or it just got lucky

Tree-SHA512: d48e594cfc19a16f4c6e360ec78956ff4274169e92fac4602ab0b980de32875c1e9d3cb24a40c708b5334dbbf8bf55a8003121591bdb5f3fdd256d63e1235aa8
@meshcollider
Copy link
Contributor Author

#11289 is passing now 👍

@laanwj
Copy link
Member

laanwj commented Sep 11, 2017

Great! I think this is good for a temporary workaround.

There's no chance that travis.yml will be executed on user's account, otherwise this would be terribly dangerous.

@meshcollider meshcollider deleted the 201709_travis_delete_dir branch September 11, 2017 19:55
@bitcoin bitcoin locked as resolved and limited conversation to collaborators Sep 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants