/bitcoin

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

[qt] Add use available balance in send coins dialog (CryptAxe, promag) #11316

Merged
merged 1 commit into from Nov 10, 2017

Conversation

Reviewers

@luke-jr luke-jr

Assignees
No one assigned
Labels
GUI
Projects
None yet
Milestone
No milestone
7 participants
@promag @MeshCollider @jonasschnelli @luke-jr @fanquake @MarcoFalke @CryptAxe
@promag
Contributor

promag commented Sep 13, 2017 •
Edited 1 time

This is an alternative to #11098 to handle #11033 where a new button Use available balance is added to each entry. When activated, the available balance is calculated by using the coin control (if any) and then it's subtracted the remaining recipient amounts. If this amount is positive then the Subtract fee from amount is automatically selected.

Comparing to #11098, this has the advantage to avoid the fair amount division over the recipients and allows to fine adjust the amounts in multiple iterations.

Started from @CryptAxe commit 89e9eda to credit some code.

screen shot 2017-09-13 at 01 32 44

screen shot 2017-09-13 at 01 44 57

@fanquake fanquake added the GUI label Sep 13, 2017

@MeshCollider
Member

MeshCollider commented Sep 13, 2017 •
Edited 1 time

Concept ACK, I prefer this over #11098

Edit: utACK d052e38
@jonasschnelli
Member

jonasschnelli commented Sep 16, 2017

Nice!
I like how it respects other just added outputs.
utACK d052e38
@promag
Contributor

promag commented Oct 10, 2017

@laudaa Care to try out?

@achow101 achow101 referenced this pull request Oct 19, 2017

Closed

[QT] - Send-all Button #11033

@luke-jr

luke-jr approved these changes Nov 10, 2017
View changes

utACK

@MarcoFalke MarcoFalke changed the title from [qt] Add use available balance in send coins dialog to [qt] Add use available balance in send coins dialog (CryptAxe, promag) Nov 10, 2017

@MarcoFalke MarcoFalke merged commit d052e38 into bitcoin:master Nov 10, 2017
1 check passed

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

MarcoFalke added a commit that referenced this pull request Nov 10, 2017

@MarcoFalke
Merge #11316: [qt] Add use available balance in send coins dialog (Cr… 
…yptAxe, promag)


d052e38 [qt] Add use available balance in send coins dialog (CryptAxe)

Pull request description:

  This is an alternative to #11098 to handle #11033 where a new button `Use available balance` is added to each entry. When activated, the available balance is calculated by using the coin control (if any) and then it's subtracted the remaining recipient amounts. If this amount is positive then the `Subtract fee from amount` is automatically selected.

  Comparing to #11098, this has the advantage to avoid the fair amount division over the recipients and allows to fine adjust the amounts in multiple iterations.

  Started from @CryptAxe commit 89e9eda to credit some code.

  <img width="965" alt="screen shot 2017-09-13 at 01 32 44" src="https://user-images.githubusercontent.com/3534524/30354518-e1bee31c-9824-11e7-9354-300aa63cdfd0.png">
  <img width="964" alt="screen shot 2017-09-13 at 01 44 57" src="https://user-images.githubusercontent.com/3534524/30354598-5731ac9c-9825-11e7-9d5f-8781988ed219.png">

Tree-SHA512: 01d20c13fd8b6c2a0ca1d74d3a9027c6922e6dccd3b08e59d5a72636be7072ed5eca7ebc5d431299497dd3374e83753220ad4174d8bc46dadb4b2f54973036a5
This commit was signed with a verified signature.
@MarcoFalke MarcoFalke
GPG key ID: D2EA4850E7528B25 Learn about signing commits
22cdf93

luke-jr added a commit to bitcoinknots/bitcoin that referenced this pull request Nov 11, 2017

@CryptAxe @luke-jr
[qt] Add use available balance in send coins dialog 
Github-Pull: #11316
Rebased-From: d052e38
6fc77f3

@CryptAxe CryptAxe referenced this pull request Nov 17, 2017

Closed

[Qt] Add spend all button to the SendCoinsDialog #11098

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment