New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[qt] Add use available balance in send coins dialog (CryptAxe, promag) #11316

Merged
merged 1 commit into from Nov 10, 2017

Conversation

Projects
None yet
7 participants
@promag
Member

promag commented Sep 13, 2017

This is an alternative to #11098 to handle #11033 where a new button Use available balance is added to each entry. When activated, the available balance is calculated by using the coin control (if any) and then it's subtracted the remaining recipient amounts. If this amount is positive then the Subtract fee from amount is automatically selected.

Comparing to #11098, this has the advantage to avoid the fair amount division over the recipients and allows to fine adjust the amounts in multiple iterations.

Started from @CryptAxe commit 89e9eda to credit some code.

screen shot 2017-09-13 at 01 32 44

screen shot 2017-09-13 at 01 44 57

@fanquake fanquake added the GUI label Sep 13, 2017

@MeshCollider

This comment has been minimized.

Show comment
Hide comment
@MeshCollider

MeshCollider Sep 13, 2017

Member

Concept ACK, I prefer this over #11098

Edit: utACK d052e38

Member

MeshCollider commented Sep 13, 2017

Concept ACK, I prefer this over #11098

Edit: utACK d052e38

@jonasschnelli

This comment has been minimized.

Show comment
Hide comment
@jonasschnelli

jonasschnelli Sep 16, 2017

Member

Nice!
I like how it respects other just added outputs.
utACK d052e38

Member

jonasschnelli commented Sep 16, 2017

Nice!
I like how it respects other just added outputs.
utACK d052e38

@promag

This comment has been minimized.

Show comment
Hide comment
@promag

promag Oct 10, 2017

Member

@laudaa Care to try out?

Member

promag commented Oct 10, 2017

@laudaa Care to try out?

@achow101 achow101 referenced this pull request Oct 19, 2017

Closed

[QT] - Send-all Button #11033

@luke-jr

utACK

@MarcoFalke MarcoFalke changed the title from [qt] Add use available balance in send coins dialog to [qt] Add use available balance in send coins dialog (CryptAxe, promag) Nov 10, 2017

@MarcoFalke MarcoFalke merged commit d052e38 into bitcoin:master Nov 10, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

MarcoFalke added a commit that referenced this pull request Nov 10, 2017

Merge #11316: [qt] Add use available balance in send coins dialog (Cr…
…yptAxe, promag)

d052e38 [qt] Add use available balance in send coins dialog (CryptAxe)

Pull request description:

  This is an alternative to #11098 to handle #11033 where a new button `Use available balance` is added to each entry. When activated, the available balance is calculated by using the coin control (if any) and then it's subtracted the remaining recipient amounts. If this amount is positive then the `Subtract fee from amount` is automatically selected.

  Comparing to #11098, this has the advantage to avoid the fair amount division over the recipients and allows to fine adjust the amounts in multiple iterations.

  Started from @CryptAxe commit 89e9eda to credit some code.

  <img width="965" alt="screen shot 2017-09-13 at 01 32 44" src="https://user-images.githubusercontent.com/3534524/30354518-e1bee31c-9824-11e7-9354-300aa63cdfd0.png">
  <img width="964" alt="screen shot 2017-09-13 at 01 44 57" src="https://user-images.githubusercontent.com/3534524/30354598-5731ac9c-9825-11e7-9d5f-8781988ed219.png">

Tree-SHA512: 01d20c13fd8b6c2a0ca1d74d3a9027c6922e6dccd3b08e59d5a72636be7072ed5eca7ebc5d431299497dd3374e83753220ad4174d8bc46dadb4b2f54973036a5

luke-jr added a commit to bitcoinknots/bitcoin that referenced this pull request Nov 11, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment