Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Tests] Add Qt GUI tests to Overview and ReceiveCoin Page #11365

Merged
merged 1 commit into from Oct 2, 2017
Merged

[Tests] Add Qt GUI tests to Overview and ReceiveCoin Page #11365

merged 1 commit into from Oct 2, 2017

Conversation

anditto
Copy link
Contributor

@anditto anditto commented Sep 19, 2017

I've added some Qt wallet tests based on #9974, namely the input & buttons on ReceiveCoin.

@fanquake fanquake added the Tests label Sep 19, 2017
kallewoof
kallewoof reviewed Sep 19, 2017
View reviewed changes
Copy link
Member

@kallewoof kallewoof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK 2f9b71f21cd9a56d80b4517b8dab68c7160dc75e with some nits

src/qt/test/wallettests.cpp Outdated

// Amount input
BitcoinAmountField* amountInput = receiveCoinsDialog.findChild<BitcoinAmountField*>("reqAmount");
CAmount testAmount = 1.0;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CAmounts are not floats; just use 1. Since you're not using it elsewhere you may want to just do setValue(1) below.

src/qt/test/wallettests.cpp Outdated
QCOMPARE(paymentTextList.at(0), QString("Payment information"));
QVERIFY(paymentTextList.at(1).indexOf(QString("URI: bitcoin:")) != -1);
QVERIFY(paymentTextList.at(2).indexOf(QString("Address:")) != -1);
QCOMPARE(paymentTextList.at(3), QString("Amount: 0.00000001 BTC"));
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You may wanna use CURRENCY_UNIT instead of hard-coded BTC here. It's defined in policy/feerate.h.

@maflcko maflcko merged commit 634e38c into bitcoin:master Oct 2, 2017
maflcko pushed a commit that referenced this pull request Oct 2, 2017
Merge #11365: [Tests] Add Qt GUI tests to Overview and ReceiveCoin Page
f199b8a 
634e38c [Tests] Add Qt GUI tests to Overview and ReceiveCoin Page (Anditto Heristyo)

Pull request description:

  I've added some Qt wallet tests based on #9974, namely the input & buttons on ReceiveCoin.

Tree-SHA512: f4223827145e35c2abee83a6ca777498bebcff3825fece10fbb1dbfd1f6bb017d3f2c0521662854b4407cdeee9c6a527269ab9cc28e0dc85c11b668155fcd195
@maflcko
Copy link
Member

maflcko commented Oct 2, 2017

utACK 634e38c

@anditto anditto deleted the Adding-Qt-tests branch October 10, 2017 07:24
PastaPastaPasta pushed a commit to PastaPastaPasta/dash that referenced this pull request Jan 17, 2020
@PastaPastaPasta
Merge bitcoin#11365: [Tests] Add Qt GUI tests to Overview and Receive…
d3c59cf 
…Coin Page

634e38c [Tests] Add Qt GUI tests to Overview and ReceiveCoin Page (Anditto Heristyo)

Pull request description:

  I've added some Qt wallet tests based on bitcoin#9974, namely the input & buttons on ReceiveCoin.

Tree-SHA512: f4223827145e35c2abee83a6ca777498bebcff3825fece10fbb1dbfd1f6bb017d3f2c0521662854b4407cdeee9c6a527269ab9cc28e0dc85c11b668155fcd195
PastaPastaPasta pushed a commit to PastaPastaPasta/dash that referenced this pull request Jan 22, 2020
@PastaPastaPasta
Merge bitcoin#11365: [Tests] Add Qt GUI tests to Overview and Receive…
2c244c2 
…Coin Page

634e38c [Tests] Add Qt GUI tests to Overview and ReceiveCoin Page (Anditto Heristyo)

Pull request description:

  I've added some Qt wallet tests based on bitcoin#9974, namely the input & buttons on ReceiveCoin.

Tree-SHA512: f4223827145e35c2abee83a6ca777498bebcff3825fece10fbb1dbfd1f6bb017d3f2c0521662854b4407cdeee9c6a527269ab9cc28e0dc85c11b668155fcd195
PastaPastaPasta pushed a commit to PastaPastaPasta/dash that referenced this pull request Jan 22, 2020
@PastaPastaPasta
Merge bitcoin#11365: [Tests] Add Qt GUI tests to Overview and Receive…
41678a3 
…Coin Page

634e38c [Tests] Add Qt GUI tests to Overview and ReceiveCoin Page (Anditto Heristyo)

Pull request description:

  I've added some Qt wallet tests based on bitcoin#9974, namely the input & buttons on ReceiveCoin.

Tree-SHA512: f4223827145e35c2abee83a6ca777498bebcff3825fece10fbb1dbfd1f6bb017d3f2c0521662854b4407cdeee9c6a527269ab9cc28e0dc85c11b668155fcd195
PastaPastaPasta pushed a commit to PastaPastaPasta/dash that referenced this pull request Jan 29, 2020
@PastaPastaPasta
Merge bitcoin#11365: [Tests] Add Qt GUI tests to Overview and Receive…
715426b 
…Coin Page

634e38c [Tests] Add Qt GUI tests to Overview and ReceiveCoin Page (Anditto Heristyo)

Pull request description:

  I've added some Qt wallet tests based on bitcoin#9974, namely the input & buttons on ReceiveCoin.

Tree-SHA512: f4223827145e35c2abee83a6ca777498bebcff3825fece10fbb1dbfd1f6bb017d3f2c0521662854b4407cdeee9c6a527269ab9cc28e0dc85c11b668155fcd195
PastaPastaPasta pushed a commit to PastaPastaPasta/dash that referenced this pull request Jan 29, 2020
@PastaPastaPasta
Merge bitcoin#11365: [Tests] Add Qt GUI tests to Overview and Receive…
6e829d9 
…Coin Page

634e38c [Tests] Add Qt GUI tests to Overview and ReceiveCoin Page (Anditto Heristyo)

Pull request description:

  I've added some Qt wallet tests based on bitcoin#9974, namely the input & buttons on ReceiveCoin.

Tree-SHA512: f4223827145e35c2abee83a6ca777498bebcff3825fece10fbb1dbfd1f6bb017d3f2c0521662854b4407cdeee9c6a527269ab9cc28e0dc85c11b668155fcd195
PastaPastaPasta pushed a commit to PastaPastaPasta/dash that referenced this pull request Jan 31, 2020
@PastaPastaPasta
Merge bitcoin#11365: [Tests] Add Qt GUI tests to Overview and Receive…
27a4f30 
…Coin Page

634e38c [Tests] Add Qt GUI tests to Overview and ReceiveCoin Page (Anditto Heristyo)

Pull request description:

  I've added some Qt wallet tests based on bitcoin#9974, namely the input & buttons on ReceiveCoin.

Tree-SHA512: f4223827145e35c2abee83a6ca777498bebcff3825fece10fbb1dbfd1f6bb017d3f2c0521662854b4407cdeee9c6a527269ab9cc28e0dc85c11b668155fcd195
PastaPastaPasta pushed a commit to PastaPastaPasta/dash that referenced this pull request Jan 31, 2020
@PastaPastaPasta
Merge bitcoin#11365: [Tests] Add Qt GUI tests to Overview and Receive…
6d8738e 
…Coin Page

634e38c [Tests] Add Qt GUI tests to Overview and ReceiveCoin Page (Anditto Heristyo)

Pull request description:

  I've added some Qt wallet tests based on bitcoin#9974, namely the input & buttons on ReceiveCoin.

Tree-SHA512: f4223827145e35c2abee83a6ca777498bebcff3825fece10fbb1dbfd1f6bb017d3f2c0521662854b4407cdeee9c6a527269ab9cc28e0dc85c11b668155fcd195
gades pushed a commit to cosanta/cosanta-core that referenced this pull request Jun 30, 2021
@gades
Merge bitcoin#11365: [Tests] Add Qt GUI tests to Overview and Receive…
ba241e9 
…Coin Page

634e38c [Tests] Add Qt GUI tests to Overview and ReceiveCoin Page (Anditto Heristyo)

Pull request description:

  I've added some Qt wallet tests based on bitcoin#9974, namely the input & buttons on ReceiveCoin.

Tree-SHA512: f4223827145e35c2abee83a6ca777498bebcff3825fece10fbb1dbfd1f6bb017d3f2c0521662854b4407cdeee9c6a527269ab9cc28e0dc85c11b668155fcd195
@bitcoin bitcoin locked as resolved and limited conversation to collaborators Sep 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kallewoof kallewoof kallewoof left review comments

Assignees
No one assigned
Labels
Tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@anditto @maflcko @kallewoof @fanquake