Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unused fTry from push_lock #11432

Merged
merged 1 commit into from Oct 2, 2017
Merged

Remove unused fTry from push_lock #11432

merged 1 commit into from Oct 2, 2017

Conversation

promag
Copy link
Member

@promag promag commented Sep 30, 2017

After #9674 (618ee92) the fTry argument in push_lock is no longer needed.

@promag
Copy link
Member Author

promag commented Sep 30, 2017

@TheBlueMatt FYI.

@meshcollider
Copy link
Contributor

utACK 92848e5

@maflcko
Copy link
Member

maflcko commented Oct 1, 2017

utACK 92848e5

@fanquake
Copy link
Member

fanquake commented Oct 1, 2017

utACK 92848e5

@laanwj laanwj merged commit 92848e5 into bitcoin:master Oct 2, 2017
laanwj added a commit that referenced this pull request Oct 2, 2017
@laanwj
Merge #11432: Remove unused fTry from push_lock
058c0f9 
92848e5 Remove unused fTry from push_lock (João Barbosa)

Pull request description:

  After #9674 (618ee92) the `fTry` argument in `push_lock` is no longer needed.

Tree-SHA512: a461f2ca9e590a9dfcc7814d9852d85f03712cb4735176b8b2db0e8dc731597c2a515650998ca7d53cf5a0c48b408a974a0704897036c6ed74788fc24c5e73ae
@jnewbery
Copy link
Contributor

jnewbery commented Oct 2, 2017

post-merge ACK 92848e5

follow-up question: Is there any need for the member variable fTry in CLockLocation? If not, can we remove that and also the fTry argument in EnterCritical()?

PastaPastaPasta pushed a commit to PastaPastaPasta/dash that referenced this pull request Dec 22, 2019
@laanwj @PastaPastaPasta
Merge bitcoin#11432: Remove unused fTry from push_lock
fa7c71a 
92848e5 Remove unused fTry from push_lock (João Barbosa)

Pull request description:

  After bitcoin#9674 (618ee92) the `fTry` argument in `push_lock` is no longer needed.

Tree-SHA512: a461f2ca9e590a9dfcc7814d9852d85f03712cb4735176b8b2db0e8dc731597c2a515650998ca7d53cf5a0c48b408a974a0704897036c6ed74788fc24c5e73ae
PastaPastaPasta pushed a commit to PastaPastaPasta/dash that referenced this pull request Jan 2, 2020
@laanwj @PastaPastaPasta
Merge bitcoin#11432: Remove unused fTry from push_lock
aaae79b 
92848e5 Remove unused fTry from push_lock (João Barbosa)

Pull request description:

  After bitcoin#9674 (618ee92) the `fTry` argument in `push_lock` is no longer needed.

Tree-SHA512: a461f2ca9e590a9dfcc7814d9852d85f03712cb4735176b8b2db0e8dc731597c2a515650998ca7d53cf5a0c48b408a974a0704897036c6ed74788fc24c5e73ae
PastaPastaPasta pushed a commit to PastaPastaPasta/dash that referenced this pull request Jan 4, 2020
@laanwj @PastaPastaPasta
Merge bitcoin#11432: Remove unused fTry from push_lock
35c7897 
92848e5 Remove unused fTry from push_lock (João Barbosa)

Pull request description:

  After bitcoin#9674 (618ee92) the `fTry` argument in `push_lock` is no longer needed.

Tree-SHA512: a461f2ca9e590a9dfcc7814d9852d85f03712cb4735176b8b2db0e8dc731597c2a515650998ca7d53cf5a0c48b408a974a0704897036c6ed74788fc24c5e73ae
PastaPastaPasta pushed a commit to PastaPastaPasta/dash that referenced this pull request Jan 12, 2020
@laanwj @PastaPastaPasta
Merge bitcoin#11432: Remove unused fTry from push_lock
7a1bc16 
92848e5 Remove unused fTry from push_lock (João Barbosa)

Pull request description:

  After bitcoin#9674 (618ee92) the `fTry` argument in `push_lock` is no longer needed.

Tree-SHA512: a461f2ca9e590a9dfcc7814d9852d85f03712cb4735176b8b2db0e8dc731597c2a515650998ca7d53cf5a0c48b408a974a0704897036c6ed74788fc24c5e73ae
PastaPastaPasta pushed a commit to PastaPastaPasta/dash that referenced this pull request Jan 12, 2020
@laanwj @PastaPastaPasta
Merge bitcoin#11432: Remove unused fTry from push_lock
c6c3584 
92848e5 Remove unused fTry from push_lock (João Barbosa)

Pull request description:

  After bitcoin#9674 (618ee92) the `fTry` argument in `push_lock` is no longer needed.

Tree-SHA512: a461f2ca9e590a9dfcc7814d9852d85f03712cb4735176b8b2db0e8dc731597c2a515650998ca7d53cf5a0c48b408a974a0704897036c6ed74788fc24c5e73ae
PastaPastaPasta pushed a commit to PastaPastaPasta/dash that referenced this pull request Jan 12, 2020
@laanwj @PastaPastaPasta
Merge bitcoin#11432: Remove unused fTry from push_lock
0e7ceed 
92848e5 Remove unused fTry from push_lock (João Barbosa)

Pull request description:

  After bitcoin#9674 (618ee92) the `fTry` argument in `push_lock` is no longer needed.

Tree-SHA512: a461f2ca9e590a9dfcc7814d9852d85f03712cb4735176b8b2db0e8dc731597c2a515650998ca7d53cf5a0c48b408a974a0704897036c6ed74788fc24c5e73ae
PastaPastaPasta pushed a commit to PastaPastaPasta/dash that referenced this pull request Jan 12, 2020
@laanwj @PastaPastaPasta
Merge bitcoin#11432: Remove unused fTry from push_lock
de032e6 
92848e5 Remove unused fTry from push_lock (João Barbosa)

Pull request description:

  After bitcoin#9674 (618ee92) the `fTry` argument in `push_lock` is no longer needed.

Tree-SHA512: a461f2ca9e590a9dfcc7814d9852d85f03712cb4735176b8b2db0e8dc731597c2a515650998ca7d53cf5a0c48b408a974a0704897036c6ed74788fc24c5e73ae
PastaPastaPasta pushed a commit to PastaPastaPasta/dash that referenced this pull request Jan 12, 2020
@laanwj @PastaPastaPasta
Merge bitcoin#11432: Remove unused fTry from push_lock
f0b901d 
92848e5 Remove unused fTry from push_lock (João Barbosa)

Pull request description:

  After bitcoin#9674 (618ee92) the `fTry` argument in `push_lock` is no longer needed.

Tree-SHA512: a461f2ca9e590a9dfcc7814d9852d85f03712cb4735176b8b2db0e8dc731597c2a515650998ca7d53cf5a0c48b408a974a0704897036c6ed74788fc24c5e73ae
PastaPastaPasta pushed a commit to PastaPastaPasta/dash that referenced this pull request Jan 12, 2020
@laanwj @PastaPastaPasta
Merge bitcoin#11432: Remove unused fTry from push_lock
46a1ad7 
92848e5 Remove unused fTry from push_lock (João Barbosa)

Pull request description:

  After bitcoin#9674 (618ee92) the `fTry` argument in `push_lock` is no longer needed.

Tree-SHA512: a461f2ca9e590a9dfcc7814d9852d85f03712cb4735176b8b2db0e8dc731597c2a515650998ca7d53cf5a0c48b408a974a0704897036c6ed74788fc24c5e73ae
@str4d str4d mentioned this pull request Apr 12, 2021
Merged
@bitcoin bitcoin locked as resolved and limited conversation to collaborators Sep 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@dcousens dcousens dcousens approved these changes

Assignees
No one assigned
Labels
Refactoring
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@promag @meshcollider @maflcko @fanquake @jnewbery @dcousens @laanwj