Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[depends] mac_alias 2.0.6, ds_store 1.1.2 #11460

Merged
merged 2 commits into from Oct 9, 2017

Conversation

Projects
None yet
3 participants
@fanquake
Copy link
Member

fanquake commented Oct 7, 2017

mac_alias and ds_store have moved from Bitbucket to GitHub.
See https://github.com/al45tair/mac_alias and https://github.com/al45tair/ds_store.

mac_alias has been updated to be compatible with Python 3? ~~~so we should be able to drop our patch.~~~ I've dropped some of the patch for now.

Quickly tested on macOS, because depends building is broken with latest the Xcode see #11461.
Related #8134.

@fanquake fanquake requested a review from theuni Oct 7, 2017

@fanquake fanquake force-pushed the fanquake:update-mac-alias branch Oct 7, 2017

fanquake added some commits Oct 7, 2017

@fanquake fanquake force-pushed the fanquake:update-mac-alias branch to f617d1b Oct 7, 2017

@jonasschnelli

This comment has been minimized.

Copy link
Member

jonasschnelli commented Oct 9, 2017

@theuni

theuni approved these changes Oct 9, 2017

Copy link
Member

theuni left a comment

utACK f617d1b.

@jonasschnelli jonasschnelli merged commit f617d1b into bitcoin:master Oct 9, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

jonasschnelli added a commit that referenced this pull request Oct 9, 2017

Merge #11460: [depends] mac_alias 2.0.6, ds_store 1.1.2
f617d1b [depends] native_ds_store 1.1.2 (fanquake)
46b752a [depends] native_mac_alias 2.0.6 (fanquake)

Pull request description:

  mac_alias and ds_store have moved from Bitbucket to GitHub.
  See https://github.com/al45tair/mac_alias and https://github.com/al45tair/ds_store.

  mac_alias has been updated to be compatible with Python 3? ~~~so we should be able to drop our patch.~~~ I've dropped some of the patch for now.

  Quickly tested on macOS, because depends building is broken with latest the Xcode see #11461.
  Related #8134.

Tree-SHA512: d0017883f86b29bc4ab03bade5aaad9959e4343cd66596805fae48a1804e4bd150c77652f08e3e6cfafb3193f7c0183686f1f60c83f3a4204d40f76041c13ed2

@sickpig sickpig referenced this pull request Jun 5, 2018

Merged

[PORT] Depends cherries #1120

@fanquake fanquake deleted the fanquake:update-mac-alias branch Jun 12, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.