[gui] Add proxy icon in statusbar #11491

mess110 · 2017-10-12T21:24:23Z

Relates to #7734

Please ignore the wrong alpha in the screenshot, I couldn't get the screenshot alpha right :(

I plan to extend this feature in future PRs to include:

custom Tor icon
clickable icon which opens network settings

Old proposals, dropped in favor of current

luke-jr · 2017-10-12T21:30:29Z

Hmm, a fixed icon that is disabled/enabled doesn't extend well to a tri-state when Tor is added. But that can be deferred until adding Tor I guess.

promag

Tested ACK, some comments though.

promag · 2017-10-12T22:26:51Z

src/Makefile.qt.include

@@ -278,6 +278,8 @@ RES_ICONS = \
  qt/res/icons/network_disabled.png \
  qt/res/icons/open.png \
  qt/res/icons/overview.png \
+  qt/res/icons/proxy_enabled.png \


promag · 2017-10-12T22:29:42Z

src/qt/bitcoingui.cpp

+{
+    bool proxyEnabled = false;
+    proxyType proxy;
+    UniValue networks(UniValue::VARR);


Unused, remove?

The #include above too.

promag · 2017-10-12T22:38:45Z

src/qt/bitcoingui.cpp

+        }
+    }
+
+    labelProxyIcon->show();


Already visible? Remove.

promag · 2017-10-12T22:41:23Z

src/qt/bitcoingui.cpp

+
+    labelProxyIcon->show();
+    labelProxyIcon->setPixmap(platformStyle->SingleColorIcon(proxyEnabled ? ":/icons/proxy_enabled" : ":/icons/proxy_disabled").pixmap(STATUSBAR_ICONSIZE,STATUSBAR_ICONSIZE));
+    labelProxyIcon->setToolTip(proxyEnabled ? tr("Proxy is <b>enabled</b>: %1").arg(QString::fromStdString(proxy.proxy.ToStringIPPort())) : tr("Proxy is <b>disabled</b>"));


Why the cosmetic in the tooltips?

Nit: If enabled tooltip = Proxy: %1 else Proxy disabled.

I think the bold helps readability. Can remove if needed.

promag · 2017-10-13T08:41:41Z

src/qt/bitcoingui.cpp

@@ -1084,6 +1092,30 @@ void BitcoinGUI::setEncryptionStatus(int status)
 }
 #endif // ENABLE_WALLET

+void BitcoinGUI::updateProxyIcon()
+{
+    bool proxyEnabled = false;


proxy_enabled.

promag · 2017-10-13T08:42:28Z

src/qt/bitcoingui.cpp

+    proxyType proxy;
+    UniValue networks(UniValue::VARR);
+
+    for(int n=0; n<NET_MAX; ++n)


for (int n = 0; n < NET_MAX; ++n) {

promag · 2017-10-13T08:42:46Z

src/qt/bitcoingui.cpp

+    for(int n=0; n<NET_MAX; ++n)
+    {
+        enum Network network = static_cast<enum Network>(n);
+        if(network == NET_UNROUTABLE || network == NET_INTERNAL)


Space after if. continue in this line.

promag · 2017-10-13T08:43:31Z

src/qt/bitcoingui.cpp

+        if(network == NET_UNROUTABLE || network == NET_INTERNAL)
+            continue;
+        GetProxy(network, proxy);
+        if(proxy.IsValid()) {


Space after if.

promag · 2017-10-13T08:44:46Z

src/qt/bitcoingui.cpp

+    }
+
+    labelProxyIcon->show();
+    labelProxyIcon->setPixmap(platformStyle->SingleColorIcon(proxyEnabled ? ":/icons/proxy_enabled" : ":/icons/proxy_disabled").pixmap(STATUSBAR_ICONSIZE,STATUSBAR_ICONSIZE));


Space after ,.

Nit, split in 2 lines? Or something like:

if (proxy_enabled) { ... } else { ... }

Removed space, prefer it like this for now.

promag · 2017-10-13T08:51:08Z

@luke-jr We can have an icon for each state no?

meshcollider · 2017-10-13T09:16:01Z

I'm unsure, but does this also need a mention in contrib/debian/copyright?

mess110 · 2017-10-13T16:14:57Z

@promag @meshcollider Thanks for the reviews. If you think the remaining nits are very important, I can change them.

promag

Should squash right?

promag · 2017-10-13T16:25:14Z

src/qt/bitcoin.qrc

@@ -53,6 +53,8 @@
        <file alias="hd_enabled">res/icons/hd_enabled.png</file>
        <file alias="hd_disabled">res/icons/hd_disabled.png</file>
        <file alias="network_disabled">res/icons/network_disabled.png</file>
+        <file alias="proxy_enabled">res/icons/proxy_enabled.png</file>


promag · 2017-10-13T18:14:36Z

src/qt/bitcoingui.cpp

+    bool proxy_enabled = false;
+    proxyType proxy;
+
+    for (int n = 0; n < NET_MAX; ++n) {


GetProxy returns IsValid so something like this should work:

for (int n = 0; !proxy_enabled && n < NET_MAX; ++n) { proxy_enabled = GetProxy((Network) n, proxy); }

Nice, I didn't notice GetProxy checks for valid.

promag · 2017-10-13T18:16:11Z

src/qt/bitcoingui.h

@@ -189,6 +190,9 @@ public Q_SLOTS:
    void incomingTransaction(const QString& date, int unit, const CAmount& amount, const QString& type, const QString& address, const QString& label);
 #endif // ENABLE_WALLET

+/** Set the proxy-enabled icon as shown in the UI. */
+void updateProxyIcon();


Missing indentation. No need to be a slot, just a private member.

jonasschnelli · 2017-10-13T22:36:45Z

src/qt/bitcoingui.cpp

+    proxyType proxy;
+
+    for (int n = 0; !proxy_enabled && n < NET_MAX; ++n) {
+        proxy_enabled = GetProxy((Network) n, proxy);


Instead of directly accessing core features, can you wrap that via clientmodel?
There are serval tries to detach the GUI from the rest and those little things will cause a lot of work.

jonasschnelli · 2017-10-13T22:37:23Z

Concept ACK.
Would prefer if we could use an icon from http://s-ings.com/typicons/.

ghost · 2017-10-14T02:54:54Z

First seeing the icon I was confused, meaning was not intuitive for me.
The icon in the screenshot is so small, I hardly could imagine what the downgoing line is.
Icon looked more like a star.
But looking at the bigger icon on https://openclipart.org/detail/190624/load-balancer I could finally see that the icon visualizes "technically" correct.
Since You said that You did several searches and ended up with this, I guess it's OK, the user can learn about the meaning and get used to it.

mess110 · 2017-10-14T17:53:59Z

@wodry guess I wasn't 100% clear. I attempted to construct a proxy icon from 3 copies of https://github.com/bitcoin/bitcoin/blob/master/src/qt/res/icons/debugwindow.png but it was too much to fit in the space and the icon ended up looking too different from the others. So I chose the icon you see because it fits and is public domain

@jonasschnelli I checked the link you provided. Indeed it would be nice to include from the same set, but I couldn't find one that matches. Imo, the current icon is better. However, here are a few long shots:

flow merge
group
pinterest (as in Proxy - lol)
world

jonasschnelli · 2017-10-15T04:17:36Z

Tested a bit:

The icon seems hard to grasp what it is (already mentioned).
IMO the icon should only be visible when proxy is enabled (not faded out, completely invisible)
Clicking on the icon should open settings and showing the network/proxy tab

mess110 · 2017-10-17T18:10:32Z

The new icon is made from 3 device-desktop and 1 rotated chevron from http://s-ings.com/typicons/

After talking with @jonasschnelli, I will do the clickable icon in a different PR.

rebroad · 2017-10-17T18:40:48Z

I think it only makes sense to have this as an icon if the proxy is enableable/disableable from the GUI - otherwise, why? Why not have icons for various things, e.g. bloom filters enabled too then?

promag

@rebroad UI evolve because of these changes, eventually recognising less is more. I also don't appreciate the icon there, but this is for sure something that can be improved. I would only show mutable state information in the status bar, and settings is not state.

IMO icon is unrecognisable in small size. Beside doesn't feel related to proxy at all (personal opinion).

promag · 2017-10-17T21:49:02Z

src/qt/bitcoingui.h

@@ -10,6 +10,7 @@
 #endif

 #include "amount.h"
+#include <univalue.h>


promag · 2017-10-17T21:53:33Z

src/qt/clientmodel.cpp

@@ -336,3 +337,20 @@ void ClientModel::unsubscribeFromCoreSignals()
    uiInterface.NotifyBlockTip.disconnect(boost::bind(BlockTipChanged, this, _1, _2, false));
    uiInterface.NotifyHeaderTip.disconnect(boost::bind(BlockTipChanged, this, _1, _2, true));
 }
+
+UniValue ClientModel::getProxyInfo() const


Suggestion to remove UniValue dependency:

bool ClientModel::GetProxyInfo(std::string& ip_port) const { for (int n = 0; n < NET_MAX; ++n) { proxyType proxy; if (GetProxy((Network) n, proxy)) { ip_port = proxy.proxy.ToStringIPPort(); return true; } } return false; }

Haven't tested.

I can not see how the new icon relates to proxy. Instead of showing "something with computer and cable", maybe simply show a "P" ?

promag

IMO the icon could be improved. Not sure if it should be visible only when the proxy is enabled.

Edit: Feels better without the disabled proxy icon.

promag · 2017-10-25T15:18:12Z

src/qt/bitcoingui.cpp

+
+        labelProxyIcon->setPixmap(platformStyle->SingleColorIcon(":/icons/proxy").pixmap(STATUSBAR_ICONSIZE, STATUSBAR_ICONSIZE));
+        labelProxyIcon->setToolTip(tr("Proxy is <b>enabled</b>: %1").arg(ip_port_q));
+        labelProxyIcon->setEnabled(proxy_enabled);


Remove as it is already enabled?

promag · 2017-10-25T15:18:56Z

src/qt/bitcoingui.cpp

+    if (proxy_enabled) {
+        QString ip_port_q = QString::fromStdString(ip_port);
+
+        labelProxyIcon->setPixmap(platformStyle->SingleColorIcon(":/icons/proxy").pixmap(STATUSBAR_ICONSIZE, STATUSBAR_ICONSIZE));


If idea is to show/hide then the pixmap can be set when the label is created.

In the future, I plan to support a Tor icon, so I prefer to do this here

Even in that case it can't change in runtime right?

Although toggling proxy requires a restart, I prefer it if the UI doesn't assume that (to prevent a regression later). Not a show-stopper perse, but this code could confuse people.

Suggestion: add an if statement that checks if the icon has already been drawn. If so, call show().

promag · 2017-10-25T15:20:15Z

src/qt/clientmodel.cpp

@@ -336,3 +337,15 @@ void ClientModel::unsubscribeFromCoreSignals()
    uiInterface.NotifyBlockTip.disconnect(boost::bind(BlockTipChanged, this, _1, _2, false));
    uiInterface.NotifyHeaderTip.disconnect(boost::bind(BlockTipChanged, this, _1, _2, true));
 }
+
+bool ClientModel::getProxyInfo(std::string& ip_port) const


Nit, some may prefer std::pair<bool, std::string> ClientModel::getProxyInfo() const;, both work for me.

Gonna go with what is currently implemented

mess110 · 2017-10-25T16:39:23Z

@promag yea, I agree, the icon needs improving. Will come up with something better

Sjors · 2017-11-09T11:49:36Z

The icons at the bottom are already quite confusing. Some allow the user to take action (e.g. BTC), another does not allow action and never chances (HD). The network icon allows the user to take action, but unlike the BTC icon doesn't first show a dropdown menu, but instead disables your network without warning.

Instead of adding another icon, I suggest turning the connection icon into something that opens a dialog, where you inspect and change network settings (including disconnecting, using a proxy or tor). The shape or color of the icon could give a hint as to the current state (e.g. green for Tor), but once the user clicks on it they would get the full information. That way the icon doesn't need to be perfect.

luke-jr · 2017-11-10T14:58:00Z

I wonder if a small "P" (and later "T" for Tor) in the connection icon would do the trick...

mess110 · 2017-11-11T10:50:15Z

I updated the proposal to use an icon form http://s-ings.com/typicons/ as @jonasschnelli suggested (decided to try this instead of creating an svg with P in it - curious about feedback). The set also contains a t icon for future Tor PR.

@Sjors yea, the icons can be a bit confusing. This is why in the first version of this PR, I created proxy enabled/disabled similar to how the network icon behaves. However, each icon has slightly different behavior and needs. I think the security benefit of seeing the proxy icon is worth it though.

ryanofsky

utACK 35d50aa833cea53f9c6195987256351f4b1c710a

ryanofsky · 2018-05-15T18:43:02Z

src/qt/clientmodel.cpp

+bool ClientModel::getProxyInfo(std::string& ip_port) const
+{
+    proxyType ipv4, ipv6;
+    if (GetProxy((Network) 1, ipv4) && GetProxy((Network) 2, ipv6)) {


Could call m_node.getProxy() here and drop netbase.h include above. This would be a little more future-proof with #10102.

netbase.h is still needed for proxyType, but I can change to m_node.getProxy

promag

utACK 35d50aa.

I have a couple of nits for you to consider or feel free to ignore them and keep the above ACKs.

promag · 2018-05-15T19:24:03Z

contrib/debian/copyright

       src/qt/res/icons/tx_in*.png
+       src/qt/res/icons/verify.png


nit, unrelated change. If you happen to push again consider removing this change.

promag · 2018-05-15T19:25:24Z

src/qt/bitcoingui.cpp

@@ -83,6 +83,7 @@ BitcoinGUI::BitcoinGUI(interfaces::Node& node, const PlatformStyle *_platformSty
    unitDisplayControl(0),
    labelWalletEncryptionIcon(0),
    labelWalletHDStatusIcon(0),
+    labelProxyIcon(0),


nit, could be initialized in the declaration as per developer notes.

promag · 2018-05-15T19:28:56Z

src/qt/bitcoingui.cpp

+    if (proxy_enabled) {
+        QString ip_port_q = QString::fromStdString(ip_port);
+
+        if (labelProxyIcon->pixmap() == 0) {


nit, IMO the label pixmap could be initialized when the label is created above.

This is consistent with labelWalletHDStatusIcon, so I will prefer the approach taken

promag · 2018-05-15T19:29:05Z

src/qt/bitcoingui.cpp

+    bool proxy_enabled = clientModel->getProxyInfo(ip_port);
+
+    if (proxy_enabled) {
+        QString ip_port_q = QString::fromStdString(ip_port);


nit, could inline this below.

mess110 · 2018-05-15T20:23:07Z

Thanks for the reviews.

I inlined the string creation and using m_node.getProxy

jonasschnelli · 2018-05-16T08:07:23Z

Tested ACK 73cd5b2
https://bitcoin.jonasschnelli.ch/build/611

73cd5b2 [gui] Add proxy icon in statusbar (Cristian Mircea Messel) Pull request description: Relates to #7734 ![image](https://user-images.githubusercontent.com/226170/33406640-8ea700c6-d576-11e7-9d69-fde9a696c219.png) Please ignore the wrong alpha in the screenshot, I couldn't get the screenshot alpha right :( I plan to extend this feature in future PRs to include: - custom Tor icon - clickable icon which opens network settings Old proposals, dropped in favor of current ![image](https://user-images.githubusercontent.com/226170/32688635-979ef690-c6dd-11e7-8869-49da7e0f0a11.png) ![proxy_preview](https://user-images.githubusercontent.com/226170/31521305-99c43f22-afb1-11e7-9daf-d1ed6347daa8.png) ![image](https://user-images.githubusercontent.com/226170/31680585-72706098-b37d-11e7-88ad-028c4c723f42.png) Tree-SHA512: e5f18c20c0be292256a3e78c91cdf390a3b6084346a192a8170460f706f5b6cd198ba5b0035798a85a442fe7f262cf1c2350064670085ff8f473f880ab5ba589

6d5fcad [gui] Make proxy icon from statusbar clickable (Cristian Mircea Messel) Pull request description: Clicking on the proxy icon will open settings showing the network tab #11491 (comment) Tree-SHA512: c3549749296918818694a371326d1a3b1075478918aaee940b5c7119a7e2cb991dcfda78f20d44d6d001157b9b82951f0d5157b17f4f0d1a0a242795efade036

Summary: 73cd5b25b [gui] Add proxy icon in statusbar (Cristian Mircea Messel) Pull request description: Relates to #7734 ![image](https://user-images.githubusercontent.com/226170/33406640-8ea700c6-d576-11e7-9d69-fde9a696c219.png) Please ignore the wrong alpha in the screenshot, I couldn't get the screenshot alpha right :( I plan to extend this feature in future PRs to include: - custom Tor icon - clickable icon which opens network settings Old proposals, dropped in favor of current ![image](https://user-images.githubusercontent.com/226170/32688635-979ef690-c6dd-11e7-8869-49da7e0f0a11.png) ![proxy_preview](https://user-images.githubusercontent.com/226170/31521305-99c43f22-afb1-11e7-9daf-d1ed6347daa8.png) ![image](https://user-images.githubusercontent.com/226170/31680585-72706098-b37d-11e7-88ad-028c4c723f42.png) Tree-SHA512: e5f18c20c0be292256a3e78c91cdf390a3b6084346a192a8170460f706f5b6cd198ba5b0035798a85a442fe7f262cf1c2350064670085ff8f473f880ab5ba589 Backport of Core PR11491 bitcoin/bitcoin#11491 Test Plan: make check bitcoin-qt -proxy=<valid proxy> However cursor over the `P` symbol in the bottom right corner until small window detailing proxy information appears. {F4078608} bitcoin-qt The `P` symbol should not appear because no proxy is being used. {F4078606} Reviewers: O1 Bitcoin ABC, #bitcoin_abc, deadalnix, Fabien, jasonbcox Reviewed By: O1 Bitcoin ABC, #bitcoin_abc, deadalnix Differential Revision: https://reviews.bitcoinabc.org/D4269

Summary: 6d5fcad576962e5950641f7e7b113a6ac6f397e5 [gui] Make proxy icon from statusbar clickable (Cristian Mircea Messel) Pull request description: Clicking on the proxy icon will open settings showing the network tab bitcoin/bitcoin#11491 (comment) Tree-SHA512: c3549749296918818694a371326d1a3b1075478918aaee940b5c7119a7e2cb991dcfda78f20d44d6d001157b9b82951f0d5157b17f4f0d1a0a242795efade036 Backport of Core PR13248 bitcoin/bitcoin#13248 Depends on D4269 Test Plan: make check ./bitcoin-qt -proxy=<valid proxy> Clicking the `P` icon in the bottom right corner should open up the `network` tab in the `options` menu. Reviewers: deadalnix, Fabien, jasonbcox, O1 Bitcoin ABC, #bitcoin_abc Reviewed By: deadalnix, Fabien, O1 Bitcoin ABC, #bitcoin_abc Differential Revision: https://reviews.bitcoinabc.org/D4270

73cd5b2 [gui] Add proxy icon in statusbar (Cristian Mircea Messel) Pull request description: Relates to bitcoin#7734 ![image](https://user-images.githubusercontent.com/226170/33406640-8ea700c6-d576-11e7-9d69-fde9a696c219.png) Please ignore the wrong alpha in the screenshot, I couldn't get the screenshot alpha right :( I plan to extend this feature in future PRs to include: - custom Tor icon - clickable icon which opens network settings Old proposals, dropped in favor of current ![image](https://user-images.githubusercontent.com/226170/32688635-979ef690-c6dd-11e7-8869-49da7e0f0a11.png) ![proxy_preview](https://user-images.githubusercontent.com/226170/31521305-99c43f22-afb1-11e7-9daf-d1ed6347daa8.png) ![image](https://user-images.githubusercontent.com/226170/31680585-72706098-b37d-11e7-88ad-028c4c723f42.png) Tree-SHA512: e5f18c20c0be292256a3e78c91cdf390a3b6084346a192a8170460f706f5b6cd198ba5b0035798a85a442fe7f262cf1c2350064670085ff8f473f880ab5ba589

6d5fcad [gui] Make proxy icon from statusbar clickable (Cristian Mircea Messel) Pull request description: Clicking on the proxy icon will open settings showing the network tab bitcoin#11491 (comment) Tree-SHA512: c3549749296918818694a371326d1a3b1075478918aaee940b5c7119a7e2cb991dcfda78f20d44d6d001157b9b82951f0d5157b17f4f0d1a0a242795efade036 # Conflicts: # src/qt/bitcoingui.cpp # src/qt/bitcoingui.h

73cd5b2 [gui] Add proxy icon in statusbar (Cristian Mircea Messel) Pull request description: Relates to bitcoin#7734 ![image](https://user-images.githubusercontent.com/226170/33406640-8ea700c6-d576-11e7-9d69-fde9a696c219.png) Please ignore the wrong alpha in the screenshot, I couldn't get the screenshot alpha right :( I plan to extend this feature in future PRs to include: - custom Tor icon - clickable icon which opens network settings Old proposals, dropped in favor of current ![image](https://user-images.githubusercontent.com/226170/32688635-979ef690-c6dd-11e7-8869-49da7e0f0a11.png) ![proxy_preview](https://user-images.githubusercontent.com/226170/31521305-99c43f22-afb1-11e7-9daf-d1ed6347daa8.png) ![image](https://user-images.githubusercontent.com/226170/31680585-72706098-b37d-11e7-88ad-028c4c723f42.png) Tree-SHA512: e5f18c20c0be292256a3e78c91cdf390a3b6084346a192a8170460f706f5b6cd198ba5b0035798a85a442fe7f262cf1c2350064670085ff8f473f880ab5ba589

6d5fcad [gui] Make proxy icon from statusbar clickable (Cristian Mircea Messel) Pull request description: Clicking on the proxy icon will open settings showing the network tab bitcoin#11491 (comment) Tree-SHA512: c3549749296918818694a371326d1a3b1075478918aaee940b5c7119a7e2cb991dcfda78f20d44d6d001157b9b82951f0d5157b17f4f0d1a0a242795efade036

fanquake added the GUI label Oct 12, 2017

promag reviewed Oct 13, 2017

View reviewed changes

mess110 force-pushed the add_proxy_icon branch from 597cd7b to 20b3979 Compare October 13, 2017 16:12

promag reviewed Oct 13, 2017

View reviewed changes

mess110 force-pushed the add_proxy_icon branch 2 times, most recently from 096a756 to 8767cbb Compare October 13, 2017 20:34

jonasschnelli reviewed Oct 13, 2017

View reviewed changes

mess110 force-pushed the add_proxy_icon branch from 8767cbb to af937dd Compare October 14, 2017 17:43

mess110 force-pushed the add_proxy_icon branch from af937dd to 4fceed5 Compare October 17, 2017 18:10

mess110 force-pushed the add_proxy_icon branch 2 times, most recently from df0c4da to 15e1282 Compare October 17, 2017 18:16

promag reviewed Oct 17, 2017

View reviewed changes

mess110 force-pushed the add_proxy_icon branch from 15e1282 to 19e68f7 Compare October 24, 2017 16:44

promag reviewed Oct 25, 2017

View reviewed changes

mess110 force-pushed the add_proxy_icon branch from 19e68f7 to 44e1092 Compare October 25, 2017 16:38

mess110 force-pushed the add_proxy_icon branch from 44e1092 to 99fdf7b Compare November 11, 2017 10:44

ryanofsky reviewed May 15, 2018

View reviewed changes

promag reviewed May 15, 2018

View reviewed changes

mess110 force-pushed the add_proxy_icon branch from 35d50aa to f1c56cb Compare May 15, 2018 20:21

[gui] Add proxy icon in statusbar

73cd5b2

mess110 force-pushed the add_proxy_icon branch from f1c56cb to 73cd5b2 Compare May 15, 2018 21:25

jonasschnelli merged commit 73cd5b2 into bitcoin:master May 16, 2018

mess110 deleted the add_proxy_icon branch May 16, 2018 14:22

mess110 mentioned this pull request May 16, 2018

[gui] Make proxy icon from statusbar clickable #13248

Merged

Bushstar mentioned this pull request May 18, 2018

commits from bitcoin/master FeatherCoin/Feathercoin#333

Merged

bitcoin locked as resolved and limited conversation to collaborators Sep 8, 2021

[gui] Add proxy icon in statusbar #11491

[gui] Add proxy icon in statusbar #11491

Conversation

mess110 commented Oct 12, 2017 • edited

luke-jr commented Oct 12, 2017

promag left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

promag Oct 12, 2017 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

promag commented Oct 13, 2017

meshcollider commented Oct 13, 2017

mess110 commented Oct 13, 2017

promag left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jonasschnelli commented Oct 13, 2017

ghost commented Oct 14, 2017

mess110 commented Oct 14, 2017 • edited

jonasschnelli commented Oct 15, 2017

mess110 commented Oct 17, 2017 • edited

rebroad commented Oct 17, 2017

promag left a comment • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

promag left a comment • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

mess110 commented Oct 25, 2017

Sjors commented Nov 9, 2017

luke-jr commented Nov 10, 2017

mess110 commented Nov 11, 2017

ryanofsky left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

promag left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

mess110 commented May 15, 2018

jonasschnelli commented May 16, 2018 • edited

mess110 commented Oct 12, 2017 •

edited

promag Oct 12, 2017 •

edited

mess110 commented Oct 14, 2017 •

edited

mess110 commented Oct 17, 2017 •

edited

promag left a comment •

edited

promag left a comment •

edited

jonasschnelli commented May 16, 2018 •

edited