Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[trivial] [tests] A few Python3 tidy ups #11513

Merged
merged 4 commits into from Oct 17, 2017
Merged

[trivial] [tests] A few Python3 tidy ups #11513

merged 4 commits into from Oct 17, 2017

Conversation

jnewbery
Copy link
Contributor

A few trivial tidyups in the test_framework:

  • the test_framework can only be run in Python3, so remove the py2/3 compatibility workarounds in authproxy.py
  • while there, do some general tidying up of the module - fix flake8 warnings, make initialization code more compact
  • All classes in Python3 are new-style. No need to explicitly inherit from object.

@fanquake fanquake added the Tests label Oct 17, 2017
@meshcollider
Copy link
Contributor

utACK f893085

@practicalswift
Copy link
Contributor

Concept ACK - very nice cleanup!

@mess110
Copy link
Contributor

mess110 commented Oct 17, 2017

utACK f893085

@maflcko maflcko merged commit f893085 into bitcoin:master Oct 17, 2017
maflcko pushed a commit that referenced this pull request Oct 17, 2017
Merge #11513: [trivial] [tests] A few Python3 tidy ups
14b860b 
f893085 [tests] Don't subclass from object for Python 3 (John Newbery)
8f9e362 [tests] authproxy.py: tidy up __init__() (John Newbery)
323d8f6 [tests] fix flake8 warnings in authproxy.py (John Newbery)
fc0176d [tests] use python3 for authproxy.py (John Newbery)

Pull request description:

  A few trivial tidyups in the test_framework:

  - the test_framework can only be run in Python3, so remove the py2/3 compatibility workarounds in authproxy.py
  - while there, do some general tidying up of the module - fix flake8 warnings, make initialization code more compact
  - All classes in Python3 are new-style. No need to explicitly inherit from `object`.

Tree-SHA512: d15c93aa4b47c1ad7d05baa7a564053cf0294932e178c95ef335380113f42e1af314978d07d3b107292a8e3496fd840535b5571a9164182feaa062a1e9ff8b73
@jnewbery jnewbery deleted the authproxy_tidyups branch October 17, 2017 19:33
PastaPastaPasta pushed a commit to PastaPastaPasta/dash that referenced this pull request Dec 22, 2019
@PastaPastaPasta
Merge bitcoin#11513: [trivial] [tests] A few Python3 tidy ups
12a8fb7 
f893085 [tests] Don't subclass from object for Python 3 (John Newbery)
8f9e362 [tests] authproxy.py: tidy up __init__() (John Newbery)
323d8f6 [tests] fix flake8 warnings in authproxy.py (John Newbery)
fc0176d [tests] use python3 for authproxy.py (John Newbery)

Pull request description:

  A few trivial tidyups in the test_framework:

  - the test_framework can only be run in Python3, so remove the py2/3 compatibility workarounds in authproxy.py
  - while there, do some general tidying up of the module - fix flake8 warnings, make initialization code more compact
  - All classes in Python3 are new-style. No need to explicitly inherit from `object`.

Tree-SHA512: d15c93aa4b47c1ad7d05baa7a564053cf0294932e178c95ef335380113f42e1af314978d07d3b107292a8e3496fd840535b5571a9164182feaa062a1e9ff8b73
PastaPastaPasta pushed a commit to PastaPastaPasta/dash that referenced this pull request Jan 2, 2020
@PastaPastaPasta
Merge bitcoin#11513: [trivial] [tests] A few Python3 tidy ups
e7248bb 
f893085 [tests] Don't subclass from object for Python 3 (John Newbery)
8f9e362 [tests] authproxy.py: tidy up __init__() (John Newbery)
323d8f6 [tests] fix flake8 warnings in authproxy.py (John Newbery)
fc0176d [tests] use python3 for authproxy.py (John Newbery)

Pull request description:

  A few trivial tidyups in the test_framework:

  - the test_framework can only be run in Python3, so remove the py2/3 compatibility workarounds in authproxy.py
  - while there, do some general tidying up of the module - fix flake8 warnings, make initialization code more compact
  - All classes in Python3 are new-style. No need to explicitly inherit from `object`.

Tree-SHA512: d15c93aa4b47c1ad7d05baa7a564053cf0294932e178c95ef335380113f42e1af314978d07d3b107292a8e3496fd840535b5571a9164182feaa062a1e9ff8b73
PastaPastaPasta pushed a commit to PastaPastaPasta/dash that referenced this pull request Jan 4, 2020
@PastaPastaPasta
Merge bitcoin#11513: [trivial] [tests] A few Python3 tidy ups
c335685 
f893085 [tests] Don't subclass from object for Python 3 (John Newbery)
8f9e362 [tests] authproxy.py: tidy up __init__() (John Newbery)
323d8f6 [tests] fix flake8 warnings in authproxy.py (John Newbery)
fc0176d [tests] use python3 for authproxy.py (John Newbery)

Pull request description:

  A few trivial tidyups in the test_framework:

  - the test_framework can only be run in Python3, so remove the py2/3 compatibility workarounds in authproxy.py
  - while there, do some general tidying up of the module - fix flake8 warnings, make initialization code more compact
  - All classes in Python3 are new-style. No need to explicitly inherit from `object`.

Tree-SHA512: d15c93aa4b47c1ad7d05baa7a564053cf0294932e178c95ef335380113f42e1af314978d07d3b107292a8e3496fd840535b5571a9164182feaa062a1e9ff8b73
PastaPastaPasta pushed a commit to PastaPastaPasta/dash that referenced this pull request Jan 12, 2020
@PastaPastaPasta
Merge bitcoin#11513: [trivial] [tests] A few Python3 tidy ups
403b27d 
f893085 [tests] Don't subclass from object for Python 3 (John Newbery)
8f9e362 [tests] authproxy.py: tidy up __init__() (John Newbery)
323d8f6 [tests] fix flake8 warnings in authproxy.py (John Newbery)
fc0176d [tests] use python3 for authproxy.py (John Newbery)

Pull request description:

  A few trivial tidyups in the test_framework:

  - the test_framework can only be run in Python3, so remove the py2/3 compatibility workarounds in authproxy.py
  - while there, do some general tidying up of the module - fix flake8 warnings, make initialization code more compact
  - All classes in Python3 are new-style. No need to explicitly inherit from `object`.

Tree-SHA512: d15c93aa4b47c1ad7d05baa7a564053cf0294932e178c95ef335380113f42e1af314978d07d3b107292a8e3496fd840535b5571a9164182feaa062a1e9ff8b73
PastaPastaPasta pushed a commit to PastaPastaPasta/dash that referenced this pull request Jan 12, 2020
@PastaPastaPasta
Merge bitcoin#11513: [trivial] [tests] A few Python3 tidy ups
3b98205 
f893085 [tests] Don't subclass from object for Python 3 (John Newbery)
8f9e362 [tests] authproxy.py: tidy up __init__() (John Newbery)
323d8f6 [tests] fix flake8 warnings in authproxy.py (John Newbery)
fc0176d [tests] use python3 for authproxy.py (John Newbery)

Pull request description:

  A few trivial tidyups in the test_framework:

  - the test_framework can only be run in Python3, so remove the py2/3 compatibility workarounds in authproxy.py
  - while there, do some general tidying up of the module - fix flake8 warnings, make initialization code more compact
  - All classes in Python3 are new-style. No need to explicitly inherit from `object`.

Tree-SHA512: d15c93aa4b47c1ad7d05baa7a564053cf0294932e178c95ef335380113f42e1af314978d07d3b107292a8e3496fd840535b5571a9164182feaa062a1e9ff8b73
PastaPastaPasta pushed a commit to PastaPastaPasta/dash that referenced this pull request Jan 12, 2020
@PastaPastaPasta
Merge bitcoin#11513: [trivial] [tests] A few Python3 tidy ups
3cdb8c6 
f893085 [tests] Don't subclass from object for Python 3 (John Newbery)
8f9e362 [tests] authproxy.py: tidy up __init__() (John Newbery)
323d8f6 [tests] fix flake8 warnings in authproxy.py (John Newbery)
fc0176d [tests] use python3 for authproxy.py (John Newbery)

Pull request description:

  A few trivial tidyups in the test_framework:

  - the test_framework can only be run in Python3, so remove the py2/3 compatibility workarounds in authproxy.py
  - while there, do some general tidying up of the module - fix flake8 warnings, make initialization code more compact
  - All classes in Python3 are new-style. No need to explicitly inherit from `object`.

Tree-SHA512: d15c93aa4b47c1ad7d05baa7a564053cf0294932e178c95ef335380113f42e1af314978d07d3b107292a8e3496fd840535b5571a9164182feaa062a1e9ff8b73
PastaPastaPasta pushed a commit to PastaPastaPasta/dash that referenced this pull request Jan 12, 2020
@PastaPastaPasta
Merge bitcoin#11513: [trivial] [tests] A few Python3 tidy ups
8d30fbd 
f893085 [tests] Don't subclass from object for Python 3 (John Newbery)
8f9e362 [tests] authproxy.py: tidy up __init__() (John Newbery)
323d8f6 [tests] fix flake8 warnings in authproxy.py (John Newbery)
fc0176d [tests] use python3 for authproxy.py (John Newbery)

Pull request description:

  A few trivial tidyups in the test_framework:

  - the test_framework can only be run in Python3, so remove the py2/3 compatibility workarounds in authproxy.py
  - while there, do some general tidying up of the module - fix flake8 warnings, make initialization code more compact
  - All classes in Python3 are new-style. No need to explicitly inherit from `object`.

Tree-SHA512: d15c93aa4b47c1ad7d05baa7a564053cf0294932e178c95ef335380113f42e1af314978d07d3b107292a8e3496fd840535b5571a9164182feaa062a1e9ff8b73
PastaPastaPasta pushed a commit to PastaPastaPasta/dash that referenced this pull request Jan 12, 2020
@PastaPastaPasta
Merge bitcoin#11513: [trivial] [tests] A few Python3 tidy ups
dd39b5f 
f893085 [tests] Don't subclass from object for Python 3 (John Newbery)
8f9e362 [tests] authproxy.py: tidy up __init__() (John Newbery)
323d8f6 [tests] fix flake8 warnings in authproxy.py (John Newbery)
fc0176d [tests] use python3 for authproxy.py (John Newbery)

Pull request description:

  A few trivial tidyups in the test_framework:

  - the test_framework can only be run in Python3, so remove the py2/3 compatibility workarounds in authproxy.py
  - while there, do some general tidying up of the module - fix flake8 warnings, make initialization code more compact
  - All classes in Python3 are new-style. No need to explicitly inherit from `object`.

Tree-SHA512: d15c93aa4b47c1ad7d05baa7a564053cf0294932e178c95ef335380113f42e1af314978d07d3b107292a8e3496fd840535b5571a9164182feaa062a1e9ff8b73
PastaPastaPasta pushed a commit to PastaPastaPasta/dash that referenced this pull request Jan 12, 2020
@PastaPastaPasta
Merge bitcoin#11513: [trivial] [tests] A few Python3 tidy ups
8f62247 
f893085 [tests] Don't subclass from object for Python 3 (John Newbery)
8f9e362 [tests] authproxy.py: tidy up __init__() (John Newbery)
323d8f6 [tests] fix flake8 warnings in authproxy.py (John Newbery)
fc0176d [tests] use python3 for authproxy.py (John Newbery)

Pull request description:

  A few trivial tidyups in the test_framework:

  - the test_framework can only be run in Python3, so remove the py2/3 compatibility workarounds in authproxy.py
  - while there, do some general tidying up of the module - fix flake8 warnings, make initialization code more compact
  - All classes in Python3 are new-style. No need to explicitly inherit from `object`.

Tree-SHA512: d15c93aa4b47c1ad7d05baa7a564053cf0294932e178c95ef335380113f42e1af314978d07d3b107292a8e3496fd840535b5571a9164182feaa062a1e9ff8b73
PastaPastaPasta pushed a commit to PastaPastaPasta/dash that referenced this pull request Feb 13, 2020
@PastaPastaPasta
Merge bitcoin#11513: [trivial] [tests] A few Python3 tidy ups
cd1af7a 
f893085 [tests] Don't subclass from object for Python 3 (John Newbery)
8f9e362 [tests] authproxy.py: tidy up __init__() (John Newbery)
323d8f6 [tests] fix flake8 warnings in authproxy.py (John Newbery)
fc0176d [tests] use python3 for authproxy.py (John Newbery)

Pull request description:

  A few trivial tidyups in the test_framework:

  - the test_framework can only be run in Python3, so remove the py2/3 compatibility workarounds in authproxy.py
  - while there, do some general tidying up of the module - fix flake8 warnings, make initialization code more compact
  - All classes in Python3 are new-style. No need to explicitly inherit from `object`.

Tree-SHA512: d15c93aa4b47c1ad7d05baa7a564053cf0294932e178c95ef335380113f42e1af314978d07d3b107292a8e3496fd840535b5571a9164182feaa062a1e9ff8b73
PastaPastaPasta pushed a commit to PastaPastaPasta/dash that referenced this pull request Feb 13, 2020
@PastaPastaPasta
Merge bitcoin#11513: [trivial] [tests] A few Python3 tidy ups
3d867eb 
f893085 [tests] Don't subclass from object for Python 3 (John Newbery)
8f9e362 [tests] authproxy.py: tidy up __init__() (John Newbery)
323d8f6 [tests] fix flake8 warnings in authproxy.py (John Newbery)
fc0176d [tests] use python3 for authproxy.py (John Newbery)

Pull request description:

  A few trivial tidyups in the test_framework:

  - the test_framework can only be run in Python3, so remove the py2/3 compatibility workarounds in authproxy.py
  - while there, do some general tidying up of the module - fix flake8 warnings, make initialization code more compact
  - All classes in Python3 are new-style. No need to explicitly inherit from `object`.

Tree-SHA512: d15c93aa4b47c1ad7d05baa7a564053cf0294932e178c95ef335380113f42e1af314978d07d3b107292a8e3496fd840535b5571a9164182feaa062a1e9ff8b73

fix up mininode.py slightly

Signed-off-by: Pasta <pasta@dashboost.org>
PastaPastaPasta pushed a commit to PastaPastaPasta/dash that referenced this pull request Feb 13, 2020
@PastaPastaPasta
Merge bitcoin#11513: [trivial] [tests] A few Python3 tidy ups
6fcb43f 
f893085 [tests] Don't subclass from object for Python 3 (John Newbery)
8f9e362 [tests] authproxy.py: tidy up __init__() (John Newbery)
323d8f6 [tests] fix flake8 warnings in authproxy.py (John Newbery)
fc0176d [tests] use python3 for authproxy.py (John Newbery)

Pull request description:

  A few trivial tidyups in the test_framework:

  - the test_framework can only be run in Python3, so remove the py2/3 compatibility workarounds in authproxy.py
  - while there, do some general tidying up of the module - fix flake8 warnings, make initialization code more compact
  - All classes in Python3 are new-style. No need to explicitly inherit from `object`.

Tree-SHA512: d15c93aa4b47c1ad7d05baa7a564053cf0294932e178c95ef335380113f42e1af314978d07d3b107292a8e3496fd840535b5571a9164182feaa062a1e9ff8b73

fix up mininode.py slightly

Signed-off-by: Pasta <pasta@dashboost.org>
PastaPastaPasta pushed a commit to PastaPastaPasta/dash that referenced this pull request Feb 29, 2020
@PastaPastaPasta
Merge bitcoin#11513: [trivial] [tests] A few Python3 tidy ups
08171fb 
f893085 [tests] Don't subclass from object for Python 3 (John Newbery)
8f9e362 [tests] authproxy.py: tidy up __init__() (John Newbery)
323d8f6 [tests] fix flake8 warnings in authproxy.py (John Newbery)
fc0176d [tests] use python3 for authproxy.py (John Newbery)

Pull request description:

  A few trivial tidyups in the test_framework:

  - the test_framework can only be run in Python3, so remove the py2/3 compatibility workarounds in authproxy.py
  - while there, do some general tidying up of the module - fix flake8 warnings, make initialization code more compact
  - All classes in Python3 are new-style. No need to explicitly inherit from `object`.

Tree-SHA512: d15c93aa4b47c1ad7d05baa7a564053cf0294932e178c95ef335380113f42e1af314978d07d3b107292a8e3496fd840535b5571a9164182feaa062a1e9ff8b73

fix up mininode.py slightly

Signed-off-by: Pasta <pasta@dashboost.org>
gades pushed a commit to cosanta/cosanta-core that referenced this pull request Jun 30, 2021
@gades
Merge bitcoin#11513: [trivial] [tests] A few Python3 tidy ups
a2d10de 
f893085 [tests] Don't subclass from object for Python 3 (John Newbery)
8f9e362 [tests] authproxy.py: tidy up __init__() (John Newbery)
323d8f6 [tests] fix flake8 warnings in authproxy.py (John Newbery)
fc0176d [tests] use python3 for authproxy.py (John Newbery)

Pull request description:

  A few trivial tidyups in the test_framework:

  - the test_framework can only be run in Python3, so remove the py2/3 compatibility workarounds in authproxy.py
  - while there, do some general tidying up of the module - fix flake8 warnings, make initialization code more compact
  - All classes in Python3 are new-style. No need to explicitly inherit from `object`.

Tree-SHA512: d15c93aa4b47c1ad7d05baa7a564053cf0294932e178c95ef335380113f42e1af314978d07d3b107292a8e3496fd840535b5571a9164182feaa062a1e9ff8b73

fix up mininode.py slightly

Signed-off-by: Pasta <pasta@dashboost.org>
@bitcoin bitcoin locked as resolved and limited conversation to collaborators Sep 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
Tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@jnewbery @meshcollider @practicalswift @mess110 @fanquake @maflcko