Iterate and remove nodes without container copy #11514
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
promag
force-pushed
the
201710-node-iterate-and-erase
branch
from
a13f208
to
2964710
Compare
laanwj
reviewed
Oct 18, 2017
| } | ||
| it++; |
There was a problem hiding this comment.
Nit: ++it? (make no code difference probably, but I think it's good practice, and avoids later patches changing it around)
|
This code goes away with #11227, which is in the process of being PR'd in batches. I have no objection to improvements here, but I'd prefer to avoid making changes that will only cause conflicts with deleted code. |
Good point, the review time is better spent elsewhere then. |
|
In that case. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes the need for
vNodesCopyandvNodesDisconnectedCopy.