Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: Update WSL installation notes for Fall Creators update #11533

Merged
merged 1 commit into from Nov 14, 2017
Merged

Docs: Update WSL installation notes for Fall Creators update #11533

merged 1 commit into from Nov 14, 2017

Conversation

Thoragh
Copy link
Contributor

@Thoragh Thoragh commented Oct 20, 2017

Fall Creators update (RS3) was released 17 October and it has made some changes to the installation of WSL (no longer requires Developer Mode, out of beta and Ubuntu has to be installed from the Store).

@Thoragh Thoragh changed the title Docs: Update WSL installation for Fall Creators update Docs: Update WSL installation notes for Fall Creators update Oct 23, 2017
@laanwj
Copy link
Member

laanwj commented Oct 26, 2017

Concept ACK

@laanwj
Copy link
Member

laanwj commented Nov 9, 2017

I'd like to see confirmation that at least one other person tested this before merging.

@maflcko
Copy link
Member

maflcko commented Nov 9, 2017

Concept ACK a4f171de5a44253394cb739586b04e2429f7f84d. Agree with @laanwj

@mikedennis
Copy link

I just went through this and did my own pull when I was pointed to the fact this one already exists. I'm not sure you need much additional doc around this at all. It's basically just install WSL and then follow linux instructions for whatever distro you install in the WSL. Worked great for me whereas I was unable to get it to work with the previous beta WSL.

@laanwj
Copy link
Member

laanwj commented Nov 13, 2017

It's basically just install WSL and then follow linux instructions for whatever distro you install in the WSL.

With the exception that you're cross compiling for Windows. If you miss that part, you get issues like #11633. That's why separate instructions exist.

@laanwj
Copy link
Member

laanwj commented Nov 13, 2017

@mikedennis So can you ACK the changes here, then this can be merged.

@laanwj
Copy link
Member

laanwj commented Nov 13, 2017

This is conflicting after #11438, needs rebase if there are still relevant changes after that.

@mikedennis
Copy link

I'm having problems with cross compilation. To start with if you follow these procedures you end up with Ubuntu Xenial 16.04 which this doc states is not a good choice for cross compilation.

I proceeded and ran into a problem with this step building in depends:
make HOST=x86_64-w64-mingw32

I get an error warning about automake-1.14 is missing on my system. I checked and I have 1.15-4ubuntu1 installed. I suspect I need to follow the workarounds in #8732

I recommend putting a note in the docs that this procedure installs Ubuntu Xenial 16.04 and to see #8732 if you want to cross compile.

You can also install openSUSE Leap 42 in WSL. I may give that a try and see if I have more success with that and the cross compilation.

@laanwj
Copy link
Member

laanwj commented Nov 13, 2017

I get an error warning about automake-1.14 is missing on my system. I checked and I have 1.15-4ubuntu1 installed. I suspect I need to follow the workarounds in #8732

If you get that error, you need to build from the linux drive. Building from a mounted windows drive e.g. /mnt/c/ will not work, as the file system interaction changes the timestamps such as protobuf thinks it needs to re-generate its configuration files, which doesn't work from the tarball.

@mikedennis
Copy link

mikedennis commented Nov 13, 2017

ACK

I was able to build with cross compilation using the instructions. I would, however, recommend the following modifications to the documentation:

  • In depends build mention you cannot build via mnt or else will get an error with automake
  • I needed to change to posix compilers even though I'm running Ubuntu 16.04. The docs say you only need to run posix on 17.04 and higher so probably need to change the docs to say 16.04 and higher.

@Thoragh Thoragh closed this Nov 14, 2017
@Thoragh Thoragh reopened this Nov 14, 2017
@Thoragh
Copy link
Contributor Author

Thoragh commented Nov 14, 2017

I have updated the pull request.

@laanwj
Copy link
Member

laanwj commented Nov 14, 2017

Going to merge this, @mikedennis feel free to improve it further in a future PR, those proposed changes make sense but are outside the claimed scope of this PR.

@laanwj laanwj merged commit 73a7e6d into bitcoin:master Nov 14, 2017
laanwj added a commit that referenced this pull request Nov 14, 2017
…pdate

73a7e6d Update WSL installation for Fall Creators update (Thoragh)

Pull request description:

  Fall Creators update (RS3) was released 17 October and it has made some changes to the installation of WSL (no longer requires Developer Mode, out of beta and Ubuntu has to be installed from the Store).

Tree-SHA512: 65073dc787e249959ae6374bfb448fceb17fb2b85ddaaf198e37f7af5ecd905a896294a0acb0a16fe13a78e3fc4c0a3f8ae2637c01912d50ba8f8ece7e897208
@Thoragh Thoragh deleted the Update-WSL-installation-for-Fall-Creators-update branch November 16, 2017 17:05
@bitcoin bitcoin locked as resolved and limited conversation to collaborators Sep 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants