New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docs: Update WSL installation notes for Fall Creators update #11533
Docs: Update WSL installation notes for Fall Creators update #11533
Conversation
Concept ACK |
I'd like to see confirmation that at least one other person tested this before merging. |
Concept ACK a4f171de5a44253394cb739586b04e2429f7f84d. Agree with @laanwj |
I just went through this and did my own pull when I was pointed to the fact this one already exists. I'm not sure you need much additional doc around this at all. It's basically just install WSL and then follow linux instructions for whatever distro you install in the WSL. Worked great for me whereas I was unable to get it to work with the previous beta WSL. |
With the exception that you're cross compiling for Windows. If you miss that part, you get issues like #11633. That's why separate instructions exist. |
@mikedennis So can you ACK the changes here, then this can be merged. |
This is conflicting after #11438, needs rebase if there are still relevant changes after that. |
I'm having problems with cross compilation. To start with if you follow these procedures you end up with Ubuntu Xenial 16.04 which this doc states is not a good choice for cross compilation. I proceeded and ran into a problem with this step building in depends: I get an error warning about automake-1.14 is missing on my system. I checked and I have 1.15-4ubuntu1 installed. I suspect I need to follow the workarounds in #8732 I recommend putting a note in the docs that this procedure installs Ubuntu Xenial 16.04 and to see #8732 if you want to cross compile. You can also install openSUSE Leap 42 in WSL. I may give that a try and see if I have more success with that and the cross compilation. |
If you get that error, you need to build from the linux drive. Building from a mounted windows drive e.g. /mnt/c/ will not work, as the file system interaction changes the timestamps such as protobuf thinks it needs to re-generate its configuration files, which doesn't work from the tarball. |
ACK I was able to build with cross compilation using the instructions. I would, however, recommend the following modifications to the documentation:
|
I have updated the pull request. |
Going to merge this, @mikedennis feel free to improve it further in a future PR, those proposed changes make sense but are outside the claimed scope of this PR. |
…pdate 73a7e6d Update WSL installation for Fall Creators update (Thoragh) Pull request description: Fall Creators update (RS3) was released 17 October and it has made some changes to the installation of WSL (no longer requires Developer Mode, out of beta and Ubuntu has to be installed from the Store). Tree-SHA512: 65073dc787e249959ae6374bfb448fceb17fb2b85ddaaf198e37f7af5ecd905a896294a0acb0a16fe13a78e3fc4c0a3f8ae2637c01912d50ba8f8ece7e897208
Fall Creators update (RS3) was released 17 October and it has made some changes to the installation of WSL (no longer requires Developer Mode, out of beta and Ubuntu has to be installed from the Store).