Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make ISSUE_TEMPLATE a bit shorter, mention hardware tests #11686

Merged
merged 1 commit into from Nov 15, 2017

Conversation

TheBlueMatt
Copy link
Contributor

Kinda getting tired of "block checksum mismatch error" issues on RPis that dont even have heatsinks...Also a shorter issue template might encourage people to actually read it.

@@ -1,37 +1,23 @@
<!--- Remove sections that do not apply -->

This issue tracker is only for technical issues related to bitcoin-core.
This issue tracker is only for technical issues related to Bitcoin Core.

General bitcoin questions and/or support requests and are best directed to the [Bitcoin StackExchange](https://bitcoin.stackexchange.com).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/and are/are/

@maflcko
Copy link
Member

maflcko commented Nov 14, 2017

re-utACK ea3f363

@laanwj
Copy link
Member

laanwj commented Nov 14, 2017

While we're changing this anyway, what also might make sense is writing the template in comments (<!-- ... -->); or at least the explanatory text. It doesn't need to end up in the issue.

@practicalswift
Copy link
Contributor

ACK ea3f363

@fanquake fanquake added the Docs label Nov 14, 2017
@fanquake
Copy link
Member

ACK. Agree with adding the comments so that the default text no longer ends up in the issue.

@jonasschnelli
Copy link
Contributor

utACK ea3f363
Also ack for @laanwj idea about commenting out the default text blocks.

@meshcollider
Copy link
Contributor

meshcollider commented Nov 15, 2017

utACK ea3f363

Another +1 for commenting out the all the monologue at the top "This issue tracker is only....before creating an issue!" and the thing about debug.log at the end

Copy link
Member

@promag promag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK.

@@ -1,37 +1,23 @@
<!--- Remove sections that do not apply -->

This issue tracker is only for technical issues related to bitcoin-core.
This issue tracker is only for technical issues related to Bitcoin Core.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All of these notes can be inside a comment block:

<!---
Remove sections that do not apply.

This issue tracker is only ...

General bitcoin questions ...

...
--->

So that the user can see it when writing but it won't show.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

uh, I guess it's what @laanwj suggests above.

@TheBlueMatt
Copy link
Contributor Author

Heh, I'd be afraid of putting the entire explanatory block into a comment as users are likely to simply answer the questions in-line, and end up with the entire issue in a comment :/.

@maflcko
Copy link
Member

maflcko commented Nov 15, 2017

There are some links in the text, which won't render in preview when they are commented out. Guess it is fine as is, no need to have a lengthy discussion about it.

@maflcko maflcko merged commit ea3f363 into bitcoin:master Nov 15, 2017
maflcko pushed a commit that referenced this pull request Nov 15, 2017
ea3f363 Make ISSUE_TEMPLATE a bit shorter, mention hardware tests (Matt Corallo)

Pull request description:

  Kinda getting tired of "block checksum mismatch error" issues on RPis that dont even have heatsinks...Also a shorter issue template might encourage people to actually read it.

Tree-SHA512: 943a286f6ea5c4f837a8dc3906342e1e428cf788d05ba9110f8005400d9775ae6f9cf3ce31ada201f5f7b95a6101314f2cb93f49dd92e242fbcea00aaae9e6e6
@laanwj
Copy link
Member

laanwj commented Nov 16, 2017

Heh, I'd be afraid of putting the entire explanatory block into a comment as users are likely to simply answer the questions in-line, and end up with the entire issue in a comment :/.

I think that's less likely, at least if commented out per sentence and not entirely. There are many projects doing this anyhow...

Also comments do still end up in the server, so IF this happens someone with editing permissions can fix it up.

There are some links in the text, which won't render in preview when they are commented out. Guess it is fine as is, no need to have a lengthy discussion about it.

I doubt anyone is going to preview template the just to click the links.

@TheBlueMatt
Copy link
Contributor Author

@laanwj is #11706 closer to what you envision?

jasonbcox pushed a commit to Bitcoin-ABC/bitcoin-abc that referenced this pull request Oct 29, 2020
…dware tests

Summary:
ea3f363 Make ISSUE_TEMPLATE a bit shorter, mention hardware tests (Matt Corallo)

Pull request description:

  Kinda getting tired of "block checksum mismatch error" issues on RPis that dont even have heatsinks...Also a shorter issue template might encourage people to actually read it.

---

e89adba Make default issue text all comments to make issues more readable (Matt Corallo)

---

Backport of Core [[bitcoin/bitcoin#11686 | PR11686]] and [[bitcoin/bitcoin#11706 | PR11706]]

Test Plan: read it

Reviewers: #bitcoin_abc, Fabien

Reviewed By: #bitcoin_abc, Fabien

Subscribers: Fabien

Differential Revision: https://reviews.bitcoinabc.org/D8171
@bitcoin bitcoin locked as resolved and limited conversation to collaborators Sep 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants