[docs] links to code style guides #11729
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CONTRIBUTING.md
Outdated
| @@ -186,7 +186,7 @@ In general, all pull requests must: | |||
| the project (for example refactoring for modularisation); | |||
| - Be well peer reviewed; | |||
| - Have unit tests and functional tests where appropriate; | |||
| - Follow code style guidelines; | |||
| - Follow code style guidelines ([C++](doc/developer-notes.md), [function tests](test/functional/README.md)); | |||
There was a problem hiding this comment.
Nit: functional tests not function tests
|
ACK 356a025 |
Sjors
force-pushed
the
docs-style-guide-links
branch
from
356a025
to
fe27a72
Compare
|
ACK fe27a72 Failed Travis job restarted! |
|
ACK fe27a72 |
|
ACK fe27a72. |
maflcko
pushed a commit
that referenced
this pull request
Nov 20, 2017
fe27a72 [docs] links to code style guides (Sjors Provoost) Pull request description: I always have difficulty finding these, probably because they're not actually called "code style guideline". Tree-SHA512: a2716c5e7e6778ce71b4451091e3899c0f9e04d07e95d1a0bdb07eb0319c083e3d9aa94bc2e33fc8546f82a1441e73c37218fdc7f228ee8273c7a87466958973
PastaPastaPasta
pushed a commit
to PastaPastaPasta/dash
that referenced
this pull request
Feb 13, 2020
fe27a72 [docs] links to code style guides (Sjors Provoost) Pull request description: I always have difficulty finding these, probably because they're not actually called "code style guideline". Tree-SHA512: a2716c5e7e6778ce71b4451091e3899c0f9e04d07e95d1a0bdb07eb0319c083e3d9aa94bc2e33fc8546f82a1441e73c37218fdc7f228ee8273c7a87466958973
PastaPastaPasta
pushed a commit
to PastaPastaPasta/dash
that referenced
this pull request
Feb 27, 2020
fe27a72 [docs] links to code style guides (Sjors Provoost) Pull request description: I always have difficulty finding these, probably because they're not actually called "code style guideline". Tree-SHA512: a2716c5e7e6778ce71b4451091e3899c0f9e04d07e95d1a0bdb07eb0319c083e3d9aa94bc2e33fc8546f82a1441e73c37218fdc7f228ee8273c7a87466958973
PastaPastaPasta
pushed a commit
to PastaPastaPasta/dash
that referenced
this pull request
Feb 27, 2020
fe27a72 [docs] links to code style guides (Sjors Provoost) Pull request description: I always have difficulty finding these, probably because they're not actually called "code style guideline". Tree-SHA512: a2716c5e7e6778ce71b4451091e3899c0f9e04d07e95d1a0bdb07eb0319c083e3d9aa94bc2e33fc8546f82a1441e73c37218fdc7f228ee8273c7a87466958973
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I always have difficulty finding these, probably because they're not actually called "code style guideline".