remove references to bitcoin-wx from comment in init.cpp #1173
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ACK |
1 similar comment
|
ACK |
|
ACK Loosely related comment: I see that this call (and the (Get|Set)StartOnSystemStartup functions) could be moved to the UI code initialization (qt/bitcoin.cpp) instead of clutter the core code with a QT_GUI guard. |
|
@laanwj That's a thing you should do, but sounds like a very good idea :). |
|
Erm, why make a useful comment less useful? The purpose of that code is to remove old wxBitcoin shortcut links... so the "bitcoin-wx" note is correct. |
|
This removes the current Shortcut (Bitcoin.lnk) and as we don't have wx anymore this is correct, no? |
jgarzik
pushed a commit
that referenced
this pull request
May 1, 2012
remove references to bitcoin-wx from comment in init.cpp
coblee
pushed a commit
to litecoin-project/litecoin
that referenced
this pull request
Jul 17, 2012
remove references to bitcoin-wx from comment in init.cpp
suprnurd
pushed a commit
to chaincoin-legacy/chaincoin
that referenced
this pull request
Dec 5, 2017
lateminer
pushed a commit
to lateminer/bitcoin
that referenced
this pull request
Jan 22, 2019
* Change `parallel` help message according to the fact it's flag not a parameter * Add a reference to doc/bu-parallel-validation.md above nScriptCheckQueues init * Formatting of doc/bu-parallel-validation.md Mainly removing trailing spaces and add missing back trick around function name. Also clarified what we meant "wrong chain' in the last paragraph adding "chain with lowest amount of accumulated POW" [skip ci]
lateminer
pushed a commit
to lateminer/bitcoin
that referenced
this pull request
Dec 25, 2019
…ration property. abe7632 [GUI] Remove every pushButton focus property. (furszy) Pull request description: This is because a **linux-only** issue in which the button focus highlight decoration seems to come from the style `QStyle::PE_FrameFocusRect` which is not the one set in the css files. <img width="426" alt="Screen Shot 2019-12-05 at 12 16 35 AM" src="https://user-images.githubusercontent.com/5377650/70201174-8d7f8f80-16f4-11ea-9e6b-1a6b4827feb2.png"> . Screenshot examples: <img width="550" alt="Screen Shot 2019-12-05 at 12 16 28 AM" src="https://user-images.githubusercontent.com/5377650/70201180-983a2480-16f4-11ea-8b7f-bc29f3d4d614.png"> ACKs for top commit: random-zebra: ACK abe7632 Fuzzbawls: utACK abe7632 Tree-SHA512: ef948f896f0d3d4d56845489a981b51e36c925a332be0d745d302824d65921c1bb08803668600128d9fe2107e2306f6a2c3a35de613d7e198a4f8f604b84610e
dexX7
added a commit
to dexX7/bitcoin
that referenced
this pull request
Sep 30, 2020
e9052fa Bump version to 0.9.0 (dexX7) Pull request description: Increase version of Omni Core to 0.9.0. Tree-SHA512: 58cf966c8a7584f7d63de91a2437fa2da3a8da47bfe43d6644be042b26cd5dda058e0f6894a5ba4e4cf3a037cd3224261bad64c0d07e5bb2d2689d6d51fa37c4
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.