[docs] Fixed outdated link with archive.is #11804
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The listed link is directing to an empty page, at least content-wise. I found the same page on archive.is and linked to that instead.
promag
reviewed
Dec 1, 2017
| @@ -52,4 +52,4 @@ examine `uint256_tests.cpp`. | |||
|
|
|||
| For further reading, I found the following website to be helpful in | |||
| explaining how the boost unit test framework works: | |||
| [http://www.alittlemadness.com/2009/03/31/c-unit-testing-with-boosttest/](http://www.alittlemadness.com/2009/03/31/c-unit-testing-with-boosttest/). | |||
There was a problem hiding this comment.
Nice catch!
How about pointing to official documentation? Also, this paragraph could be improved to remove the first person.
There was a problem hiding this comment.
I don't think he has to fix all the surrounding issues in the file just for fixing a link.
IMO this PR is fine as-is. But if you want to make further updates sure!
|
ACK |
laanwj
added a commit
that referenced
this pull request
Dec 1, 2017
bf20a7d [docs] Fixed outdated link with archive.is (Tim Shimmin) Tree-SHA512: 7d316aa4c462213578a9a1e71b06a459924ed3bb681a0469cc3719b21a871a6350fff4656696057e362561ee10dc10e933fe1328ef454ab7e133ecf05549ec1c
PastaPastaPasta
pushed a commit
to PastaPastaPasta/dash
that referenced
this pull request
Apr 4, 2020
bf20a7d [docs] Fixed outdated link with archive.is (Tim Shimmin) Tree-SHA512: 7d316aa4c462213578a9a1e71b06a459924ed3bb681a0469cc3719b21a871a6350fff4656696057e362561ee10dc10e933fe1328ef454ab7e133ecf05549ec1c
PastaPastaPasta
pushed a commit
to PastaPastaPasta/dash
that referenced
this pull request
Apr 5, 2020
bf20a7d [docs] Fixed outdated link with archive.is (Tim Shimmin) Tree-SHA512: 7d316aa4c462213578a9a1e71b06a459924ed3bb681a0469cc3719b21a871a6350fff4656696057e362561ee10dc10e933fe1328ef454ab7e133ecf05549ec1c
jasonbcox
pushed a commit
to Bitcoin-ABC/bitcoin-abc
that referenced
this pull request
Oct 29, 2020
Summary: bf20a7d [docs] Fixed outdated link with archive.is (Tim Shimmin) --- Backport of Core [[bitcoin/bitcoin#11804 | PR11804]] Test Plan: read it Reviewers: #bitcoin_abc, PiRK, Fabien Reviewed By: #bitcoin_abc, PiRK, Fabien Differential Revision: https://reviews.bitcoinabc.org/D8173
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The listed link is directing to an empty page, at least content-wise. I found the same page on archive.is and linked to that instead.