New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[build] Warn that only libconsensus can be built without Boost #11936
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thanks @fanquake, I thought the other PR was due for a bit more discussion, that was the reason I didn't address the commit message change. |
laanwj
added a commit
that referenced
this pull request
Dec 19, 2017
…t Boost 3eb4d45 [build] Warn that only libconsensus can be built without boost (Varunram) Pull request description: This replaces the "configure: error: Could not find a version of the boost_system library!" message you receive when trying to build without Boost, with "only libbitcoinconsensus can be built without boost". `./configure --with-utils=no --disable-bench --disable-gui-tests --disable-tests --with-daemon=no --without-gui --disable-wallet --with-boost=no` builds libconsensus. `./configure --with-boost=no` should always fail with: ``` checking whether to build Bitcoin Core GUI... yes (Qt5) configure: error: only libbitcoinconsensus can be built without boost ``` For anyone wondering why the check comes after the AX_BOOST_BASE check, see this [comment](#11806 (comment)). "the AX_BOOST_BASE macro that does the --with-boost handling (along with the actual checks), and sets "want_boost". " Fixes #10826, replaces #11806. @theuni if you re-ACK we can get this merged. Tree-SHA512: f0b8f483586465187ca6689e731b24ff77da41a06fb5c9d6390c82990719911dd54ebcccaf6d4fcea2be92986cc7fa88ed979e6cb9d77917920181e5e5188067
post-merge utACK |
PastaPastaPasta
pushed a commit
to PastaPastaPasta/dash
that referenced
this pull request
Jan 17, 2020
… without Boost 3eb4d45 [build] Warn that only libconsensus can be built without boost (Varunram) Pull request description: This replaces the "configure: error: Could not find a version of the boost_system library!" message you receive when trying to build without Boost, with "only libbitcoinconsensus can be built without boost". `./configure --with-utils=no --disable-bench --disable-gui-tests --disable-tests --with-daemon=no --without-gui --disable-wallet --with-boost=no` builds libconsensus. `./configure --with-boost=no` should always fail with: ``` checking whether to build Bitcoin Core GUI... yes (Qt5) configure: error: only libbitcoinconsensus can be built without boost ``` For anyone wondering why the check comes after the AX_BOOST_BASE check, see this [comment](bitcoin#11806 (comment)). "the AX_BOOST_BASE macro that does the --with-boost handling (along with the actual checks), and sets "want_boost". " Fixes bitcoin#10826, replaces bitcoin#11806. @theuni if you re-ACK we can get this merged. Tree-SHA512: f0b8f483586465187ca6689e731b24ff77da41a06fb5c9d6390c82990719911dd54ebcccaf6d4fcea2be92986cc7fa88ed979e6cb9d77917920181e5e5188067
PastaPastaPasta
pushed a commit
to PastaPastaPasta/dash
that referenced
this pull request
Jan 22, 2020
… without Boost 3eb4d45 [build] Warn that only libconsensus can be built without boost (Varunram) Pull request description: This replaces the "configure: error: Could not find a version of the boost_system library!" message you receive when trying to build without Boost, with "only libbitcoinconsensus can be built without boost". `./configure --with-utils=no --disable-bench --disable-gui-tests --disable-tests --with-daemon=no --without-gui --disable-wallet --with-boost=no` builds libconsensus. `./configure --with-boost=no` should always fail with: ``` checking whether to build Bitcoin Core GUI... yes (Qt5) configure: error: only libbitcoinconsensus can be built without boost ``` For anyone wondering why the check comes after the AX_BOOST_BASE check, see this [comment](bitcoin#11806 (comment)). "the AX_BOOST_BASE macro that does the --with-boost handling (along with the actual checks), and sets "want_boost". " Fixes bitcoin#10826, replaces bitcoin#11806. @theuni if you re-ACK we can get this merged. Tree-SHA512: f0b8f483586465187ca6689e731b24ff77da41a06fb5c9d6390c82990719911dd54ebcccaf6d4fcea2be92986cc7fa88ed979e6cb9d77917920181e5e5188067
PastaPastaPasta
pushed a commit
to PastaPastaPasta/dash
that referenced
this pull request
Jan 22, 2020
… without Boost 3eb4d45 [build] Warn that only libconsensus can be built without boost (Varunram) Pull request description: This replaces the "configure: error: Could not find a version of the boost_system library!" message you receive when trying to build without Boost, with "only libbitcoinconsensus can be built without boost". `./configure --with-utils=no --disable-bench --disable-gui-tests --disable-tests --with-daemon=no --without-gui --disable-wallet --with-boost=no` builds libconsensus. `./configure --with-boost=no` should always fail with: ``` checking whether to build Bitcoin Core GUI... yes (Qt5) configure: error: only libbitcoinconsensus can be built without boost ``` For anyone wondering why the check comes after the AX_BOOST_BASE check, see this [comment](bitcoin#11806 (comment)). "the AX_BOOST_BASE macro that does the --with-boost handling (along with the actual checks), and sets "want_boost". " Fixes bitcoin#10826, replaces bitcoin#11806. @theuni if you re-ACK we can get this merged. Tree-SHA512: f0b8f483586465187ca6689e731b24ff77da41a06fb5c9d6390c82990719911dd54ebcccaf6d4fcea2be92986cc7fa88ed979e6cb9d77917920181e5e5188067
PastaPastaPasta
pushed a commit
to PastaPastaPasta/dash
that referenced
this pull request
Jan 29, 2020
… without Boost 3eb4d45 [build] Warn that only libconsensus can be built without boost (Varunram) Pull request description: This replaces the "configure: error: Could not find a version of the boost_system library!" message you receive when trying to build without Boost, with "only libbitcoinconsensus can be built without boost". `./configure --with-utils=no --disable-bench --disable-gui-tests --disable-tests --with-daemon=no --without-gui --disable-wallet --with-boost=no` builds libconsensus. `./configure --with-boost=no` should always fail with: ``` checking whether to build Bitcoin Core GUI... yes (Qt5) configure: error: only libbitcoinconsensus can be built without boost ``` For anyone wondering why the check comes after the AX_BOOST_BASE check, see this [comment](bitcoin#11806 (comment)). "the AX_BOOST_BASE macro that does the --with-boost handling (along with the actual checks), and sets "want_boost". " Fixes bitcoin#10826, replaces bitcoin#11806. @theuni if you re-ACK we can get this merged. Tree-SHA512: f0b8f483586465187ca6689e731b24ff77da41a06fb5c9d6390c82990719911dd54ebcccaf6d4fcea2be92986cc7fa88ed979e6cb9d77917920181e5e5188067
PastaPastaPasta
pushed a commit
to PastaPastaPasta/dash
that referenced
this pull request
Jan 29, 2020
… without Boost 3eb4d45 [build] Warn that only libconsensus can be built without boost (Varunram) Pull request description: This replaces the "configure: error: Could not find a version of the boost_system library!" message you receive when trying to build without Boost, with "only libbitcoinconsensus can be built without boost". `./configure --with-utils=no --disable-bench --disable-gui-tests --disable-tests --with-daemon=no --without-gui --disable-wallet --with-boost=no` builds libconsensus. `./configure --with-boost=no` should always fail with: ``` checking whether to build Bitcoin Core GUI... yes (Qt5) configure: error: only libbitcoinconsensus can be built without boost ``` For anyone wondering why the check comes after the AX_BOOST_BASE check, see this [comment](bitcoin#11806 (comment)). "the AX_BOOST_BASE macro that does the --with-boost handling (along with the actual checks), and sets "want_boost". " Fixes bitcoin#10826, replaces bitcoin#11806. @theuni if you re-ACK we can get this merged. Tree-SHA512: f0b8f483586465187ca6689e731b24ff77da41a06fb5c9d6390c82990719911dd54ebcccaf6d4fcea2be92986cc7fa88ed979e6cb9d77917920181e5e5188067
PastaPastaPasta
pushed a commit
to PastaPastaPasta/dash
that referenced
this pull request
Jan 29, 2020
… without Boost 3eb4d45 [build] Warn that only libconsensus can be built without boost (Varunram) Pull request description: This replaces the "configure: error: Could not find a version of the boost_system library!" message you receive when trying to build without Boost, with "only libbitcoinconsensus can be built without boost". `./configure --with-utils=no --disable-bench --disable-gui-tests --disable-tests --with-daemon=no --without-gui --disable-wallet --with-boost=no` builds libconsensus. `./configure --with-boost=no` should always fail with: ``` checking whether to build Bitcoin Core GUI... yes (Qt5) configure: error: only libbitcoinconsensus can be built without boost ``` For anyone wondering why the check comes after the AX_BOOST_BASE check, see this [comment](bitcoin#11806 (comment)). "the AX_BOOST_BASE macro that does the --with-boost handling (along with the actual checks), and sets "want_boost". " Fixes bitcoin#10826, replaces bitcoin#11806. @theuni if you re-ACK we can get this merged. Tree-SHA512: f0b8f483586465187ca6689e731b24ff77da41a06fb5c9d6390c82990719911dd54ebcccaf6d4fcea2be92986cc7fa88ed979e6cb9d77917920181e5e5188067
PastaPastaPasta
pushed a commit
to PastaPastaPasta/dash
that referenced
this pull request
Jan 31, 2020
… without Boost 3eb4d45 [build] Warn that only libconsensus can be built without boost (Varunram) Pull request description: This replaces the "configure: error: Could not find a version of the boost_system library!" message you receive when trying to build without Boost, with "only libbitcoinconsensus can be built without boost". `./configure --with-utils=no --disable-bench --disable-gui-tests --disable-tests --with-daemon=no --without-gui --disable-wallet --with-boost=no` builds libconsensus. `./configure --with-boost=no` should always fail with: ``` checking whether to build Bitcoin Core GUI... yes (Qt5) configure: error: only libbitcoinconsensus can be built without boost ``` For anyone wondering why the check comes after the AX_BOOST_BASE check, see this [comment](bitcoin#11806 (comment)). "the AX_BOOST_BASE macro that does the --with-boost handling (along with the actual checks), and sets "want_boost". " Fixes bitcoin#10826, replaces bitcoin#11806. @theuni if you re-ACK we can get this merged. Tree-SHA512: f0b8f483586465187ca6689e731b24ff77da41a06fb5c9d6390c82990719911dd54ebcccaf6d4fcea2be92986cc7fa88ed979e6cb9d77917920181e5e5188067
gades
pushed a commit
to cosanta/cosanta-core
that referenced
this pull request
Jun 26, 2021
… without Boost 3eb4d45 [build] Warn that only libconsensus can be built without boost (Varunram) Pull request description: This replaces the "configure: error: Could not find a version of the boost_system library!" message you receive when trying to build without Boost, with "only libbitcoinconsensus can be built without boost". `./configure --with-utils=no --disable-bench --disable-gui-tests --disable-tests --with-daemon=no --without-gui --disable-wallet --with-boost=no` builds libconsensus. `./configure --with-boost=no` should always fail with: ``` checking whether to build Bitcoin Core GUI... yes (Qt5) configure: error: only libbitcoinconsensus can be built without boost ``` For anyone wondering why the check comes after the AX_BOOST_BASE check, see this [comment](bitcoin#11806 (comment)). "the AX_BOOST_BASE macro that does the --with-boost handling (along with the actual checks), and sets "want_boost". " Fixes bitcoin#10826, replaces bitcoin#11806. @theuni if you re-ACK we can get this merged. Tree-SHA512: f0b8f483586465187ca6689e731b24ff77da41a06fb5c9d6390c82990719911dd54ebcccaf6d4fcea2be92986cc7fa88ed979e6cb9d77917920181e5e5188067
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This replaces the "configure: error: Could not find a version of the boost_system library!" message you receive when trying to build without Boost, with "only libbitcoinconsensus can be built without boost".
./configure --with-utils=no --disable-bench --disable-gui-tests --disable-tests --with-daemon=no --without-gui --disable-wallet --with-boost=no
builds libconsensus../configure --with-boost=no
should always fail with:For anyone wondering why the check comes after the AX_BOOST_BASE check, see this comment. "the AX_BOOST_BASE macro that does the --with-boost handling (along with the actual checks), and sets "want_boost". "
Fixes #10826, replaces #11806.
@theuni if you re-ACK we can get this merged.