New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove dead feeest-file read code for old versions #11951
Conversation
0.15.0 introduced a new feeest file format, and support for parsing old versions was never fully added. We now simply fail to read the old format, so remove the dead partial-implementation.
utACK 62e7c04 |
Why not remove |
I figured it may be useful to have in a future change, so might as well leave it instead of creating more diff to change the function signature. |
I'm able to hit the new check in #11273 by manually editing the
which means that It'd be good to add a check in
My default preference is the other way. If code is unused it should be removed at the earliest opportunity. Tested ACK 62e7c04 |
utACK 62e7c04 |
utACK 62e7c04 |
62e7c04 Remove dead feeest-file read code for old versions (Matt Corallo) Pull request description: 0.15.0 introduced a new feeest file format, and support for parsing old versions was never fully added. We now simply fail to read the old format, so remove the dead partial-implementation. Follow up to #11273. Tree-SHA512: c291ce51b7cb0c93479c18a1885dd646cbe03e4c7d12df03c0e99c0634e1bf9f9e41facf54a645227154bab58b9988f21b928cf3fc0520087c4eede4258c8861
62e7c04 Remove dead feeest-file read code for old versions (Matt Corallo) Pull request description: 0.15.0 introduced a new feeest file format, and support for parsing old versions was never fully added. We now simply fail to read the old format, so remove the dead partial-implementation. Follow up to bitcoin#11273. Tree-SHA512: c291ce51b7cb0c93479c18a1885dd646cbe03e4c7d12df03c0e99c0634e1bf9f9e41facf54a645227154bab58b9988f21b928cf3fc0520087c4eede4258c8861
62e7c04 Remove dead feeest-file read code for old versions (Matt Corallo) Pull request description: 0.15.0 introduced a new feeest file format, and support for parsing old versions was never fully added. We now simply fail to read the old format, so remove the dead partial-implementation. Follow up to bitcoin#11273. Tree-SHA512: c291ce51b7cb0c93479c18a1885dd646cbe03e4c7d12df03c0e99c0634e1bf9f9e41facf54a645227154bab58b9988f21b928cf3fc0520087c4eede4258c8861
62e7c04 Remove dead feeest-file read code for old versions (Matt Corallo) Pull request description: 0.15.0 introduced a new feeest file format, and support for parsing old versions was never fully added. We now simply fail to read the old format, so remove the dead partial-implementation. Follow up to bitcoin#11273. Tree-SHA512: c291ce51b7cb0c93479c18a1885dd646cbe03e4c7d12df03c0e99c0634e1bf9f9e41facf54a645227154bab58b9988f21b928cf3fc0520087c4eede4258c8861
62e7c04 Remove dead feeest-file read code for old versions (Matt Corallo) Pull request description: 0.15.0 introduced a new feeest file format, and support for parsing old versions was never fully added. We now simply fail to read the old format, so remove the dead partial-implementation. Follow up to bitcoin#11273. Tree-SHA512: c291ce51b7cb0c93479c18a1885dd646cbe03e4c7d12df03c0e99c0634e1bf9f9e41facf54a645227154bab58b9988f21b928cf3fc0520087c4eede4258c8861
0.15.0 introduced a new feeest file format, and support for parsing
old versions was never fully added. We now simply fail to read the
old format, so remove the dead partial-implementation.
Follow up to #11273.