Prevent stuck download: correct solution #1196
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull request bitcoin#948 introduced a fix for nodes stuck on a long side branch of the main chain. The fix was non-functional however, as the additional getdata request was created in a first step of processing, but dropped in a second step as it was considered redundant. This commits fixes it by sending the request directly.
|
Pulling to master to get some more testing on it quickly. |
gmaxwell
added a commit
that referenced
this pull request
May 6, 2012
Prevent stuck download: correct solution
coblee
pushed a commit
to litecoin-project/litecoin
that referenced
this pull request
Jul 17, 2012
Prevent stuck download: correct solution
suprnurd
pushed a commit
to chaincoin-legacy/chaincoin
that referenced
this pull request
Dec 5, 2017
* Fix rate checks for governance objects * Do not update last vote time when rate checks are disabled * Bump governance serialization version
lateminer
pushed a commit
to lateminer/bitcoin
that referenced
this pull request
Jan 22, 2019
…elay fee (bitcoin#1196) * Move variable initializations for the mempool limiter to main.h This is a move only, no other changes. * Make the DEFAULT_MAXLIMITERTXFEE equal to the DEFAULT_MIN_RELAY_TX_FEE This way we will not trample on zero-conf since our limiter will by default not rise higher than the min relay fee defaults. However operators can still manually change their mempool limiter settings to whatever policy they wish to enforce. * Clarify naming of maxFeeCutoff and initFeeCutoff use the naming of dMaxLimiterTxFee and dMinLimiterTxFee to denote these variables. This make the code easier to read. * Make both minlimitertxfee and maxlimtertxfee tweaks. * for clarity change feeCutoff to nMinRelay * Add critcal section cs_limiter Although we don't need this now because cs_main locks this section we will in the future need this when we reduce the scope of cs_main in accepttomemorypoolworker. * fix format * Fix log output message for nMinRelay We were not actually printing out the correct value which led to a great deal of confusion as to why the values were drifting when they shouldn't be. * Use Tweak version of maxlimitertxfee and minlimitertxfee only * Always set minRelayTxFee in init.cpp * Move UnlimitedSetup() to the beginning of AppInit2 * Fix fundrawtransaction.py We need to launch the nodes with a minlimitertxfee=1.0 so that we have a relayfee of 1000 sat per KB othewise this test will not work. * Remove redundant nLastTime assignment.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request #948 introduced a fix for nodes stuck on a long side branch of the main chain. The fix was non-functional however, as the additional getdata request was created in a first step of processing, but dropped
in a second step as it was considered redundant. This commits fixes it by sending the request directly.