qa: Note on test order in test_runner #11965
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maflcko
force-pushed
the
Mf1712-qaTestRunnerOrder
branch
2 times, most recently
from
faaa4d3
to
fa2333f
Compare
|
ACK fa2333f. Nit, should new tests be added at the end of the run-time section or should there be an effort to keep them sorted? |
|
I would clarify it a little more, e.g. or maybe 'line' instead of 'comment'. |
maflcko
force-pushed
the
Mf1712-qaTestRunnerOrder
branch
from
fa2333f
to
fadf60e
Compare
|
@promag Adding at the end of run-time sections doesn't help with merge conflict. Sorting by name would. Though, since we plan to rename the tests, I don't want to go in this direction. |
|
utACK fadf60e |
maflcko
pushed a commit
that referenced
this pull request
Jan 3, 2018
PastaPastaPasta
pushed a commit
to PastaPastaPasta/dash
that referenced
this pull request
Apr 3, 2020
fadf60e qa: Note on test order in test_runner (MarcoFalke) Pull request description: C.f. bitcoin#11964 Tree-SHA512: 5f087965093722d9e7a3febddcc187e412bd0636a7ed2da60111668fe3bba6668110e25a38ddcccc0d0aae132611c56fa72f3f0c473fb3fb59e38be445edfcd5
PastaPastaPasta
pushed a commit
to PastaPastaPasta/dash
that referenced
this pull request
Apr 3, 2020
fadf60e qa: Note on test order in test_runner (MarcoFalke) Pull request description: C.f. bitcoin#11964 Tree-SHA512: 5f087965093722d9e7a3febddcc187e412bd0636a7ed2da60111668fe3bba6668110e25a38ddcccc0d0aae132611c56fa72f3f0c473fb3fb59e38be445edfcd5
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
C.f. #11964