New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[build] .gitignore: add QT Creator artifacts #11989
Conversation
utACK ac5104f |
We've historically been pushing back against adding artifacts for every possible IDE to the gitignore, as it's impossible to maintain, and they can be locally ignored just as easily, either locally or globally (https://help.github.com/articles/ignoring-files/). But if this is part of our own instructions, fair enough. |
I'm not aware of alternative editors for QT |
FYI (not meant as argument against this PR): There's the stand-alone Qt Designer, command |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
utACK ac5104f
The .gitignorefile is probably not really sacred,... but indeed we should avoid to add files/patterns from any possible IDE. But Qt creator seems somehow be unique for working on the GUI (AFAIK no other interactive editor for .ui files are available)
utACK
That's not true, see the post above! |
ac5104f [build] .gitignore: add QT Creator artifacts (Sjors Provoost) Pull request description: These files appear on OSX if you follow the [QT Creator instructions](https://github.com/bitcoin/bitcoin/blob/master/doc/build-osx.md#using-qt-creator-as-ide). The files don't contain anything terribly useful that might warrant including them in the repo instead. Tree-SHA512: 346ece7846e7707abe599fe53b91472f7f6b79609dfdd0cb471a3363919d941385eec402045f8344f52d4d2212d29ae7c3cb2f4d55bbd978d49ac333e83f0fca
Summary: These files appear on OSX if you follow the [QT Creator instructions](https://github.com/bitcoin/bitcoin/blob/master/doc/build-osx.md#using-qt-creator-as-ide). Backport of Bitcoin Core PR11989 bitcoin/bitcoin#11989 Test Plan: ``` make check-all ``` Reviewers: Fabien, #bitcoin_abc, deadalnix, jasonbcox Reviewed By: #bitcoin_abc, jasonbcox Differential Revision: https://reviews.bitcoinabc.org/D4063
These files appear on OSX if you follow the QT Creator instructions.
The files don't contain anything terribly useful that might warrant including them in the repo instead.