Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[build] .gitignore: add QT Creator artifacts #11989

Merged
merged 1 commit into from Jan 29, 2018

Conversation

Sjors
Copy link
Member

@Sjors Sjors commented Dec 22, 2017

These files appear on OSX if you follow the QT Creator instructions.

The files don't contain anything terribly useful that might warrant including them in the repo instead.

@fanquake
Copy link
Member

utACK ac5104f

@laanwj
Copy link
Member

laanwj commented Dec 23, 2017

We've historically been pushing back against adding artifacts for every possible IDE to the gitignore, as it's impossible to maintain, and they can be locally ignored just as easily, either locally or globally (https://help.github.com/articles/ignoring-files/).

But if this is part of our own instructions, fair enough.

@Sjors
Copy link
Member Author

Sjors commented Dec 23, 2017

I'm not aware of alternative editors for QT .ui files and I'm assuming these artifacts are the same on all OS's.

@laanwj
Copy link
Member

laanwj commented Dec 30, 2017

FYI (not meant as argument against this PR): There's the stand-alone Qt Designer, command designer, which is part of qttools5-dev-tools package on Ubuntu. Qt Creator simply links that code through a shared library.

Copy link
Contributor

@jonasschnelli jonasschnelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK ac5104f

The .gitignorefile is probably not really sacred,... but indeed we should avoid to add files/patterns from any possible IDE. But Qt creator seems somehow be unique for working on the GUI (AFAIK no other interactive editor for .ui files are available)

@laanwj
Copy link
Member

laanwj commented Jan 29, 2018

utACK

AFAIK no other interactive editor for .ui files are available)

That's not true, see the post above!

@laanwj laanwj merged commit ac5104f into bitcoin:master Jan 29, 2018
laanwj added a commit that referenced this pull request Jan 29, 2018
ac5104f [build] .gitignore: add QT Creator artifacts (Sjors Provoost)

Pull request description:

  These files appear on OSX if you follow the [QT Creator instructions](https://github.com/bitcoin/bitcoin/blob/master/doc/build-osx.md#using-qt-creator-as-ide).

  The files don't contain anything terribly useful that might warrant including them in the repo instead.

Tree-SHA512: 346ece7846e7707abe599fe53b91472f7f6b79609dfdd0cb471a3363919d941385eec402045f8344f52d4d2212d29ae7c3cb2f4d55bbd978d49ac333e83f0fca
@Sjors Sjors deleted the ignore-qt-creator-artifacts branch January 29, 2018 15:48
jasonbcox pushed a commit to Bitcoin-ABC/bitcoin-abc that referenced this pull request Sep 27, 2019
Summary:
These files appear on OSX if you follow the [QT Creator instructions](https://github.com/bitcoin/bitcoin/blob/master/doc/build-osx.md#using-qt-creator-as-ide).

Backport of Bitcoin Core PR11989
bitcoin/bitcoin#11989

Test Plan:
```
make check-all
```

Reviewers: Fabien, #bitcoin_abc, deadalnix, jasonbcox

Reviewed By: #bitcoin_abc, jasonbcox

Differential Revision: https://reviews.bitcoinabc.org/D4063
@bitcoin bitcoin locked as resolved and limited conversation to collaborators Sep 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants