[qt] change µBTC to bits

[jb55]

Now that we have bip176, change "µBTC" to the more colloquial "bits"

[Sjors]

I would suggest bits (µBTC), Bits (µBTC) or µBTC (bits), so more SI oriented folks don't need to Google "bits". Can you add some screenshots to see what this would look like in the UI?

[Sjors]

Also paging @jimmysong who opened this can of worms :-)

[jimmysong]

I would love if we can switch to bits, but not required. I understand if people don't want to change it.

[jb55]

current pic: https://jb55.com/s/2fbb07812e2dd00b.png

I would suggest `bits (µBTC)`, `Bits (µBTC)` or `µBTC (bits)`, so more SI oriented folks don't need to Google "bits".

This information is still available in the tooltip via BitcoinUnits::description if needed

Can you add some screenshots to see what this would look like in the UI?

This isn't a quick fix like this change, and will require some reworking so that it shows `bits` instead of `bits (µBTC)` everywhere.

[Sjors]

@jb55 you can actually drag & drop images onto Github, so they're inline.

There's more places where "bits" would appear, e.g. in the settings and as a dropdown in the send screen. If we go for bits (µBTC) that would probably look fine in a dropdown menu, but look terrible on the transactions screen. Whereas bits probably looks fine everywhere.

I remember the first time I saw the term "bits" in a wallet (Xapo). I found it very confusing, because I didn't know how many decimals it represents. I'm fine with switching to bits, but shouldn't assume all users are familiar with it. So it requires some education.

The easiest way to achieve a minimum level of education is to have two strings. Use the short version bits everywhere expect the dropdown menus, where you use the long string bits (µBTC). That would add a few lines of code to this PR, but nothing unsurmountable. Let me know if you need any pointers.

The tooltips are useful as well, but I don't think those appear over the dropdown menus.

[jb55]

I've implemented your suggestion in af7f3c1ccafefd92603a5138a136a52f0c249fe9

Here's what it looks like:

[Sjors]

ACK af7f3c1c, but please squash.

[jb55]

Squashed in 275b2ee

[Sjors]

Thanks, reACK 275b2ee.

[laanwj]

No opinion on this but at least you should update doc/bips.md when you do this.

[jb55]

@laanwj done in ebcee1d

[laanwj]

Tested ACK ebcee1d

[jonasschnelli]

utACK ebcee1d