[qt] Replaces numbered place marker %2 with %1. #12092
Merged
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replaces numbered place marker %2 with %1, because the QString::arg() member function is called once on the string used to create the QString object.
|
Tested ACK 8a93543
|
|
Thanks. I missed this in 6dd3a44 |
maflcko
pushed a commit
that referenced
this pull request
Jan 5, 2018
8a93543 Replaces numbered place marker %2 with %1. (251) Pull request description: This PR closes #12015 in which @chen610620 suggests to replace numbered place marker `%2` with `%1`. Calling member function`QString::arg()` on a `QString` object with one arbitrary numbered place marker within the range [1,99] works, because `QString::arg()` replaces the _lowest_ numbered place marker in the `QString` object it is called on. [QString::arg documentation:](http://doc.qt.io/qt-5/qstring.html#arg) > Returns a copy of this string with the lowest numbered place marker replaced by string a, i.e., %1, %2, ..., %99. I suspect that the `%2` marker is just an unfortunate typo or the remainder of a string that used to have multiple numbered place markers. This PR replaces the numbered place marker `%2` with `%1` to avoid any confusion in the future. Tree-SHA512: 0bb40cf3b9824e1eeba0a184e72358b30d20e8261e12deb287155b7cc8317ad0b0787ef1d0671325eb8bccc9e51b3037d737015749338c31cf400930840e56b6
l2a5b1
deleted the
patch/12015/sendcoinsdialog-replaces-numbered-place-marker
branch
jasonbcox
pushed a commit
to Bitcoin-ABC/bitcoin-abc
that referenced
this pull request
Sep 27, 2019
Summary: This PR closes #12015 in which @chen610620 suggests to replace numbered place marker `%2` with `%1`. Backport of Bitcoin Core PR12092 bitcoin/bitcoin#12092 Test Plan: ``` make ./src/qt/bitcoin-qt -regtest ``` 1. Open the "Send" dialog. 2. Enter a BCH testnet address. 3. Enter a valid amount. 4. Press "Send" button, at bottom. 5. Check that the confirmation message is Ok. Reviewers: Fabien, #bitcoin_abc, deadalnix Reviewed By: #bitcoin_abc, deadalnix Differential Revision: https://reviews.bitcoinabc.org/D4077
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR closes #12015 in which @chen610620 suggests to replace numbered place marker
%2with%1.Calling member function
QString::arg()on aQStringobject with one arbitrary numbered place marker within the range [1,99] works, becauseQString::arg()replaces the lowest numbered place marker in theQStringobject it is called on.QString::arg documentation:
I suspect that the
%2marker is just an unfortunate typo or the remainder of a string that used to have multiple numbered place markers.This PR replaces the numbered place marker
%2with%1to avoid any confusion in the future.