New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Trivial: Fix #include sys/fcntl.h to just fcntl.h (without sys/) #12168
Conversation
Rationale: compiling on musl-based system (Alpine Linux for example) produces warnings. It just should be without |
utACK 648bdc8 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Heh, I have the same commit queued up locally from testing with musl this week.
I believe there are some ancient OSs that may only have the sys/fcntl.h version, but I'm ok with not adding detection until someone complains about an actual failed build.
utACK 648bdc8
utACK 648bdc8 |
…out sys/) 648bdc8 Trivial: Fix #include sys/fcntl.h to just fcntl.h (without sys/) (Jan Sarenik) Pull request description: http://pubs.opengroup.org/onlinepubs/009695399/functions/fcntl.html http://man7.org/linux/man-pages/man2/fcntl.2.html Tree-SHA512: 82c7e0aba55f34a6fec60bdecb712b65c84422461454f0ae9eed5e1bb31bf585c5a65f49bbdd5a89feb59140a998ad6fcd5573ede123a12b2ba2ff677d95cc2b
…h (without sys/) 648bdc8 Trivial: Fix #include sys/fcntl.h to just fcntl.h (without sys/) (Jan Sarenik) Pull request description: http://pubs.opengroup.org/onlinepubs/009695399/functions/fcntl.html http://man7.org/linux/man-pages/man2/fcntl.2.html Tree-SHA512: 82c7e0aba55f34a6fec60bdecb712b65c84422461454f0ae9eed5e1bb31bf585c5a65f49bbdd5a89feb59140a998ad6fcd5573ede123a12b2ba2ff677d95cc2b
…h (without sys/) 648bdc8 Trivial: Fix #include sys/fcntl.h to just fcntl.h (without sys/) (Jan Sarenik) Pull request description: http://pubs.opengroup.org/onlinepubs/009695399/functions/fcntl.html http://man7.org/linux/man-pages/man2/fcntl.2.html Tree-SHA512: 82c7e0aba55f34a6fec60bdecb712b65c84422461454f0ae9eed5e1bb31bf585c5a65f49bbdd5a89feb59140a998ad6fcd5573ede123a12b2ba2ff677d95cc2b
…h (without sys/) 648bdc8 Trivial: Fix #include sys/fcntl.h to just fcntl.h (without sys/) (Jan Sarenik) Pull request description: http://pubs.opengroup.org/onlinepubs/009695399/functions/fcntl.html http://man7.org/linux/man-pages/man2/fcntl.2.html Tree-SHA512: 82c7e0aba55f34a6fec60bdecb712b65c84422461454f0ae9eed5e1bb31bf585c5a65f49bbdd5a89feb59140a998ad6fcd5573ede123a12b2ba2ff677d95cc2b
…h (without sys/) 648bdc8 Trivial: Fix #include sys/fcntl.h to just fcntl.h (without sys/) (Jan Sarenik) Pull request description: http://pubs.opengroup.org/onlinepubs/009695399/functions/fcntl.html http://man7.org/linux/man-pages/man2/fcntl.2.html Tree-SHA512: 82c7e0aba55f34a6fec60bdecb712b65c84422461454f0ae9eed5e1bb31bf585c5a65f49bbdd5a89feb59140a998ad6fcd5573ede123a12b2ba2ff677d95cc2b
…h (without sys/) 648bdc8 Trivial: Fix #include sys/fcntl.h to just fcntl.h (without sys/) (Jan Sarenik) Pull request description: http://pubs.opengroup.org/onlinepubs/009695399/functions/fcntl.html http://man7.org/linux/man-pages/man2/fcntl.2.html Tree-SHA512: 82c7e0aba55f34a6fec60bdecb712b65c84422461454f0ae9eed5e1bb31bf585c5a65f49bbdd5a89feb59140a998ad6fcd5573ede123a12b2ba2ff677d95cc2b
…h (without sys/) 648bdc8 Trivial: Fix #include sys/fcntl.h to just fcntl.h (without sys/) (Jan Sarenik) Pull request description: http://pubs.opengroup.org/onlinepubs/009695399/functions/fcntl.html http://man7.org/linux/man-pages/man2/fcntl.2.html Tree-SHA512: 82c7e0aba55f34a6fec60bdecb712b65c84422461454f0ae9eed5e1bb31bf585c5a65f49bbdd5a89feb59140a998ad6fcd5573ede123a12b2ba2ff677d95cc2b
…h (without sys/) 648bdc8 Trivial: Fix #include sys/fcntl.h to just fcntl.h (without sys/) (Jan Sarenik) Pull request description: http://pubs.opengroup.org/onlinepubs/009695399/functions/fcntl.html http://man7.org/linux/man-pages/man2/fcntl.2.html Tree-SHA512: 82c7e0aba55f34a6fec60bdecb712b65c84422461454f0ae9eed5e1bb31bf585c5a65f49bbdd5a89feb59140a998ad6fcd5573ede123a12b2ba2ff677d95cc2b
http://pubs.opengroup.org/onlinepubs/009695399/functions/fcntl.html
http://man7.org/linux/man-pages/man2/fcntl.2.html