Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test_runner: Readable output if create_cache.py fails #12227

Merged
merged 1 commit into from Jan 22, 2018

Conversation

ryanofsky
Copy link
Contributor

Without this change, create_cache.py process output is shown as a byte() object
with \n escapes in a single line that is hard to read.

Without this change, create_cache.py process output is shown as a byte() object
with \n escapes in a single line that is hard to read.
@fanquake fanquake added the Tests label Jan 19, 2018
@promag
Copy link
Member

promag commented Jan 20, 2018

How did you reproduce the problem?

@meshcollider
Copy link
Contributor

LGTM, utACK ac96e78

@maflcko maflcko merged commit ac96e78 into bitcoin:master Jan 22, 2018
maflcko pushed a commit that referenced this pull request Jan 22, 2018
ac96e78 test_runner: Readable output if create_cache.py fails (Russell Yanofsky)

Pull request description:

  Without this change, create_cache.py process output is shown as a byte() object
  with \n escapes in a single line that is hard to read.

Tree-SHA512: 49cd0fff037c03f558e31a1281712cc4419df6c4ed8b342057a3d54ab6b31180e1a23cb586686952d81b8add5bec07844efa8cdf16ad20f40cc903a19437fda5
@jnewbery
Copy link
Contributor

jnewbery commented Jan 22, 2018

post merge tested ACK ac96e78.

How did you reproduce the problem?

add assert False to the run() method in create_cache.py

PastaPastaPasta pushed a commit to PastaPastaPasta/dash that referenced this pull request Apr 6, 2020
…fails

ac96e78 test_runner: Readable output if create_cache.py fails (Russell Yanofsky)

Pull request description:

  Without this change, create_cache.py process output is shown as a byte() object
  with \n escapes in a single line that is hard to read.

Tree-SHA512: 49cd0fff037c03f558e31a1281712cc4419df6c4ed8b342057a3d54ab6b31180e1a23cb586686952d81b8add5bec07844efa8cdf16ad20f40cc903a19437fda5
PastaPastaPasta pushed a commit to PastaPastaPasta/dash that referenced this pull request Apr 8, 2020
…fails

ac96e78 test_runner: Readable output if create_cache.py fails (Russell Yanofsky)

Pull request description:

  Without this change, create_cache.py process output is shown as a byte() object
  with \n escapes in a single line that is hard to read.

Tree-SHA512: 49cd0fff037c03f558e31a1281712cc4419df6c4ed8b342057a3d54ab6b31180e1a23cb586686952d81b8add5bec07844efa8cdf16ad20f40cc903a19437fda5
@bitcoin bitcoin locked as resolved and limited conversation to collaborators Sep 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants