Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[rpc] Mention that HD is enabled if hdmasterkeyid is present #12293

Merged
merged 1 commit into from Jan 29, 2018
Merged

[rpc] Mention that HD is enabled if hdmasterkeyid is present #12293

merged 1 commit into from Jan 29, 2018

Conversation

fanquake
Copy link
Member

Also adds optional flag.

Replaces #12042

@fanquake fanquake mentioned this pull request Jan 29, 2018
Closed
@laanwj
Copy link
Member

laanwj commented Jan 29, 2018

docchange-only-utACK c6b6385

jonasschnelli
jonasschnelli approved these changes Jan 29, 2018
View reviewed changes
Copy link
Contributor

@jonasschnelli jonasschnelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK c6b6385

@maflcko
Copy link
Member

maflcko commented Jan 29, 2018

Thanks for picking this up.

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

utACK c6b6385651d5e78daf9dd27717e47e3a8940694b
-----BEGIN PGP SIGNATURE-----

iQIcBAEBCgAGBQJab4QHAAoJENLqSFDnUoslqngP/1+6Cpoqirp1NaaYTaTZri4I
4rzH6wQV5dkK0Fkr8CtSc1Fhj9p99sExzX6vBemZZzUMVLhlTP9/Q39tOmAUvN7o
DrUBHfPVGQsGPhTeFJ/nWQb9Vju51PBl2ma5Fpq8nYA9SblfKVrK1qbGYRRFU42w
9sk+6MYBKcjvTUMryR9Go66TV0l3n6OyIA6awrn9UyopBqPLRg6VEdeV1uecdcnP
40XdYvDdlqjCo6HSJGkppjNx5ok+4u9v3nY1k1Xl6w0Jti0DLm+6nPS0DYBNUC97
UerN2FtOXrfA0+nQUtB8ZDjBWPtIHw+WwVrXfD4yt1UKei8Ko7NQv/esP1OtpySS
/9eYDXNBg+HXMLgKNz43Hh2tLP63B4r3cJeKu04WfjItguK5YisdLZF3ErydmLLW
c9UrVyoCulCfwnNr86KUL/m+nIZKO1z5pZ+xs/3BZw6D5/ZUxIsq6CKycZfIe942
fjCSg4UlTu4OB06g/D84S+q3n1QUZG83BNQM8XXZaEqMBDnknz3SMorIlm1r4gIq
DkaUkBHQY099VgO7SHp/q3JhZ2ztPT0w1q1wSsflM91YDfUXOI6JeWOKjKrGiz5+
r0EAsszRhsJnJb56rpdX2JE6rBAS4nrW0N8PFzPj0IdjUfKT/yXE2ki1OYfL7dlh
DcAROue7amNsWL3JCj0k
=vV0d
-----END PGP SIGNATURE-----

@maflcko maflcko merged commit c6b6385 into bitcoin:master Jan 29, 2018
maflcko pushed a commit that referenced this pull request Jan 29, 2018
Merge #12293: [rpc] Mention that HD is enabled if hdmasterkeyid is pr…
9d9c418 
…esent

c6b6385 [rpc] Mention that HD is enabled if hdmasterkeyid is present (fanquake)

Pull request description:

  Also adds optional flag.

  Replaces #12042

Tree-SHA512: 6aded2cf36799f697eacbe4f51dff7c8110281092ca3c4fd73e26f57d788ec95a4fcbaf6976ef144e64f2e52759dbe241ac218a95e5ca2233cae1b98bfa5872e
@fanquake fanquake deleted the is-hd-enabled-rpc branch January 30, 2018 07:19
@bitcoin bitcoin deleted a comment Jan 30, 2018
@bitcoin bitcoin locked as resolved and limited conversation to collaborators Sep 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jonasschnelli jonasschnelli jonasschnelli approved these changes

@promag promag Awaiting requested review from promag

Assignees
No one assigned
Labels
RPC/REST/ZMQ Wallet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@fanquake @laanwj @maflcko @jonasschnelli