New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow dustrelayfee to be set to zero #12568

Merged
merged 1 commit into from Mar 5, 2018

Conversation

Projects
None yet
9 participants
@luke-jr
Member

luke-jr commented Feb 28, 2018

I don't see and can't think of any rationale for forbidding this configuration.

@Empact

This comment has been minimized.

Member

Empact commented Mar 1, 2018

GetDustThreshold is defined relative to dustRelayFee, FYI:

    // "Dust" is defined in terms of dustRelayFee,
    // which has units satoshis-per-kilobyte.
    // If you'd pay more in fees than the value of the output
    // to spend something, then we consider it dust.
    // A typical spendable non-segwit txout is 34 bytes big, and will
    // need a CTxIn of at least 148 bytes to spend:
    // so dust is a spendable txout less than
    // 182*dustRelayFee/1000 (in satoshis).
    // 546 satoshis at the default rate of 3000 sat/kB.
    // A typical spendable segwit txout is 31 bytes big, and will
    // need a CTxIn of at least 67 bytes to spend:
    // so dust is a spendable txout less than
    // 98*dustRelayFee/1000 (in satoshis).
    // 294 satoshis at the default rate of 3000 sat/kB.
@morcos

This comment has been minimized.

Member

morcos commented Mar 4, 2018

utACK

@MarcoFalke

This comment has been minimized.

Member

MarcoFalke commented Mar 4, 2018

Concept ACK. Might as well fix the braces {}, since this is a tiny code change.

@practicalswift

This comment has been minimized.

Member

practicalswift commented Mar 5, 2018

utACK 874e818

@laanwj

This comment has been minimized.

Member

laanwj commented Mar 5, 2018

I don't see and can't think of any rationale for forbidding this configuration.

Potential rationales, for sanity check:

  • Is zero ever used as special value?
  • Do we ever divide by this value?
@morcos

This comment has been minimized.

Member

morcos commented Mar 5, 2018

@laanwj I reviewed for those concerns and did not find anything of note. A couple of tests assume there is a dustrelayfee and will break if we change the default to 0, but nothing that needs to be changed for this PR.

@promag

This comment has been minimized.

Member

promag commented Mar 5, 2018

utACK 874e818.

There is no rationale in #9380 for such condition.

@laanwj laanwj merged commit 874e818 into bitcoin:master Mar 5, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

laanwj added a commit that referenced this pull request Mar 5, 2018

Merge #12568: Allow dustrelayfee to be set to zero
874e818 Allow dustrelayfee to be set to zero (Luke Dashjr)

Pull request description:

  I don't see and can't think of any rationale for forbidding this configuration.

Tree-SHA512: df09441f4aec63e79bea94838b7f8e336cebaeb0a22b5e58d27937bbeb1377f229921aeae43674e0b63fc40a39ae51a264d48aa1cdb4cbd0e3339d32856698bf
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment