Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid querying unnecessary model data when filtering transactions #12621

Merged
merged 1 commit into from Mar 15, 2018

Conversation

Projects
None yet
8 participants
@promag
Copy link
Member

promag commented Mar 6, 2018

This change moves down model data querying to where it's needed. The worst case remains the same (all data is queried and the row passes) but for the average case it improves the filter performance.

@fanquake fanquake added the GUI label Mar 6, 2018

@laanwj

This comment has been minimized.

Copy link
Member

laanwj commented Mar 6, 2018

Makes sense, utACK

@practicalswift

This comment has been minimized.

Copy link
Member

practicalswift commented Mar 6, 2018

Concept ACK

@jonasschnelli

This comment has been minimized.

Copy link
Member

jonasschnelli commented Mar 7, 2018

utACK 0e9d0eb946b8dad0b1688016d5bef69bb0b07279

@promag promag force-pushed the promag:2018-03-transaction-filter-avoid-querying branch Mar 7, 2018

@promag

This comment has been minimized.

Copy link
Member Author

promag commented Mar 7, 2018

Rebased.

@MarcoFalke

This comment has been minimized.

Copy link
Member

MarcoFalke commented Mar 8, 2018

Needs rebase to fix travis (sorry)

@promag promag force-pushed the promag:2018-03-transaction-filter-avoid-querying branch to 1ee72a8 Mar 11, 2018

@promag

This comment has been minimized.

Copy link
Member Author

promag commented Mar 11, 2018

Rebased.

@promag

This comment has been minimized.

Copy link
Member Author

promag commented Mar 13, 2018

Kicked travis job, feature_block.py failed 🙄.

@MeshCollider

This comment has been minimized.

Copy link
Member

MeshCollider commented Mar 14, 2018

utACK 1ee72a8

@sipa

This comment has been minimized.

Copy link
Member

sipa commented Mar 15, 2018

utACK 1ee72a8

@sipa sipa merged commit 1ee72a8 into bitcoin:master Mar 15, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

sipa added a commit that referenced this pull request Mar 15, 2018

Merge #12621: Avoid querying unnecessary model data when filtering tr…
…ansactions

1ee72a8 qt: Avoid querying unnecessary model data when filtering transactions (João Barbosa)

Pull request description:

  This change moves down model data querying to where it's needed. The worst case remains the same (all data is queried and the row passes) but for the average case it improves the filter performance.

Tree-SHA512: 3bcaced029cb39dfbc5377246ce76634f9050ee3a3053db4d358fcbf4d8107c649e75841f21d69f1aebcaf1bbffe3eac784e6b03b366fdbbfec1e0da8f78d8ef
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.