Make use of cpuid.h bit definitions #12921
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These are defined in cpuid.h and are self-documenting for more expressive code. https://clang.llvm.org/doxygen/cpuid_8h_source.html
|
How portable is this to other compilers, such as GCC or MSVC? I don't think this is a C standard. |
|
Good point, I used definitions found in the current GCC & clang headers: GCC's was added 11 years ago, but the clang definition was added 2 years ago: Which explains why the mac 10.11 build is failing: Couldn't find anything about msvc support. Closing this as not ready for use. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are defined in cpuid.h and are self-documenting for more expressive code.
https://clang.llvm.org/doxygen/cpuid_8h_source.html
Prompted by looking into #12903