Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Windows: Avoid launching as admin when NSIS installer ends. #12985

Merged
merged 1 commit into from Apr 18, 2018
Merged

Windows: Avoid launching as admin when NSIS installer ends. #12985

merged 1 commit into from Apr 18, 2018

Commits on Apr 14, 2018

  1. Avoid launching as admin when NSIS installer ends. 

    The Bitcoin Core NSIS script runs with elevated privileges.  Unfortunately, this means that it launches Bitcoin Core itself with elevated privileges when the user chooses to launch Bitcoin Core at the end of the installation procedure.  This commit works around the issue by having explorer.exe launch Bitcoin Core.  Seems to be a similar approach to what http://nsis.sourceforge.net/ShellExecAsUser_plug-in does, but without a plugin.

h/t to "UK" at https://mdb-blog.blogspot.se/2013/01/nsis-lunch-program-as-user-from-uac.html?showComment=1410158039989#c2463780017054126736 for the sample code.

Fixes bitcoin#7990.
    @JeremyRand
    JeremyRand committed Apr 14, 2018
    Copy the full SHA
    7d8a8cc View commit details
    Browse the repository at this point in the history