[travis] New travis job for CHECK_DOCS steps #13183
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glaksmono
force-pushed
the
bitcoin-11004
branch
3 times, most recently
from
e748795
to
d4ccec8
Compare
maflcko
reviewed
May 7, 2018
.travis.yml
Outdated
| include: | ||
| - stage: CHECK_DOC | ||
| env: | ||
| - HOST=arm-linux-gnueabihf PACKAGES="g++-arm-linux-gnueabihf python3-pip shellcheck" DEP_OPTS="NO_QT=1" CHECK_DOC=1 GOAL="install" BITCOIN_CONFIG="--enable-glibc-back-compat --enable-reduce-exports" |
There was a problem hiding this comment.
Please keep the actual arm cross build intact. The only thing you'd need to move here is the pip and shellcheck package
Also, would be nice if the check doc run before the tests, not the other way round.
There was a problem hiding this comment.
HOST=arm-linux-gnueabihf will be executed twice in the check_doc and test then?
maflcko
changed the title
glaksmono
force-pushed
the
bitcoin-11004
branch
3 times, most recently
from
7ae6e40
to
549be8a
Compare
|
You wouldn't need to set environment variables that are not used for the
check doc. I.e. no need for the cross compile HOST ...
…On Mon, May 7, 2018, 10:43 Grady Laksmono ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In .travis.yml
<#13183 (comment)>:
> @@ -84,3 +70,24 @@ script:
after_script:
- echo $TRAVIS_COMMIT_RANGE
- echo $TRAVIS_COMMIT_LOG
+
+jobs:
+ include:
+ - stage: CHECK_DOC
+ env:
+ - HOST=arm-linux-gnueabihf PACKAGES="g++-arm-linux-gnueabihf python3-pip shellcheck" DEP_OPTS="NO_QT=1" CHECK_DOC=1 GOAL="install" BITCOIN_CONFIG="--enable-glibc-back-compat --enable-reduce-exports"
HOST=arm-linux-gnueabihf will be executed twice in the check_doc and test
then?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#13183 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AGGmv2lQYTRAB2bg70MXl0ugLJVNhLGeks5twF2agaJpZM4T0v_5>
.
|
maflcko
reviewed
May 7, 2018
.travis.yml
Outdated
| - stage: check_doc | ||
| sudo: required | ||
| env: | ||
| - PACKAGES="python3-pip shellcheck" CHECK_DOC=1 |
maflcko
reviewed
May 7, 2018
.travis.yml
Outdated
| @@ -22,7 +25,7 @@ env: | |||
| - WINEDEBUG=fixme-all | |||
| matrix: | |||
| # ARM | |||
| - HOST=arm-linux-gnueabihf PACKAGES="g++-arm-linux-gnueabihf python3-pip shellcheck" DEP_OPTS="NO_QT=1" CHECK_DOC=1 GOAL="install" BITCOIN_CONFIG="--enable-glibc-back-compat --enable-reduce-exports" | |||
| - HOST=arm-linux-gnueabihf PACKAGES="g++-arm-linux-gnueabihf python3-pip shellcheck" DEP_OPTS="NO_QT=1" GOAL="install" BITCOIN_CONFIG="--enable-glibc-back-compat --enable-reduce-exports" | |||
There was a problem hiding this comment.
can remove pip and shellcheck here
maflcko
reviewed
May 7, 2018
.travis.yml
Outdated
| jobs: | ||
| include: | ||
| - stage: check_doc | ||
| sudo: required |
There was a problem hiding this comment.
You can get rid of sudo here to speed up the boot-process:
diff --git a/.travis.yml b/.travis.yml
index f3f5305e4a..f547b3dc42 100644
--- a/.travis.yml
+++ b/.travis.yml
@@ -79,12 +79,13 @@ after_script:
jobs:
include:
- stage: check_doc
- sudo: required
- env:
- - PACKAGES="python3-pip shellcheck"
+ sudo: false
+ addons:
+ apt:
+ packages:
+ - python3-pip
+ - shellcheck
install:
- - if [ -n "$PACKAGES" ]; then travis_retry sudo apt-get update; fi
- - if [ -n "$PACKAGES" ]; then travis_retry sudo apt-get install --no-install-recommends --no-upgrade -qq $PACKAGES; fi
- if [ "$TRAVIS_EVENT_TYPE" = "pull_request" ]; then travis_retry pip3 install flake8 --user; fi
before_script:
- git fetch --unshallow
maflcko
reviewed
May 7, 2018
| @@ -8,6 +8,9 @@ cache: | |||
| - depends/built | |||
| - depends/sdk-sources | |||
| - $HOME/.ccache | |||
| stages: | |||
| - check_doc | |||
| - test | |||
| env: | |||
| global: | |||
| - MAKEJOBS=-j3 | |||
There was a problem hiding this comment.
Can remove the CHECK_DOC on the line below this one.
ken2812221
reviewed
May 8, 2018
|
|
||
| jobs: | ||
| include: | ||
| - stage: check_doc |
There was a problem hiding this comment.
How about add sudo: false here, travis can boot faster
Seems not work.
There was a problem hiding this comment.
Please see my previous diff to get it to work
|
Concept ACK |
maflcko
changed the title
|
Please squash your commits according to https://github.com/bitcoin/bitcoin/blob/master/CONTRIBUTING.md#squashing-commits |
…from the core jobs
ken2812221
approved these changes
May 9, 2018
|
utACK 18c0b84. Thanks for sticking with this. Indeed a very nice first contribution! |
|
Thank you for all of the guidance @MarcoFalke |
|
utACK 18c0b84 |
|
re-utACK 18c0b84 |
laanwj
added a commit
that referenced
this pull request
May 9, 2018
18c0b84 [bitcoin-11004] creating another jobs for the CHECK_DOC=1, separated from the core jobs (Grady Laksmono) Pull request description: Configure a new Travis job that runs against PRs, and only runs the `CHECK_DOC` tests. At the same time, the `CHECK_DOC` stuff in the existing job would be removed. Fixes #11004 Tree-SHA512: 6e1ed0a0742f2f141ac40c666538d4c0d5eab5766a2f2364ba6d940a9be6c93a28970a4191b0641a61e25fe87e3af2367e51a43f3bc930f819be2a2c54326b1d
|
Thanks @glaksmono! Very nice contribution! |
TheArbitrator
pushed a commit
to TheArbitrator/dash
that referenced
this pull request
Jun 7, 2021
18c0b84 [bitcoin-11004] creating another jobs for the CHECK_DOC=1, separated from the core jobs (Grady Laksmono) Pull request description: Configure a new Travis job that runs against PRs, and only runs the `CHECK_DOC` tests. At the same time, the `CHECK_DOC` stuff in the existing job would be removed. Fixes bitcoin#11004 Tree-SHA512: 6e1ed0a0742f2f141ac40c666538d4c0d5eab5766a2f2364ba6d940a9be6c93a28970a4191b0641a61e25fe87e3af2367e51a43f3bc930f819be2a2c54326b1d
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Configure a new Travis job that runs against PRs, and only runs the
CHECK_DOCtests. At the same time, theCHECK_DOCstuff in the existing job would be removed.Fixes #11004