Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While testing some of @theuni's work for iOS cross builds in depends, I found a locale related issue that appears when preprocessing OpenSSL's
Configure
. This is on macOS 10.13.5.7ac0c67 (a subset of the iOS related build changes) is included to show the issue.
When doing a depends build with master (6579d80) + that commit I see:
It seems like the issue could be related to embedded double quotes.
I did try setting other locale related variables:
LANGUAGE=C
LC_ALL=C
LC_CTYPE=C
etc, however
LANG=C
was the only one that actually seemed to work.This is the output of
locale
on my machine:Todo:
sed
in/depends/packages
.