-
Notifications
You must be signed in to change notification settings - Fork 36k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
getblocktemplate: longpolling support #1355
Conversation
ACK on longpolling support in general. Long polling turns out to be a useful way to avoid http callbacks, with all the authentication that that entails.
|
ACK longpolling support Change appears mostly ACK-worthy. I worry about adding a new lock deep inside SetBestChain though. |
Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/f1d42a05fe27d14f258ec5e1b15774dad583d458 for binaries and test log. |
Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/650ea32bbd60ac149809333131bd887537afa477 for binaries and test log. |
Rebased |
Re-rebase requested, now that BIP 22 is merged |
done |
|
|
Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/01e0e197ebb96cb14971c672b5704306e3ad0f1f for binaries and test log. |
Rebased without the while(0). I still don't see any hashBestChain accessing outside of locks, after looking over it again. With regard to TCP disconnects, I did look into this, but it seems not worth the effort considering:
Thoughts? |
No code objections. The main question remaining on this, our oldest pullreq: do we want/need it? |
I tested this a while ago and did not find it suitable for deployment as is.
|
Err, no I didn't :( |
Built on top of #936, this adds support for getblocktemplate longpolling to bitcoind.