Show how long AcceptBlock() takes to process. #1377
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -1818,6 +1829,9 @@ bool ProcessBlock(CNode* pfrom, CBlock* pblock) | |||
| if (!pblock->AcceptBlock()) | |||
| return error("ProcessBlock() : AcceptBlock FAILED"); | |||
|
|
|||
| printf("Block ACCEPTED %15"PRI64d"ms\n", GetTimeMillis() - nStart); | |||
| nStart = GetTimeMillis(); | |||
There was a problem hiding this comment.
This should be inside the foreach loop...
There was a problem hiding this comment.
@luke-jr Ah, I had it inside on another branch, but it got missed in this one. Fixed. Thanks.
|
NACK. If you want to time stuff, then use -logtimestamps, lets not dirty up the code with lots of special-case timing logic. |
|
@gavinandresen why do we time other things then, such as flushing, etc? |
|
Either because those other things were implemented before -logtimestamps or because I didn't notice/ask that they get removed after whatever optimization they were a part of got pulled. |
|
nak'd by gavin, closing |
suprnurd
pushed a commit
to chaincoin-legacy/chaincoin
that referenced
this pull request
Dec 5, 2017
Imports keys from an Electrum wallet export file (.csv or .json)
lateminer
pushed a commit
to lateminer/bitcoin
that referenced
this pull request
Jan 22, 2019
Encapsulate nodestate
lateminer
pushed a commit
to lateminer/bitcoin
that referenced
this pull request
May 6, 2020
a43aefd Update settingsbittoolwidget.cpp (RottenCoin) Pull request description: correction ACKs for top commit: random-zebra: utACK a43aefd furszy: utACK a43aefd and merging.. Tree-SHA512: 649cf44c136b6e750009f95157a557f06aff24022702b5702b68da4fa39550409a1b1ae9fc093d9e0b788a4dcd6b6ad53564a693a7e9044cf6b991dac23358fa
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds timing information for ProcessBlock and AcceptBlock, using the currently existing "ACCEPTED" line, but with timing infomation added.
Also, as a nicety, once the block chain has caught up, some an additional line is shown providing feedback on what bitcoind is doing (i.e. when validating a block).