tx pool: Avoid passing redundant hash into addUnchecked (scripted-diff) #13792
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maflcko
force-pushed
the
Mf1808-constTxPoolEntries
branch
3 times, most recently
from
5bbe638
to
8c9d589
Compare
Note to reviewers: This pull request conflicts with the following ones:
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first. |
This was referenced Jul 29, 2018
|
Looks like the scripted-diff is failing because of the other whitespace/formatting changes also included in 8c9d589. |
maflcko
force-pushed
the
Mf1808-constTxPoolEntries
branch
2 times, most recently
from
21a6366
to
376e27b
Compare
-BEGIN VERIFY SCRIPT- git grep -l addUnchecked | xargs sed --regexp-extended -i -e 's/addUnchecked\([^)][^,]+,\s*/addUnchecked(/g' -END VERIFY SCRIPT-
maflcko
force-pushed
the
Mf1808-constTxPoolEntries
branch
from
376e27b
to
fa58777
Compare
maflcko
force-pushed
the
Mf1808-constTxPoolEntries
branch
2 times, most recently
from
0e97ce7
to
fa58777
Compare
maflcko
changed the title
|
This is split off of #13804, but not required. So if people hate this kind of refactoring, I am happy to drop it. |
|
Concept ACK |
|
utACK fa58777 |
|
utACK fe5c497 |
laanwj
added a commit
that referenced
this pull request
Aug 29, 2018
… (scripted-diff) fa58777 scripted-diff: Remove unused first argument to addUnchecked (MarcoFalke) fe5c497 tx pool: Use the entry's hash instead of the one passed to addUnchecked (MarcoFalke) ddd395f Mark CTxMemPoolEntry members that should not be modified const (MarcoFalke) Pull request description: Several years ago the transaction hash was not cached. For optimization the hash was instead passed into `addUnchecked` to avoid re-calculating it. See f77654a Passing in the hash is now redundant and the argument can safely be removed. Tree-SHA512: 0206b65c7a014295f67574120e8c5397bf1b1bd70c918ae1360ab093676f7f89a6f084fd2c7000a141baebfe63fe6f515559e38c4ac71810ba64f949f9c0467f
domob1812
added a commit
to domob1812/namecoin-core
that referenced
this pull request
Sep 3, 2018
Update auxpow_tests.cpp for the upstream refactoring in bitcoin/bitcoin#13792.
Munkybooty
pushed a commit
to Munkybooty/dash
that referenced
this pull request
Jun 30, 2021
…checked (scripted-diff) fa58777 scripted-diff: Remove unused first argument to addUnchecked (MarcoFalke) fe5c497 tx pool: Use the entry's hash instead of the one passed to addUnchecked (MarcoFalke) ddd395f Mark CTxMemPoolEntry members that should not be modified const (MarcoFalke) Pull request description: Several years ago the transaction hash was not cached. For optimization the hash was instead passed into `addUnchecked` to avoid re-calculating it. See f77654a Passing in the hash is now redundant and the argument can safely be removed. Tree-SHA512: 0206b65c7a014295f67574120e8c5397bf1b1bd70c918ae1360ab093676f7f89a6f084fd2c7000a141baebfe63fe6f515559e38c4ac71810ba64f949f9c0467f # Conflicts: # src/bench/mempool_eviction.cpp # src/test/mempool_tests.cpp # src/test/miner_tests.cpp # src/txmempool.cpp # src/txmempool.h # src/validation.cpp
PastaPastaPasta
pushed a commit
to PastaPastaPasta/dash
that referenced
this pull request
Jul 18, 2021
tx pool: Use the entry's hash instead of the one passed to addUnchecked Mark CTxMemPoolEntry members that should not be modified const
PastaPastaPasta
pushed a commit
to PastaPastaPasta/dash
that referenced
this pull request
Jul 18, 2021
tx pool: Use the entry's hash instead of the one passed to addUnchecked Mark CTxMemPoolEntry members that should not be modified const
PastaPastaPasta
pushed a commit
to PastaPastaPasta/dash
that referenced
this pull request
Jul 18, 2021
tx pool: Use the entry's hash instead of the one passed to addUnchecked Mark CTxMemPoolEntry members that should not be modified const
PastaPastaPasta
pushed a commit
to PastaPastaPasta/dash
that referenced
this pull request
Jul 19, 2021
tx pool: Use the entry's hash instead of the one passed to addUnchecked Mark CTxMemPoolEntry members that should not be modified const
PastaPastaPasta
pushed a commit
to PastaPastaPasta/dash
that referenced
this pull request
Jul 19, 2021
tx pool: Use the entry's hash instead of the one passed to addUnchecked Mark CTxMemPoolEntry members that should not be modified const
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Several years ago the transaction hash was not cached. For optimization the hash was instead passed into
addUncheckedto avoid re-calculating it. See f77654aPassing in the hash is now redundant and the argument can safely be removed.