Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

validation: Document where we are intentionally ignoring bool return values from validation related functions #13864

Closed
wants to merge 5 commits into from
Closed

validation: Document where we are intentionally ignoring bool return values from validation related functions #13864

wants to merge 5 commits into from

Commits on Oct 28, 2018

  1. Remove unused return value from LoadExternalBlockFile(...)

    @practicalswift
    practicalswift committed Oct 28, 2018
    Copy the full SHA
    d47f0b1 View commit details
    Browse the repository at this point in the history

  2. Remove unused return value from LoadMempool(...)

    @practicalswift
    practicalswift committed Oct 28, 2018
    Copy the full SHA
    4e8b3a1 View commit details
    Browse the repository at this point in the history

  3. Document where we are intentionally ignoring the return value from bo… 

    …ol returning functions from validation.{cpp,h} that modify state
    @practicalswift
    practicalswift committed Oct 28, 2018
    Copy the full SHA
    da395b9 View commit details
    Browse the repository at this point in the history

  4. Add #define NODISCARD

    @practicalswift
    practicalswift committed Oct 28, 2018
    Copy the full SHA
    b272348 View commit details
    Browse the repository at this point in the history

  5. Mark functions whose bool return value should not be discarded with N… 

    …ODISCARD
    @practicalswift
    practicalswift committed Oct 28, 2018
    Copy the full SHA
    71e5ce5 View commit details
    Browse the repository at this point in the history